Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] fs: fix undefined behavior in bit shift for SB_NOUSER
To:     Christoph Hellwig <hch@infradead.org>
CC:     <viro@zeniv.linux.org.uk>, <dhowells@redhat.com>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20221029071745.2836665-1-cuigaosheng1@huawei.com>
 <Y1/KdOyExwCdfCqb@infradead.org>
From:   cuigaosheng <cuigaosheng1@huawei.com>
Message-ID: <80107081-1c24-19d3-9a34-0ee61ac7c99d@huawei.com>
Date:   Mon, 31 Oct 2022 21:56:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <Y1/KdOyExwCdfCqb@infradead.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

> Let's mark all of the flags as unsigned instead of just one so that
> we don't mix types.  s_flags is already unsigned (although for some
> reason long) already.
>
> And while you touch this please add the proper whitespaces around the
> shift operator everywhere.

Thanks for taking time to review this patch, I have made patch v2 and submit it.

On 2022/10/31 21:15, Christoph Hellwig wrote:
> Let's mark all of the flags as unsigned instead of just one so that
> we don't mix types.  s_flags is already unsigned (although for some
> reason long) already.
>
> And while you touch this please add the proper whitespaces around the
> shift operator everywhere.