Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 31 Oct 2022 14:56:50 +0100
Message-Id: <CO05SSJUFW72.1PUZJ0FMJH3DF@otso>
Cc:     <quic_collinsd@quicinc.com>, <quic_subbaram@quicinc.com>,
        "Dylan Van Assche" <me@dylanvanassche.be>
Subject: Re: [PATCH v4 1/2] leds: flash: add driver to support flash LED
 module in QCOM PMICs
From:   "Luca Weiss" <luca.weiss@fairphone.com>
To:     "Fenglin Wu" <quic_fenglinw@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <krzysztof.kozlowski@linaro.org>, "Pavel Machek" <pavel@ucw.cz>,
        "Gene Chen" <gene_chen@richtek.com>,
        "Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
        <linux-leds@vger.kernel.org>
References: <20221025073802.2662564-1-quic_fenglinw@quicinc.com>
 <20221025073802.2662564-2-quic_fenglinw@quicinc.com>
In-Reply-To: <20221025073802.2662564-2-quic_fenglinw@quicinc.com>
Precedence: bulk

Hi Fenglin,

On Tue Oct 25, 2022 at 9:38 AM CEST, Fenglin Wu wrote:
> Add initial driver to support flash LED module found in Qualcomm
> Technologies, Inc. PMICs. The flash module can have 3 or 4 channels
> and each channel can be controlled indepedently and support full scale
> current up to 1.5 A. It also supports connecting two channels together
> to supply one LED component with full scale current up to 2 A. In that
> case, the current will be split on each channel symmetrically and the
> channels will be enabled and disabled at the same time.
>
> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
> Tested-by: Luca Weiss <luca.weiss@fairphone.com> # sm7225-fairphone-fp4 +=
 pm6150l
> ---
>  drivers/leds/flash/Kconfig           |  15 +
>  drivers/leds/flash/Makefile          |   1 +
>  drivers/leds/flash/leds-qcom-flash.c | 700 +++++++++++++++++++++++++++
>  3 files changed, 716 insertions(+)
>  create mode 100644 drivers/leds/flash/leds-qcom-flash.c
>

<snip>

> +static const struct of_device_id qcom_flash_led_match_table[] =3D {
> +	{ .compatible =3D "qcom,spmi-flash-led" },
> +	{ }
> +};

Dylan has noticed that auto-loading the module based on dt match doesn't
work currently. It seems that this line is missing here to enable that:

  MODULE_DEVICE_TABLE(of, qcom_flash_led_match_table);

Please add it for v5!

Regards
Luca

> +
> +static struct platform_driver qcom_flash_led_driver =3D {
> +	.driver =3D {
> +		.name =3D "leds-qcom-flash",
> +		.of_match_table =3D qcom_flash_led_match_table,
> +	},
> +	.probe =3D qcom_flash_led_probe,
> +	.remove =3D qcom_flash_led_remove,
> +};
> +
> +module_platform_driver(qcom_flash_led_driver);
> +
> +MODULE_DESCRIPTION("QCOM Flash LED driver");
> +MODULE_LICENSE("GPL");
> --=20
> 2.25.1