Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp987763rwi; Mon, 31 Oct 2022 09:50:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7IBdkKLJGMiodvNFd4vhXaO71pA9+xwGs2oUREve82ZMYmvN3/BET//T40ws1h979Ls9kV X-Received: by 2002:a63:df10:0:b0:43b:e82f:e01c with SMTP id u16-20020a63df10000000b0043be82fe01cmr13531887pgg.19.1667235018196; Mon, 31 Oct 2022 09:50:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667235018; cv=none; d=google.com; s=arc-20160816; b=kCtaIcn4wU9+oncC/ASKWIqgUZtnSBgEMupPA2zQiFQLbCv2fBaly7hBDJR2oaEeMi UDjn+wiLs4QzwOYk3uKP98Pxzt/n8uQnl8ZmJQFUvU/X2Yzzjfv58yOSWyB5ENzRmWhf XR+eTkwhvP9HPZoQL4VI9xwwYKgNZ3dJBKomUH0muowFYYp1rccC3iw5MO1OyOI5yzhJ myFUShL3hHFY972uuDhXSBQhwD1bNMZ3vay6RhujSiZW0f55+42m3jCv2lU/BPdhBKli 2HrH2elvqnwr7yKSCd+t79UPd00sINeFOsgZUNqtPtbyO5KEOqbdGdr0/xp3TsHR7cXv Wvqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id; bh=euUDTjbSSYZGItLwwErT72L2+QCjGU96qgHyi2VbdmU=; b=URnrO9yssKf0bbzaInv48KZ9S0z/zyMAlNxh9BQshbYmcRRE0nb9WxS0uR10HQwhgk l6AfvlsWzl1yHU4ZKVlF057lFmocIVLiiOsnowJLTNIbh/aTzvQi89A5vBhJCddxrgqI vJHxc9NpZOhyATRe3PRA5t3BYwchfyjzQcYrWeVfrshmL0rs9tHZBDgVjtSQSIfiwzfK Q7jSp5rIhV1fZKELW+tQSEIH4Zs8sRUnQX9ltSxOqW9SPAMdK3V/6fbufvAXOy5poehK kJa3jdPxmEmfcD6UUvvmONMfnAPMR/JZ2ukmONimajWYYscKqT8KWu6nreaJQHP0C3jr R7YQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h6-20020a056a00170600b0056bdae22580si11079636pfc.338.2022.10.31.09.50.04; Mon, 31 Oct 2022 09:50:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231548AbiJaQWm (ORCPT + 98 others); Mon, 31 Oct 2022 12:22:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230197AbiJaQWe (ORCPT ); Mon, 31 Oct 2022 12:22:34 -0400 X-Greylist: delayed 536 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 31 Oct 2022 09:22:30 PDT Received: from mailout.easymail.ca (mailout.easymail.ca [64.68.200.34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD8A1F5AD; Mon, 31 Oct 2022 09:22:30 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 17F9A660F6; Mon, 31 Oct 2022 16:13:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo07-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo07-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6y2a7YFjl0Ol; Mon, 31 Oct 2022 16:13:33 +0000 (UTC) Received: from mail.gonehiking.org (unknown [38.15.45.1]) by mailout.easymail.ca (Postfix) with ESMTPA id A928666047; Mon, 31 Oct 2022 16:13:33 +0000 (UTC) Received: from [192.168.1.4] (internal [192.168.1.4]) by mail.gonehiking.org (Postfix) with ESMTP id DCBF63EEDD; Mon, 31 Oct 2022 10:13:31 -0600 (MDT) Message-ID: Date: Mon, 31 Oct 2022 10:13:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Reply-To: khalid@gonehiking.org Subject: Re: [PATCH] scsi: BusLogic: remove variable adapter_count To: Colin Ian King , "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221031160512.872153-1-colin.i.king@gmail.com> Content-Language: en-US From: Khalid Aziz In-Reply-To: <20221031160512.872153-1-colin.i.king@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/22 10:05, Colin Ian King wrote: > Variable adapter_count is just being incremented and it's never used > anywhere else. The variable and the increment are redundant so > remove it. > > Signed-off-by: Colin Ian King > --- > drivers/scsi/BusLogic.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Looks good to me. Acked-by: Khalid Aziz > > diff --git a/drivers/scsi/BusLogic.c b/drivers/scsi/BusLogic.c > index f2abffce2659..f7b7ffda1161 100644 > --- a/drivers/scsi/BusLogic.c > +++ b/drivers/scsi/BusLogic.c > @@ -2198,7 +2198,7 @@ static int blogic_slaveconfig(struct scsi_device *dev) > > static int __init blogic_init(void) > { > - int adapter_count = 0, drvr_optindex = 0, probeindex; > + int drvr_optindex = 0, probeindex; > struct blogic_adapter *adapter; > int ret = 0; > > @@ -2368,10 +2368,8 @@ static int __init blogic_init(void) > list_del(&myadapter->host_list); > scsi_host_put(host); > ret = -ENODEV; > - } else { > + } else > scsi_scan_host(host); > - adapter_count++; > - } > } > } else { > /*