Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4f9c9632-7c2c-b397-5fc0-f2519edf5f0a@nvidia.com>
Date:   Mon, 31 Oct 2022 22:12:46 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH V1 1/2] dt-bindings: PCI: tegra234: Add ECAM support
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>
Cc:     krzysztof.kozlowski+dt@linaro.org, thierry.reding@gmail.com,
        jonathanh@nvidia.com, mperttunen@nvidia.com,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, kthota@nvidia.com,
        mmaddireddy@nvidia.com, sagar.tv@gmail.com
References: <20221027051214.22003-1-vidyas@nvidia.com>
 <20221027051214.22003-2-vidyas@nvidia.com>
 <20221031163316.GA2968837-robh@kernel.org>
From:   Vidya Sagar <vidyas@nvidia.com>
In-Reply-To: <20221031163316.GA2968837-robh@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFFPeWVJWTV5RmhIUWxENkYwOHNRVzJ1T0hSR1BDdUtwQ3dtMjdzTXAvT21x?=
 =?utf-8?B?Ui81RVNzTVdDYmgyOUc1OG02cVFLRktsb2RTZHNQVFE2a1IyNm1DYXZYVlc0?=
 =?utf-8?B?NDB0NzNQTldGeTZqM1lrTjRRK0xLa1JPd3RaQS8zdVFHYmM3NFBVU3EvYk52?=
 =?utf-8?B?dU5kR1ljbmJ6SUR1bU93aWdnV3hUN3d6bDZqMDJDQm9qazhDV3VlYk40UVNT?=
 =?utf-8?B?QlA3NnlZa3dNZDFWMUhwbGlGbkdaWThOU3FUb2lEK0FTckloaW16RUJaMVk2?=
 =?utf-8?B?bVAxaVROaW9QMjNSN3o2RDMwTjBvZTFoVmdEUXJ0WWVPc1pFaGgyWU9iNzNW?=
 =?utf-8?B?Z3dlQUtlNjBtT21XRDhkTnRPbTJxTkVrb01XVTFsUEplS01teHNxTVRFWWh5?=
 =?utf-8?B?MmNGSUk5bE5oNWpKYU04aW5pMGkxSm1yNGZWRkxzeDRpQnFqS09zakJrZTRR?=
 =?utf-8?B?OENxK3diYVNNU0dzRHBuNXhnckpaTi93VUlpZUFFTzl0SVFZT2plcXJ5TG9x?=
 =?utf-8?B?anQ1RzJJQ0I5Q1dtaTllaUQwSnM0d05iNE5Ic2NFeitaUWN0VjR0QVo0bUtV?=
 =?utf-8?B?bUcvK2RHazUyR2NLMUVYQ2JvOFlVaWZYanQ4TWp2bkpZbmQ1ZW40UVh3aGVS?=
 =?utf-8?B?Umd5N0VjOThwWVR5bVhwQWxvS05qenFIZ2t0RjVWbGlyeERVKzRSWXFLdUpZ?=
 =?utf-8?B?VzNneFdncCtvZ0E1UFZRcG5zRnJsSDNWYUZRUEEzVkNKa3VjRzJscEppSVpN?=
 =?utf-8?B?OUVoRUZ0NmNYd1haSXEvUUl4MVN0RWtQMkZud250REJqaFA1dGVMMnlwb0JV?=
 =?utf-8?B?K0pjRUtOcXRnUm5yNy9CSTZydTg4dkVVTnlLM3Uyb2xGTEM3RHVoaGs3WExw?=
 =?utf-8?B?ZXZvNWx0U1JoQlgvVHZmTThHSS93bFVtekVFbEcyWnBoRDlLRHBndUJ5L2xJ?=
 =?utf-8?B?aEpkZ01yMzhIN1MyYlN2b3p6MEIyMTA0NGhnNzVLVmxEQ01Ta0d5ZDd0YjZV?=
 =?utf-8?B?eDQ1dmtDZXVTdkpBQzZtVTJXZXRQQ29MWFRnTDhpMkVQWGNqS0FxRlZTTHZM?=
 =?utf-8?B?M0tRbDQzUVEzcVlOY05MV2xWais4WUFudXozeENlRlFnakFtNDhGRzhQNll1?=
 =?utf-8?B?MGZRZ0tLNVFLSTRtaUdwckhkR3NRQTIwZlBvc1ZaQXJSTUVpa3RvMlE0S1RN?=
 =?utf-8?B?a1lYTzNvdndFa2VURWkzbHB1UkZvZ1dnY2xmNUZtdWQzQXdDSjJLdFJlYWVK?=
 =?utf-8?B?WTBXYnZNcmhnSDh4VkhIVWRpU3UvMEkydVgyS3J6RXVneCswSmdWRG9QNW96?=
 =?utf-8?B?ZEkwZS9jQm8yQXIvN3Q5TlFldnFIdGcwMVVwRG1PR1dmYlBsRVVQLzJGMHN0?=
 =?utf-8?B?ZFRyR2cwRDB4TkVCNEJPZWE0cTM1OHZjRm41ampqcGR2ZWtzbjVuU3FEdFB2?=
 =?utf-8?B?SGtuTTZrYjhRZ0RON01DcFJEMmRFeEdDMHNrUkZUYzVwRGZUOHhnRHFEOE5L?=
 =?utf-8?B?RjJuKzkxT3JzZmtlMzRzbkRDeldqQnR6U1BUVE5FWTB1MmJwa01wc2VBblJU?=
 =?utf-8?B?UUY2V2pRZUVlb09KYXBNUlVNNFpnYStiWENFSlAxcml4U3p2RWYrdnJpTjd5?=
 =?utf-8?B?R1ZCSlVuNTNOUmEzWXpHVmZheXU4alNtSE5IZC9pQ0ZqYzlDZnVyamJrcnFY?=
 =?utf-8?B?NnNRaDA5WS96VVlIR09VSFREcWRmc0xHWmFtcU81MnZMK1YwbCtmYXVxQnhs?=
 =?utf-8?B?N2doNU96NzVOMmxwM0VxQXdxQktLRS9BUTFJSTNPc1BCbkxCbkNyZm93QlE0?=
 =?utf-8?B?QWxacWZPUGZhV0Z0NnQxeDR5UE1RKzA0aU52R3dhMlNVb3lncTRyWHM5ckk0?=
 =?utf-8?B?RFk0TktZMGo4akVSUk1NL1YwdzA1QWhJTkhIZEN2MERSY2dvQUxzQTNKQ2R6?=
 =?utf-8?B?MlQrcnpqOXNIRktLaUpnNzJQbXMzK29nMk1JaCt1RUxJd21BbytBR0NHYkN3?=
 =?utf-8?B?U25IV0wwZXBuY3lmUkJ0T2dveDdYOGlxU3F2MEI3a3FPbWkyM0FlR2pPbitq?=
 =?utf-8?B?ZWFuNm1FY25YbGJJZXkvZXBqcVI2a3ovMXJJZm1Ecml2cmNxazNxczZvQ0pN?=
 =?utf-8?Q?SeIG4umPjWbrTszDrRXfpqHdh?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 175ecd1a-51b3-4dc7-9890-08dabb5ef7b5
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB2900.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2022 16:42:58.4946
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vkp6027d9wEsEMSuKton0owO5Z3WucQr+8DrHPLI6MeEG67Eua/xUyiSrZlv7ouX7CiwtcFTwX4jGJbfoGOwhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5072
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/31/2022 10:03 PM, Rob Herring wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Thu, Oct 27, 2022 at 10:42:13AM +0530, Vidya Sagar wrote:
>> Add support for ECAM aperture for Tegra234.
>>
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> ---
>>   .../devicetree/bindings/pci/nvidia,tegra194-pcie.yaml  | 10 ++++++++--
>>   .../devicetree/bindings/pci/snps,dw-pcie.yaml          |  2 +-
>>   2 files changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>> index 75da3e8eecb9..15cc2d2055bb 100644
>> --- a/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/nvidia,tegra194-pcie.yaml
>> @@ -27,6 +27,7 @@ properties:
>>         - nvidia,tegra234-pcie
>>
>>     reg:
>> +    minItems: 4
>>       items:
>>         - description: controller's application logic registers
>>         - description: configuration registers
>> @@ -35,13 +36,17 @@ properties:
>>             available for software access.
>>         - description: aperture where the Root Port's own configuration
>>             registers are available.
>> +      - description: aperture to access the configuration space through ECAM.
>> +          This is applicable only for Tegra234.
> 
> Is it really only Tegra234 or that's all you've tested or care
> about? For the former, I agree with Krzysztof.
It is applicable only for Tegra234 and not applicable for Tegra194 (I 
meant the support for ECAM itself is not there in Tegra194).
I'll address the review comments in the next version.

- Vidya Sagar

> 
> Rob
>