Received: by 2002:a05:622a:1442:b0:3a5:28ea:c4b9 with SMTP id v2csp774555qtx; Mon, 31 Oct 2022 13:35:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7LVnpVN/FhZ6HPV/+zdNbAPB9AHbeKFprVIrzwxlpBKS4xasL37/0KEwLvz+7FChJjn6yM X-Received: by 2002:a17:907:7214:b0:791:a4cf:5bb7 with SMTP id dr20-20020a170907721400b00791a4cf5bb7mr14233436ejc.576.1667248553848; Mon, 31 Oct 2022 13:35:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667248553; cv=none; d=google.com; s=arc-20160816; b=E+h+5QvJ1AMFAoOnJv3LPSG5U7KpTibRnGGjrkE9A9P5hCrdXe7nLikFdcytQbTqzl vSY5u2agPB0yOvDhPQ/3T8GTZRYOYemjE4k2r+05Fl9kZarHHSrgKC2Ocg8qud2yAYop 91O7PwWfYx93ztYLuy7WEqew3TJhyEP92MaXIG7ru+TYboNWsrmTNEkrG+9NQ8DsbTNm BjT0t6ah99EMdSsHsy+6viWzepHlnOgWag4CveLAE++bPLpv2HqGUsGB/sLk99dM114p XW7CbkboWPfXVSblyagTEjrY+VEr5O2WY5hjEg4GOrLYlOKx3cCeU+Hcgmi2mVXq6WLt Sizg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=nwsZFSIfvDZpHHuxEMGjyPvVY5KuSJvTYvlj6dRm7S4=; b=EpFmYwoW7VjHB5JqGEAVXCHnhh+NRIIVoqTP94cRAyVG/OKieO7IsDLYkVGgBp/R9g pLJx8nRK/xS0EIEp1AtLUY3AizQQpWLqpnh2D3REEjcqgBqs855JkxrX+9YLUxLW50j4 MXU8tGxEAw0093Y3tVX8LDKxSX7TTREvWsYtp/x3F58pZAlGYRSME+wIu/i1wWhQBqOc HScFSSdNnAuyctSfzelSHP4A3vJQZIsPPz4d5mh3L8NayGSLwNrN4iGkexMmkacF51tW /G7jUjbcYvNTZzCj9b727BL3mxFaUZOWaTNMCxK41FwT5Otjt+9r8ff1d5HFqjkWlc/I IPJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G+7jzDuJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n25-20020a056402515900b00460c36e09b6si7763551edd.431.2022.10.31.13.35.29; Mon, 31 Oct 2022 13:35:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G+7jzDuJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230186AbiJaUU4 (ORCPT + 98 others); Mon, 31 Oct 2022 16:20:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbiJaUUv (ORCPT ); Mon, 31 Oct 2022 16:20:51 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E674D10FF8 for ; Mon, 31 Oct 2022 13:20:50 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id ud5so32321824ejc.4 for ; Mon, 31 Oct 2022 13:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nwsZFSIfvDZpHHuxEMGjyPvVY5KuSJvTYvlj6dRm7S4=; b=G+7jzDuJE+lROFNuCb0pBK3RV3kM2LDLzDaSS9pSPmGE6aNaSkmYDkxWS3i31Smghh VFYCHnMmodCH7Uz4/yE34CRuCmIaiACiuqcCKhpUSOpGDVnasYzdKNI9acrPN82cQhzm Ce+NDxVasqi0uD0ILXkfZd72lvEQTNi+yHvxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nwsZFSIfvDZpHHuxEMGjyPvVY5KuSJvTYvlj6dRm7S4=; b=vzKZUWZfsThbmNA6X6VJUIzGRB3aGTvgbhH876HPr3ClghJmsrFmY78LaJUpfmtqRI ygciy5ujN7UynYvGYKPdV7YTBHEWvlMPk6vQp8rPwQusBl/HgYNr01SudpExOG3OBPGe GWjgXD85gwxOo2Hf2F7BO6p44XKc/pBWMGEoIH+8JQOrRGykKFX8DkZCQ59uJ1bNFKVs yrsAyKCY5l8oXHFtAgnYLl5lxyRDs/rGyP3GBnHO0XM9T0AGRjT2AwCX0f7YMts+epW8 zs4hdaHxUSCKUN6Fuh9cscrtAEWCeRYfdEmaWZLSh6U+QBi/h4gDhSMqI7zYeCwgE+AE +EnA== X-Gm-Message-State: ACrzQf2YOlRf7LXPEwKM89txphb9vG4OaLURjFGDaYgcGLV/jM7rFyMw v0q65HRcQld8MdF0nNYOAru1cAAUPne1nQ== X-Received: by 2002:a17:907:2c6b:b0:7ad:c587:bc5b with SMTP id ib11-20020a1709072c6b00b007adc587bc5bmr9412646ejc.425.1667247649299; Mon, 31 Oct 2022 13:20:49 -0700 (PDT) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com. [209.85.208.52]) by smtp.gmail.com with ESMTPSA id q7-20020a17090676c700b007ad94422cf6sm3347746ejn.198.2022.10.31.13.20.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 13:20:48 -0700 (PDT) Received: by mail-ed1-f52.google.com with SMTP id l11so17890987edb.4 for ; Mon, 31 Oct 2022 13:20:47 -0700 (PDT) X-Received: by 2002:aa7:d9d1:0:b0:461:9556:23e6 with SMTP id v17-20020aa7d9d1000000b00461955623e6mr16135034eds.25.1667247646748; Mon, 31 Oct 2022 13:20:46 -0700 (PDT) MIME-Version: 1.0 References: <20221027151908.v1.1.I295e65357f06f162b46ea6fc6c03be37e3978bdc@changeid> <4b7304c0-8dd5-9add-7c84-4e9f0aa9396b@redhat.com> <2124934d-a8f1-59fa-1958-28472d06d2d6@redhat.com> In-Reply-To: <2124934d-a8f1-59fa-1958-28472d06d2d6@redhat.com> From: Sven van Ashbrook Date: Mon, 31 Oct 2022 16:20:35 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN() To: Hans de Goede Cc: "Limonciello, Mario" , Rajneesh Bhardwaj , LKML , "S-k, Shyam-sundar" , "rrangel@chromium.org" , "platform-driver-x86@vger.kernel.org" , Rajneesh Bhardwaj , Rafael J Wysocki , Rajat Jain , David E Box , Mark Gross Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 31, 2022 at 4:15 PM Hans de Goede wrote: > > Something like this does indeed sound like a nice solution for this. Agreed, much nicer than letting the monitoring infrastructure hunt for certain dmesg strings, for sure. Thank you David for the suggestion, and Mario for the opening ideas.