Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Oct 2022 14:23:41 -0500
From:   Rob Herring <robh@kernel.org>
To:     Paul Cercueil <paul@crapouillou.net>
Cc:     Alessandro Zummo <a.zummo@towertech.it>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
        od@opendingux.net
Subject: Re: [PATCH v2 1/4] dt-bindings: rtc: ingenic: Rework compatible
 strings and add #clock-cells
Message-ID: <20221031192341.GA3270129-robh@kernel.org>
References: <20221028225519.89210-1-paul@crapouillou.net>
 <20221028225519.89210-2-paul@crapouillou.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221028225519.89210-2-paul@crapouillou.net>
Precedence: bulk

On Fri, Oct 28, 2022 at 11:55:16PM +0100, Paul Cercueil wrote:
> The RTC in the JZ4770 is compatible with the JZ4760, but has an extra
> register that permits to configure the behaviour of the CLK32K pin. The
> same goes for the RTC in the JZ4780.
> 
> Therefore, the ingenic,jz4770-rtc and ingenic,jz4780-rtc strings do not
> fall back anymore to ingenic,jz4760-rtc. The ingenic,jz4780-rtc string
> now falls back to the ingenic,jz4770-rtc string.

This is a compatibility mess. There is no driver support in v6.1-rc for 
ingenic,jz4770-rtc, so a new DT would not work with existing kernels. It 
sounds like you need 3 compatibles for 4780.

> 
> Additionally, since the RTCs in the JZ4770 and JZ4780 support outputting
> the input oscillator's clock to the CLK32K pin, the RTC node is now also
> a clock provider on these SoCs, so a #clock-cells property is added.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> 
>  v2: - add constraint on which SoCs can have the #clock-cells property
>      - add JZ4780 example which has a #clock-cells
> 
>  .../devicetree/bindings/rtc/ingenic,rtc.yaml  | 32 +++++++++++++++++--
>  1 file changed, 30 insertions(+), 2 deletions(-)