Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Oct 2022 16:52:13 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Alistair Francis <alistair@alistair23.me>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org,
        krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org,
        robh+dt@kernel.org, shawnguo@kernel.org, rydberg@bitmath.org,
        alistair23@gmail.com, s.hauer@pengutronix.de, andreas@kemnade.info,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        =?iso-8859-1?Q?Myl=E8ne?= Josserand 
        <mylene.josserand@bootlin.com>, Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v10 1/4] Input: Add driver for Cypress Generation 5
 touchscreen
Message-ID: <Y2BfrUx9gzaNhb4I@google.com>
References: <20221026114908.191472-1-alistair@alistair23.me>
 <20221026114908.191472-2-alistair@alistair23.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221026114908.191472-2-alistair@alistair23.me>
Precedence: bulk

On Wed, Oct 26, 2022 at 09:49:05PM +1000, Alistair Francis wrote:
> This is the basic driver for the Cypress TrueTouch Gen5 touchscreen
> controllers. This driver supports only the I2C bus but it uses regmap
> so SPI support could be added later.
> The touchscreen can retrieve some defined zone that are handled as
> buttons (according to the hardware). That is why it handles
> button and multitouch events.
> 
> Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
> Signed-off-by: Myl?ne Josserand <mylene.josserand@bootlin.com>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> Tested-by: Andreas Kemnade <andreas@kemnade.info> # Kobo Clara HD
> Tested-by: Peter Geis <pgwipeout@gmail.com>

While I wish we did not have to parse what is essentially HID data
ourselves and basically repeated what i2c-hid does, I understand that
the firmware is not exactly i2c-hid compatible...

Applied, thank you.

-- 
Dmitry