Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Oct 2022 20:47:43 -0700
From:   Colin Foster <colin.foster@in-advantage.com>
To:     Rob Herring <robh@kernel.org>
Cc:     Vladimir Oltean <olteanv@gmail.com>,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        =?utf-8?B?bsOnIMOcTkFM?= <arinc.unal@arinc9.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lee Jones <lee@kernel.org>
Subject: Re: [PATCH v1 net-next 3/7] dt-bindings: net: dsa: qca8k: utilize
 shared dsa.yaml
Message-ID: <Y2CW3/V4/iiMh+Sq@COLIN-DESKTOP1.localdomain>
References: <20221025050355.3979380-1-colin.foster@in-advantage.com>
 <20221025050355.3979380-4-colin.foster@in-advantage.com>
 <20221025050355.3979380-1-colin.foster@in-advantage.com>
 <20221025050355.3979380-4-colin.foster@in-advantage.com>
 <20221025212114.GA3322299-robh@kernel.org>
 <20221025212114.GA3322299-robh@kernel.org>
 <20221027012553.zb3zjwmw3x6kw566@skbuf>
 <20221031154409.GA2861119-robh@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221031154409.GA2861119-robh@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?QEuWOprBnd+JllM+q+JdH3teRPRWQlcv2rZ9HKry6acnbL0+ZaCE+R3u/X29?=
 =?us-ascii?Q?7v+cjJyvYG8W3cK/NzmJZpVzU5BYeh+xPu+v0AE++G0tK/93xcuES+1grGVB?=
 =?us-ascii?Q?I7RgMzqrz84Yf7FV6Ds0sWiFIu7tdklvv4mCVx3rOgNMXRsqRPIj1mvHxNuD?=
 =?us-ascii?Q?tmUnjo6iKrrgs1stRbWRaNJ6ZZojSZgzOKq5GBXP6aMsbjzzfeOh3RccomIU?=
 =?us-ascii?Q?2jYBd6k/ykdrRiZfBn95A8gotohs6myeV68Qgb6+7Ok2xwP7/V01q4e2VhPA?=
 =?us-ascii?Q?B8x6fBfssttcyPGPRQpvKhfk3A0yeu+8sobNzgA+dtJFJdnJQhCJWgGXAK2x?=
 =?us-ascii?Q?BtFTwSNipDj8qtTJo4NDnCrvXve6NHAf9q6AlWiD0+hPiQzcaQ2HD/5CEWRw?=
 =?us-ascii?Q?Q4rCKkI9PJG8zARAF8ulCXgD5Os81+PTyt/qGYSA7gEbph4E3tpag30u5BDD?=
 =?us-ascii?Q?1LJRkSmjDDT8AkAkVKS2bsieMCaxk+S+TYt7DuHPq5TPvZRIEa1UfHg1OpYF?=
 =?us-ascii?Q?oV40GYiziKTCFwL5KlKPut7dXQ/dtHTys39G4MndYYH3fDjFM+U8cISKfhQx?=
 =?us-ascii?Q?s8bPH6/AllPSNml7n2oNijRA6Jga6p2ejB3SP18XbvRTBqGdgcV5sj2mmH7M?=
 =?us-ascii?Q?jnSd13a9VrRhRtu4j5W1VcCgVyrxWWBRmV7XQxuU4Z9ymq06zM0vOwgg+APQ?=
 =?us-ascii?Q?iomPEebND7TCpBpYZKbloO4+PYwN4Sco9AeBlL5xZkwKh424LcGOD86Xh0v/?=
 =?us-ascii?Q?7pOjJ499SfEYCugFWdVPD+ZYVFoYj6FQFP7IH0EzlR7MkDvxaifnlCIXUkFX?=
 =?us-ascii?Q?YADmXPD3gALdMi/3srJle1HUUo7PGsSU6qalfnrUXnl2XYqpywyPB94kQIfA?=
 =?us-ascii?Q?gS5w8AqgAE07x8GaRejfWp134O+6JjWENyxVFTXxhwwpV2CdD2DcdnSR7d+V?=
 =?us-ascii?Q?CqSP8zQ+WPfCqSdXZVdEZgqibiNbIlqw/4ZU+wCLHraT9uSz4dRb21A4lIJB?=
 =?us-ascii?Q?YAXdHYdZV0MuZLVXJjDOeRizlT9bmIkUTDBInp/kLYeTesT8IV+klnzAr3P0?=
 =?us-ascii?Q?XhrKqc2nom7OADFB4Ty5eflhBZZMnVzXITfRlNZHyywUy6B9lrFYX3kYO7Pv?=
 =?us-ascii?Q?4WDwIvrlZcfRxLsNUkGG0iLzJ7CF1kk8iHc9P/RTiuXJ9ymOJ52TBZNiWSE+?=
 =?us-ascii?Q?sDzbNS92bSq4Ro+pX5wF2LsMG5jCTJqnnRna4FpcULUz2Jlo2CuoNRSLWL4z?=
 =?us-ascii?Q?d9hQJd1DSG4l4V3g89RtM2UGfZhydz4NJ70tVxZh7F5EmvOMrM7rgiTIoVGd?=
 =?us-ascii?Q?zRI3tBc4V04S6W0i7XDDZZPYh8b8mi6VRMsYxz4mRJNZz5lh1vkU+XBTJ6Jt?=
 =?us-ascii?Q?5J9ITCrwQ/NdT9I7POl9Bc8lOp8Rxi0Hngm9/8wn+w0WBviA56S+TOPlbyp/?=
 =?us-ascii?Q?SEiGdCi2TOrFq0NHMqH+8dv703NHDFcEb4XMBU9P+UiZz02xBZ7zrwLEf0HJ?=
 =?us-ascii?Q?AVnyVatLzD10qHrWnp9xW3Gs1vJ5p45gNUaa4ZCdHy8lf47f7j9igltUsVrJ?=
 =?us-ascii?Q?1m67KtQyfK3DZkmT+bIAY2Kvusio+tCmwZWKOkZY33nL0w5c0o75pmu+YbYi?=
 =?us-ascii?Q?LQ=3D=3D?=
X-OriginatorOrg: in-advantage.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3d8d954-b698-4e12-ffd7-08dabbbbdd5d
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2351.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 03:47:57.6518
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 48e842ca-fbd8-4633-a79d-0c955a7d3aae
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3ohmtbcg5euk0WCPNO3B1Rup7sFfYti1QttIfUxdWlWCfGA++7T9Jldbq+fM2GwsuMt7o/Q7lbYMlSA6lipaE3osWFrKfpATaNhz9sm8tqQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4553
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 31, 2022 at 10:44:09AM -0500, Rob Herring wrote:
> On Thu, Oct 27, 2022 at 04:25:53AM +0300, Vladimir Oltean wrote:
> > Hi Rob,
> > 
> > On Tue, Oct 25, 2022 at 04:21:14PM -0500, Rob Herring wrote:
> > > On Mon, Oct 24, 2022 at 10:03:51PM -0700, Colin Foster wrote:
> > > > The dsa.yaml binding contains duplicated bindings for address and size
> > > > cells, as well as the reference to dsa-port.yaml. Instead of duplicating
> > > > this information, remove the reference to dsa-port.yaml and include the
> > > > full reference to dsa.yaml.
> > > 
> > > I don't think this works without further restructuring. Essentially, 
> > > 'unevaluatedProperties' on works on a single level. So every level has 
> > > to define all properties at that level either directly in 
> > > properties/patternProperties or within a $ref.
> > > 
> > > See how graph.yaml is structured and referenced for an example how this 
> > > has to work.
> > > 
> > > > @@ -104,8 +98,6 @@ patternProperties:
> > > >                SGMII on the QCA8337, it is advised to set this unless a communication
> > > >                issue is observed.
> > > >  
> > > > -        unevaluatedProperties: false
> > > > -
> > > 
> > > Dropping this means any undefined properties in port nodes won't be an 
> > > error. Once I fix all the issues related to these missing, there will be 
> > > a meta-schema checking for this (this could be one I fixed already).
> > 
> > I may be misreading, but here, "unevaluatedProperties: false" from dsa.yaml
> > (under patternProperties: "^(ethernet-)?port@[0-9]+$":) is on the same
> > level as the "unevaluatedProperties: false" that Colin is deleting.
> > 
> > In fact, I believe that it is precisely due to the "unevaluatedProperties: false"
> > from dsa.yaml that this is causing a failure now:
> > 
> > net/dsa/qca8k.example.dtb: switch@10: ports:port@6: Unevaluated properties are not allowed ('qca,sgmii-rxclk-falling-edge' was unexpected)
> > 
> > Could you please explain why is the 'qca,sgmii-rxclk-falling-edge'
> > property not evaluated from the perspective of dsa.yaml in the example?
> > It's a head scratcher to me.
> 
> A schema with unevaluatedProperties can "see" into a $ref, but the 
> ref'ed schema having unevaluatedProperties can't see back to the 
> referring schema for properties defined there.
> 
> So if a schema is referenced by other schemas which can define their own 
> additional properties, that schema cannot have 'unevaluatedProperties: 
> false'. If both schemas have 'unevaluatedProperties: false', then it's 
> just redundant. We may end up doing that just because it's not obvious 
> when we have both or not, and no unevaluatedProperties/ 
> additionalProperties at all is a bigger issue. I'm working on a 
> meta-schema to check this.

Thanks for this information. So if I'm understanding correctly:

 - All DSA chips I'm modifying should reference dsa.yaml, as they
   currently are.
 - As such, these all should have unevaluatedProperties: true, so they
   can see into dsa.yaml.
 - dsa.yaml, and any schema that gets $ref:'d, can not have
   unevaluatedProperties: false, unless the desire is to forbid any
   other properties to be added.

I'll get another patch set out this week with all these changes, and
tested against the latest dt_bindings_check.

> 
> 
> > May it have something to do with the fact that Colin's addition:
> > 
> > $ref: "dsa.yaml#"
> > 
> > is not expressed as:
> > 
> > allOf:
> >   - $ref: "dsa.yaml#"
> > 
> > ?
> 
> No. Either way behaves the same. We generally only use 'allOf' when 
> there might be more than 1 entry. That is mostly just at the top-level.
> 
> Rob