Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH RFC 10/10] mm/hugetlb: Comment at rest huge_pte_offset()
 places
From:   Nadav Amit <nadav.amit@gmail.com>
In-Reply-To: <20221030213045.335680-1-peterx@redhat.com>
Date:   Mon, 31 Oct 2022 22:39:33 -0700
Cc:     Linux-MM <linux-mm@kvack.org>,
        kernel list <linux-kernel@vger.kernel.org>,
        James Houghton <jthoughton@google.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        David Hildenbrand <david@redhat.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Miaohe Lin <linmiaohe@huawei.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3D896ED0-5600-4E55-8509-3F0E355FF692@gmail.com>
References: <20221030212929.335473-1-peterx@redhat.com>
 <20221030213045.335680-1-peterx@redhat.com>
To:     Peter Xu <peterx@redhat.com>
Precedence: bulk

On Oct 30, 2022, at 2:30 PM, Peter Xu <peterx@redhat.com> wrote:

> +		/* With vma lock held, safe without RCU */
> 		src_pte =3D huge_pte_offset(src, addr, sz);

Just another option to consider: you can create an inline function
huge_pte_offset_locked_mm(), which would do the lockdep_assert_held_*().

I personally would prefer it, since it would clarify exactly the lock =
you
care about and "make the code document itself=E2=80=9D.
=20=