Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <afa29fcc11436dd957314a4066c9141937f0470c.camel@nxp.com>
Subject: Re: [PATCH RESEND] mfd: Add Freescale i.MX8qxp Control and Status
 Registers (CSR) module driver
From:   Liu Ying <victor.liu@nxp.com>
To:     Lee Jones <lee@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com
Date:   Tue, 01 Nov 2022 13:53:49 +0800
In-Reply-To: <Y1/sUfeVy1a6EKZQ@google.com>
References: <20221017075702.4182846-1-victor.liu@nxp.com>
         <Y1/sUfeVy1a6EKZQ@google.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzJ1WmFLOWhVRlNXMXBkRXhhQ1Q3Ylk0RTVibUJHY2cxVEMvWGk1TUxXTTE3?=
 =?utf-8?B?ODBYV2owZmdCZ1JVZ0RIRG45bG9qeWxTd2ZFV0FHeTJvK0V5VGZXdWtPS1Nk?=
 =?utf-8?B?QzBYc3NTaDdna0ZpUWNsd2RLWk8wYTBmc3N3NDFtbDlTWFFwNGJ2OVFwL1RR?=
 =?utf-8?B?RjlwNVpoSWVjQlFGY0dkMDNRTGFUWkNidjQ0SWtRSmVwOFlnWU0wL1NPRXNy?=
 =?utf-8?B?VDloSkhXbVJKeW9uc3F4S1JVaFozK1RmZEpvWWdqbFRWMWVpSHc2QndGWVJy?=
 =?utf-8?B?L1hiK2t4ZnU3d3V0bWRmWUZMR2tlUHF1aTNOVFpTbFAxaHllZUJRWGlWc1Qv?=
 =?utf-8?B?NEFKTFArNE9LaEl3TEhnNmpGRkFPZnVNUzNxYTMveCtPanFrdXNpcC8vOTlI?=
 =?utf-8?B?WFMwSWRWTHJLb0lUdzl2a0ZDNVFBOVF3WjJQYkJJRm9ISW5wc0pnYVlEbUFV?=
 =?utf-8?B?U2YrbGlFa2F6QlhSUDMzUlJYVzNuUlNkZ3RrRDVhRzlZSTZaM3p0LzRFdGdj?=
 =?utf-8?B?Z1VkUFgvWjg2NHRxUTUxL29YZGo2OHVXLy9yNlZOdlIyV0U2Nkc0bGNrc0dy?=
 =?utf-8?B?U3VSWDcyL1h2RzNucHowSDFwUmttVnYvcmc5TE50SXRwVXNnT0d5MWxqWjV3?=
 =?utf-8?B?UzlsZng3TG52YnUxdmE2NUJqb21BWHp6WDBiTXpvaXdEaVhNblI0cjM5RW9P?=
 =?utf-8?B?R2wzSHBWSjViZE10UUFlOXp4UkdqZVM5U3hSR0pKcDV5eTZ1TTFjR01yT3Q4?=
 =?utf-8?B?M0Y3VGZ6L3phbE1Ma3dGUkx3ajA3blZMSUhvVmNRK3dqWjlYRzhIMVRTZmwr?=
 =?utf-8?B?UFVOT2FNbDRUdGdmMGZaVmVGdkRCUjkzNGt4ZHR0VXZYSlRxY2VCNVMvOHpa?=
 =?utf-8?B?RG9XTWR0RURsOFRJMGpDNWxleW9TazFzNnpqckxLU1pTbVlDMm9TRE84SjBr?=
 =?utf-8?B?QTRyOTRvQ3J5aUx1Lzg3TE5Ya3g5Sml6UmtjR1hkSTNWWVJ4aHU1M243eHQ0?=
 =?utf-8?B?SU54SmdjME9wS3RFQjVZdHprVWV2ZmdxeUpWTFhIY0lRbGF4UmNjNzFuY0RM?=
 =?utf-8?B?dE9GczhMbDdBQ0ZYNlJyejhPMCthc2crb3V3UG14MTJvblVDaE9zaXVMK0hE?=
 =?utf-8?B?UEN1b2xEOExEdjVLRk9YUW8zTlBxT3ZQdHd6NVpWL0ZLYitmYjlDYUliWE9s?=
 =?utf-8?B?allJNEc0S09Ja1hPTllLSGVXN0RNL2h0OWhKVUN3TEtEckVCU01VMjdPL0tz?=
 =?utf-8?B?WjBJNkhMZmllZjVzSFlEdU1tdHdHRDJrZ0pHeGpTa05XNDNKMnhiWWxjY1BL?=
 =?utf-8?B?Wmw1VzJBa2hsZzYvRTJsUkJHZ3pteTVrODFObWg1ejB3dk5YaGRSR1h3VFFr?=
 =?utf-8?B?eWVGSzE1TjcrU0w4MDhMdGFPL0JlQlJ0L1JtTFEzS2VHK0pJZlV1K2R0UnRT?=
 =?utf-8?B?SVZiU0ltcHdUM2xWaEZjeWZMQVEyMmRDS254V3FhUDJVdXpGWjFpZm1zQitT?=
 =?utf-8?B?Q0dTbUY1SURBWmJZQVljRlg5MjlkWnhUM1dTR05QRDlLUThKY1pKd0I1bXVW?=
 =?utf-8?B?eFYwRzUzODFvRUpRUENrN0RDS3Ardy92T0p3Wm9PbjZVM3NmQklSYWZvSUpl?=
 =?utf-8?B?NVVoSFIyL2xBL3l5clFzTCtHVlBoWkEwT0VqU29DdmJzMFhSaUk1NTVQNlpC?=
 =?utf-8?B?SjBzcmRDUG5mUjFKa2RXbTBtdzhpOGRwdjNVWTdES29lRE1Ub0tGOERMUGc3?=
 =?utf-8?B?Z3d1elNPOGp0V1R6WEttNDJ5RGVEZksvdEZkOFI1UU1QK3NvQVhOZ0VZR1NE?=
 =?utf-8?B?OWZxQzBtUEszZFpITWNYMTZmeExieExKNjZYUmdaNDZ6ZlFSVVF4aTlVWnNj?=
 =?utf-8?B?MmlLTWRMUGQzTnQ1MXlFaTJBRlN4UTl5QWs5a1RXTi9lTkNnL1BtdlFCangw?=
 =?utf-8?B?MStmNk5FbWtZaC8vZ25MOCthcmtpTTJnL1NxaXdza3FGZHFWTE1GMzhyUnVx?=
 =?utf-8?B?UStXMk5DcXhBS2R0cVY3TjRkYnA3ZjJJL3NDdnBOMEZEWFlPWE9jaFpVazYw?=
 =?utf-8?B?enhMTko4Smc5bkhsU3ZVdTNybi9KT3dVOWQwYXBERlErajhVV1RTaXk3MDhD?=
 =?utf-8?Q?DJhuEdjIYOHk4DB7767os6J6S?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a8719d7c-8c07-4ff6-cfbd-08dabbcd9164
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 05:54:41.0694
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EbDen9rJu3xXFaRbheeIfeD5g7/+aKNgZPZfPuU9CgTePDTRB9koR2kOO2rEQPVLZ9wL5VOzNmG1EvRAtnNo4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8665
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,SPF_HELO_PASS,
        T_SPF_PERMERROR autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lee,

On Mon, 2022-10-31 at 15:40 +0000, Lee Jones wrote:
> On Mon, 17 Oct 2022, Liu Ying wrote:
> 
> > Freescale i.MX8qxp Control and Status Registers (CSR) module is a system
> > controller. It represents a set of miscellaneous registers of a specific
> > subsystem. It may provide control and/or status report interfaces to a
> > mix of standalone hardware devices within that subsystem.
> > 
> > The CSR module in i.MX8qm/qxp SoCs is a child node of a simple power-managed
> > bus(i.MX8qxp pixel link MSI bus). To propagate power management operations
> > of the CSR module's child devices to that simple power-managed bus, add a
> > dedicated driver for the CSR module. Also, the driver would populate the CSR
> > module's child devices.
> > 
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > The Freescale i.MX8qxp CSR DT bindings is at
> > Documentation/devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml.
> > 
> > Resend the patch based on v6.1-rc1.
> > 
> >  drivers/mfd/Kconfig           | 10 +++++++
> >  drivers/mfd/Makefile          |  1 +
> >  drivers/mfd/fsl-imx8qxp-csr.c | 53 +++++++++++++++++++++++++++++++++++
> >  3 files changed, 64 insertions(+)
> >  create mode 100644 drivers/mfd/fsl-imx8qxp-csr.c

[...]

> > diff --git a/drivers/mfd/fsl-imx8qxp-csr.c b/drivers/mfd/fsl-imx8qxp-csr.c
> > new file mode 100644
> > index 000000000000..3915d3d6ca65
> > --- /dev/null
> > +++ b/drivers/mfd/fsl-imx8qxp-csr.c
> > @@ -0,0 +1,53 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +
> > +/*
> > + * Copyright 2022 NXP
> > + */
> > +
> > +#include <linux/module.h>
> > +#include <linux/of_platform.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/pm_runtime.h>
> > +
> > +static int imx8qxp_csr_probe(struct platform_device *pdev)
> > +{
> > +	int ret;
> > +
> > +	pm_runtime_enable(&pdev->dev);
> > +
> > +	ret = devm_of_platform_populate(&pdev->dev);
> 
> The use of this API does not constitute a MFD.
> 
> Please use "simple-mfd" instead.

simple-mfd devices have "ONLY_BUS" set in simple-pm-bus.c, so the
simple-pm-bus driver would not populate child devices of simple-mfd
devices.  Also, the simple-pm-bus driver would not enable runtime power
management for simple-mfd devices due to "ONLY_BUS", which means it
would not propagate power management operations from child devices of
simple-mfd devices to parent devices of simple-mfd devices.  That's why
a dedicated fsl-imx8qxp-csr driver is needed.   

Regards,
Liu Ying

[...]