Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c225e969-a88d-f3b4-de44-ef71f44dd463@intel.com>
Date:   Tue, 1 Nov 2022 00:28:41 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 07/14] x86/microcode/intel: Expose
 microcode_sanity_check()
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221021203413.1220137-8-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221021203413.1220137-8-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTJadHdiNG5UcGdROG5XaUhjTEZtNytWaFZiREhlWGI4eUpmekxZcmxSbERh?=
 =?utf-8?B?K2o4MjNtMENHZmFmQmcySHMzQW5OeUluYUxSMitLNVBxc1NoTXlSSEdjRVMx?=
 =?utf-8?B?bUh2c2ZOQldnZzcwTEdzNEJOU3JYZVVLTTVsZWROY25rY3Bxem50U0lCbnp1?=
 =?utf-8?B?UXNjMG1aMkRxMm9iWjVzYmNSdHFOcmw0Y00zdGw5L3JKdm9xY0NBcVFsVWhO?=
 =?utf-8?B?ek9CSmN1SjBmUzJTdGswck96b1JkdjIranVFUlFxdUZlaXhodURoYkFNWllO?=
 =?utf-8?B?Tllkb01XVDUyTllxOEYwUS9Rb3VZOUJNano0cW1idHdjTUZCOURKMGorZjA2?=
 =?utf-8?B?b1ZGTWZMY0RPaTBiZUhFOGNma0NOc2M5QUhtZnlIeVhSamhwVjRTb0tORDlZ?=
 =?utf-8?B?VXNoK0ZNaXRSSXVQNGRuVElMYXIwY2QxSHpKQ21uSWVYQStiVDVKL2M3anNs?=
 =?utf-8?B?U2pCU0lacjg4VHlHL01lTWtWTmNFRUVWWFRxYUZwcGprWVg2UGcxcWF3ZzQ1?=
 =?utf-8?B?U1NHYUdoekFJV1psajJrTDE5djUxWVBPTkw5cmxXaW1rK3JNbElISlFCWjhs?=
 =?utf-8?B?UW1Oa2kyWG15R0JNRnliQ2hmdS9vVk1VTnVVckxOcFNQZnEyVTBFRmw3V3FW?=
 =?utf-8?B?R1lzSm5UTE5hWlRLeFJVUHBPSmdiY0Z5MlpBZWtTNDdJbFIrcy9VVEovaXJo?=
 =?utf-8?B?czMxcWlsSkZpQlIvbW5KN0h6WWU2YmRnZWgrMTlvWDVOaXZVckhXOGZ2aHhm?=
 =?utf-8?B?ZCtGNE9Cb1JUMGtKMjdPK2JKYitHTnI5SEUva3RTeFl2eUJYN2pvbWJwUXRS?=
 =?utf-8?B?eEFMSUh0TENkbSs1cWFQdFpIRGE0cGVNVDZPVzh2cjlUVHNoejBteHdQclZh?=
 =?utf-8?B?RzZ2U0RldXJrdGZ3OHN6TysvcHZCcW1MdEVSRWkwVkEvbnMyS2Yrd0lETTNj?=
 =?utf-8?B?ZERpa3BSMkFuSDBVWGtmVm8wZjFnWURoeVpJejdJcWhSZ3d5WExkUjNyL0Mv?=
 =?utf-8?B?Y1pzQ3J6OWthanZQblBQNGtmVCt0Sk1ucjBsZ2xqU2dvd3gyRHBuc21jV2xH?=
 =?utf-8?B?UHJSUjR5V0l4QitLQkgyVXViOHQyUUJxRUZkOVB1d0ZUeE5CKzVoUDVJb2VB?=
 =?utf-8?B?Y01iQkJqU1J0Vk9PaUY3TndvOCtNa0JTQlluZmJpOXpjVnNnS2w1SHVOdHE5?=
 =?utf-8?B?ZndXckVpaUUrYm5jM1l4UGpoNU5nemc0WjIrR2dWNTRtaFhHL2ZmbnY0bXdU?=
 =?utf-8?B?WHJHN2JxeWRTaHJYSDdPYXY5T0o3SkxkTXlwUTlRMVpUV1NkT1FTKzkrRUQv?=
 =?utf-8?B?WjVWVFduSkV2SmhISTdJbjFaTUtXQ3dUempyZnVzWk1CUlhaQ3dqMWh2ZHZm?=
 =?utf-8?B?Ni9UUVNDaWFzK3VYL1ZmTm1PME1oMG16aE9PMnp4d3BNbmhqelRMcE1aKy84?=
 =?utf-8?B?b21Ca2o2QnJmZjRxb2N2dVFUaFRCOWtIQVdiL0pURjY0SzA4NFlxd1psWHZB?=
 =?utf-8?B?M1JTUERIRUVRY0lFeFhKZlB2dVFuUHJzWW15Z1hwbkRQbk5SU3NFVTlzTTA5?=
 =?utf-8?B?UEEvM3lHb1I2UjJsK1JCYjN4RDkzK0I4ajdIRko2bkxzc0hNYmJXREJwY0Np?=
 =?utf-8?B?akZUK2lZS2JCSEI3a2NmbzNqSmZXcXVyL1hQZWYyTkR4YnZ3dzJqOUZNanl5?=
 =?utf-8?B?Y0lxVHlrWkdkdWRzVHBwYURkN2lmSlhrNmF1UG85Y2dRbVVFU1RJL2RrWEtO?=
 =?utf-8?B?ejB0MUp4UEZQR1NHeWFYZGU3VHZBN2lQRy91U2lCT0dlMzZYRGRoSnBZVS9q?=
 =?utf-8?B?UlA5OHkyYTJLR2ZWdXZnZ3E1YTRqOGZ1OUJ4QzZ5VHNQUGN5TFJvVnZlUWRr?=
 =?utf-8?B?Y0hhQ0hRMDEzQXB4STFzM2pZMzRDQWcyUGZKNlcwR2ZJS2ZTajdZMHhqT3VJ?=
 =?utf-8?B?aVlIQjV5WmpFM3BMdXZUR01xcFZoTEh0aFBxYlppSHh4ZU9sSEtjcmxwWHpI?=
 =?utf-8?B?MU5HYzA1Mys0SXBuWlpzQVBGRHJkM0N6cDBFalNIeStUNTJVakluSUs3Q1B6?=
 =?utf-8?B?SjdxcUVkV3pRSDFQeTBOaFRnMHVRK0pYVS9nd0w0VzJjMXllU0hlN0I2MEVh?=
 =?utf-8?B?eTV0ZVJtb1A3UE1oRVlmQVdGb1pjY3NLTXhwVWtOZkp4S0lRU1NYeG4ySkk5?=
 =?utf-8?B?a2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d910b3a7-ef21-4dc9-c538-08dabbdab4b9
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 07:28:43.6934
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 10PHVCBagF7QGBa3UdqRwB5tm/ao+7RwRQXFcnr7crejZeotLDOEnAI+76gB3hozf9SXqMWL9c3H6y5bDyTf2Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7386
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/2022 1:34 PM, Jithu Joseph wrote:

> Refactor header version as a parameter and expose this function.

Isn't the header version part of the microcode data itself?

Microcode Format
    +----------------------+  Base
    |Header Version        |
    +----------------------+
    |Update revision       |
    +----------------------+

If so, why the need to pass it as a parameter to sanity_check()?

> 
> No functional change intended.

Maybe skip this statement. Apart from adding a parameter to an newly 
exported function, there is a change in an error print as well.

> diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
> index 5473b094baee..bc3f33a25d7a 100644
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -37,6 +37,8 @@
>   #include <asm/setup.h>
>   #include <asm/msr.h>
>   
> +#define MICROCODE_HEADER_VER 1
> +

Should this define be in a central location, like microcode_intel.h?

You would soon be adding a define for IFS_HEADER_VER. Having them 
defined together would make it easier to follow.

Sohil