Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9429d525-5e06-95a2-3340-f6e2b6009f76@zhaoxin.com>
Date:   Tue, 1 Nov 2022 15:25:17 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH 0/5] Parse the PCIE AER structure and set to relevant
 registers
To:     Bjorn Helgaas <helgaas@kernel.org>
CC:     Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>, <rafael@kernel.org>,
        <lenb@kernel.org>, <james.morse@arm.com>, <tony.luck@intel.com>,
        <bp@alien8.de>, <robert.moore@intel.com>, <ying.huang@intel.com>,
        <rdunlap@infradead.org>, <bhelgaas@google.com>,
        <linux-acpi@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <devel@acpica.org>,
        <CobeChen@zhaoxin.com>, <TonyWWang@zhaoxin.com>,
        <ErosZhang@zhaoxin.com>
References: <20221028151512.GA889708@bhelgaas>
From:   LeoLiuoc <LeoLiu-oc@zhaoxin.com>
In-Reply-To: <20221028151512.GA889708@bhelgaas>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


在 2022/10/28 23:15, Bjorn Helgaas 写道:
> On Fri, Oct 28, 2022 at 07:19:25PM +0800, LeoLiuoc wrote:
>> 在 2022/10/27 12:17, Sathyanarayanan Kuppuswamy 写道:
>>> On 10/26/22 8:14 PM, LeoLiu-oc wrote:
> 
>>> Can you add spec reference?
>>>
>> Please refer to Section 18.3.2 ACPI Error Source of acpi spec v6.3. Links to
>> the online versions of ACPI Spec 6.3 is
>> https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/18_ACPI_Platform_Error_Interfaces/error-source-discovery.html#acpi-error-source.
>>
>> Section 18.3.2.4 describes PCI Express Root Port AER Structure, section
>> 18.3.2.5 describes PCI Express Device AER Structure, section 18.3.2.6
>> describes PCI Express/PCI-X Bridge AER Structure.
> 
> Thanks.  It's OK to have the spec references in the email thread, but
> the real point is that they should be in the commit log and, when it
> makes sense, in code comments.
> 
> Cite the most recent spec version when you can.  In this case, I think
> it is ACPI r6.5.
> 
> Personally I don't really care for URL references because they tend to
> get stale over time as websites are reorganized and domains change.
> Something like "ACPI r6.5, sec 18.3.2.4" is unambiguous and will
> remain usable forever.
> 
> Bjorn

Got it. Thanks for your advice. This will be modified in the next version.

Thanks
leoliu-oc