Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221031190159.1341027-1-lis8215@gmail.com> <20221031190159.1341027-2-lis8215@gmail.com>
 <166725358721.3638147.11464755727689545438.robh@kernel.org> <20221101010834.GA4034975-robh@kernel.org>
In-Reply-To: <20221101010834.GA4034975-robh@kernel.org>
From:   Siarhei Volkau <lis8215@gmail.com>
Date:   Tue, 1 Nov 2022 11:07:48 +0300
Message-ID: <CAKNVLfagXrTmwAPX3019SgMSOJ+BMQ1KfQV2LjOSrUA6+ZiFSA@mail.gmail.com>
Subject: Re: [RFC PATCH 1/2] dt-bindings: adc-joystick: add valid-range
To:     Rob Herring <robh@kernel.org>
Cc:     linux-input@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-kernel@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, Paul Cercueil <paul@crapouillou.net>,
        Artur Rojek <contact@artur-rojek.eu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

=D0=B2=D1=82, 1 =D0=BD=D0=BE=D1=8F=D0=B1. 2022 =D0=B3. =D0=B2 04:08, Rob He=
rring <robh@kernel.org>:
>
> On Mon, Oct 31, 2022 at 05:05:54PM -0500, Rob Herring wrote:
> >
> > On Mon, 31 Oct 2022 22:01:58 +0300, Siarhei Volkau wrote:
> > > The valid-range property aims to cover detachable/lock-able
> > > joysticks where measured value goes outside valid-range.
> > >
> > > Signed-off-by: Siarhei Volkau <lis8215@gmail.com>
> > > ---
> > >  .../bindings/input/adc-joystick.yaml          | 62 +++++++++++++++++=
++
> > >  1 file changed, 62 insertions(+)
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_chec=
k'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/input/adc-joystick.example.dts:82.28-=
104.11: ERROR (duplicate_label): /example-1/joystick: Duplicate label 'joys=
tick' on /example-1/joystick and /example-0/adc-joystick
> > ERROR: Input tree has errors, aborting (use -f to force output)
> > make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindin=
gs/input/adc-joystick.example.dtb] Error 2
> > make[1]: *** Waiting for unfinished jobs....
> > make: *** [Makefile:1492: dt_binding_check] Error 2
>
> The examples aren't completely independent, so you can't use the same
> labels.

Good explanation, thank you.