Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Eric Farman <farman@linux.ibm.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>
CC:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        David Airlie <airlied@gmail.com>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        Halil Pasic <pasic@linux.ibm.com>,
        "Christian Borntraeger" <borntraeger@linux.ibm.com>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        Jason Herne <jjherne@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Eric Auger <eric.auger@redhat.com>,
        "Harald Freudenberger" <freude@linux.ibm.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        Tony Krowiak <akrowiak@linux.ibm.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        "Peter Oberparleiter" <oberpar@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Abhishek Sahu <abhsahu@nvidia.com>
Subject: RE: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_
Thread-Topic: [PATCH v1 6/7] vfio/ccw: replace vfio_init_device with _alloc_
Thread-Index: AQHY49cNyAm5A5cMYk6TS5lyulMLNq4p25sg
Date:   Tue, 1 Nov 2022 09:10:47 +0000
Message-ID: <BN9PR11MB52761247732AC600BB390C578C369@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20221019162135.798901-1-farman@linux.ibm.com>
 <20221019162135.798901-7-farman@linux.ibm.com>
In-Reply-To: <20221019162135.798901-7-farman@linux.ibm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uZDvxQphpx0TnbeZA5DKGYRZlZwrA0MoNNsKJfKJKAxyCM+Vh0HxIrrgiJCV?=
 =?us-ascii?Q?fKHncKuNObyivEukAtBL1DveMY9LYoM/yuWMFSnh5dH4/0coFL3saX5zI0X3?=
 =?us-ascii?Q?aouYCK4BZZe4s9mvhlQbClxnHRFdLY9qHx7k8zCPwcRlW2qEJmi03+Ng9sOj?=
 =?us-ascii?Q?Jm+0/Y6nwR9T3yFHfGbiDe2B9DlQbBRRDs4/aRo+Wz69n2/VNEdjUH3yhIV1?=
 =?us-ascii?Q?f/kHeWE+tNwdEaeR0e64LLqqVQUuywjO4KJ2KFYxWNjliy17rpr34xlCsdYc?=
 =?us-ascii?Q?21j7x6iHLs/gArEGkzaZiecXzRU93apE2SKq/0vtMtQMt2SUSuspjvB/4Jev?=
 =?us-ascii?Q?b/Ls+IB5IPl0MgqusuCGRi7pwSr/hGuSPG93C4M20P3PATeDoRZ2geisYpE+?=
 =?us-ascii?Q?B4cTIjEDTY3TVVdkKlb+XSDb3AP4LMZ2L+b5nMZKO7GcxqG+E4bj8xHl9CXZ?=
 =?us-ascii?Q?sJh2NKUReOz09RA4odal3Py3dFn/68TqnUT00kKH2xE8/j18NG0T4kaHUXb9?=
 =?us-ascii?Q?gEwc/APQkhqJRfq+nHLXeePDWL40MFhxp9NwWUUtvCoSNyC6OiPkcoENja2n?=
 =?us-ascii?Q?cuE3BJ93Tv1dIJyq3htkTdo0b/6IianjB5rIdOAn75G3LgyR49heu99pqL1k?=
 =?us-ascii?Q?5jiAcv4C+VXOS4QbZCYrJijriorb/qIaIulrdmpDz+R9JZzPbxcAygD5TqgE?=
 =?us-ascii?Q?q70KBqmWCyAPwqFup3ROQJaCLTid3mVwHkOYRFwHpmw5ikYNcGzu0zJqggc6?=
 =?us-ascii?Q?eGgTamETT7xl50zuVjW5nmK/JU8lVGwQ4BSiQ502JPOFpWFyWmNbT6moLeKd?=
 =?us-ascii?Q?3mUpVHhw5onturahY3Mj1m66DIPfgj6HzKTlbHT1sGhIjh2MzIdQqYugfeV9?=
 =?us-ascii?Q?UFvHKKMp20HTRnmDEA0Sd8eCmQzb3IWdTsNEHBjQu4NmYhvNivQR+pwkcF7H?=
 =?us-ascii?Q?QUa1ccaTOxoEKgU7SD4mipn9/J+FzTEswprMJXiyEqjn+P8PeYSGNVQ37Pye?=
 =?us-ascii?Q?yDqRuIwyth7s9R61440PLJzJuyVrRTGzm68nnMdf/MdlA1xZBJ+ZVIEwzdgF?=
 =?us-ascii?Q?VDxBv8eevyyChBBotsK678/XkGdrR0s7hndjB6HhLL947wzoKxFwG5Bo70qs?=
 =?us-ascii?Q?h5RkUKV1jXuinLRBsvs2oZwuLPnNXAzBrCQf8tgBEWM11ApVcwCp4N4nNos2?=
 =?us-ascii?Q?ro4+auHgMK237XG7UiS71vTZVyx5VFVhWkrNQt01OWndNJu5zSL/FNv+0nn4?=
 =?us-ascii?Q?IWfZN1TgIIRrAILRob4+xNXPJcNktskbUfqBrb5cVSqbGYXU3ouUJjl0SCpe?=
 =?us-ascii?Q?Q3w4UZXhfikXHW6XTLJOSeP2E5xpbc7t2Zmu+jlXB2hfYOpmuICVJNRfgzzm?=
 =?us-ascii?Q?/3qOfuhuVDn+AA1SB+O2AjY1SyJ/oNfRBpx/kj19xxI5k+oc1B4lCIq5bc48?=
 =?us-ascii?Q?fzVA20g5ZHtZSGuuo7btZM2w3fWJ1hlaYpfms2dd+Ftw5bcMkbgHo0xb5bT+?=
 =?us-ascii?Q?/+mLvbKnAMu3HjWoT9WL36R3V+JB11/lpkO2XaPo8jgLlmlNv5BNDViVjqer?=
 =?us-ascii?Q?BG6wASwGHl/JtJeO4lekhEushdsBjH+thBvSzmFB?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e17fe359-665e-4f39-01a8-08dabbe8f6c6
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2022 09:10:47.2700
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZOdcKgtOWKDYZkN9t/9sM5D2kz63l9IVvNEJ6o34jDV3z5wu3A/7b7h3JRZ7oTVsO+xzBo19UglCSaD6ymYaPQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6252
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Eric Farman
> Sent: Thursday, October 20, 2022 12:22 AM
>=20
> Now that we have a reasonable separation of structs that follow
> the subchannel and mdev lifecycles, there's no reason we can't
> call the official vfio_alloc_device routine for our private data,
> and behave like everyone else.
>=20
> Signed-off-by: Eric Farman <farman@linux.ibm.com>

This looks good to me. With Jason's suggestion handled,

Reviewed-by: Kevin Tian <kevin.tian@intel.com>