Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Eric Farman <farman@linux.ibm.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        "Liu, Yi L" <yi.l.liu@intel.com>
CC:     Zhenyu Wang <zhenyuw@linux.intel.com>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        "Halil Pasic" <pasic@linux.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        "Peter Oberparleiter" <oberpar@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Tony Krowiak <akrowiak@linux.ibm.com>,
        Jason Herne <jjherne@linux.ibm.com>,
        Harald Freudenberger <freude@linux.ibm.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        Eric Auger <eric.auger@redhat.com>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        Abhishek Sahu <abhsahu@nvidia.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: RE: [PATCH v1 4/7] vfio/ccw: move private to mdev lifecycle
Thread-Topic: [PATCH v1 4/7] vfio/ccw: move private to mdev lifecycle
Thread-Index: AQHY49b8P2GI9FlBPkaHDp4x02LD3K4p2qDQ
Date:   Tue, 1 Nov 2022 09:08:14 +0000
Message-ID: <BN9PR11MB527698B0A9E039268916AA018C369@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20221019162135.798901-1-farman@linux.ibm.com>
 <20221019162135.798901-5-farman@linux.ibm.com>
In-Reply-To: <20221019162135.798901-5-farman@linux.ibm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JaDtLy20ibVc0dykXdY1UloBw6hcVuxm5fG4/Ah7yLubqbO46bjBoHfHhdFo?=
 =?us-ascii?Q?p58aq/BPzDq4zvhHJN1Y6YUjXPMD5zyPUKWJefv0dOGvWYqVFWCGuNtJbiQA?=
 =?us-ascii?Q?cFsnopV8HjJn+eBjNMiI6PADT0iXjw81v/IyOAsivExnwNEYDfHaRw4e9y9z?=
 =?us-ascii?Q?UzJ9/ozFP4ShxGoaIXgIJ8RNbF6NC279jlCHF7I+8ZGmBEkrpU2jDSg1mkQx?=
 =?us-ascii?Q?2y0/AXS5/hehzhOsTjB+CjptkJHd2MipXOcRetuxP8V61bGzx/K6lf6oe637?=
 =?us-ascii?Q?NXURxGjRDkRmHqy8wYx1c2oXL3xVtNRCJnCBtKix/nlKK3VmOTOnjP5k3DdU?=
 =?us-ascii?Q?18rqWp+s0ruG5vSHVE1A6Z0UCBc90Jb4P//h31qG142fpHLCHVTd+tGUegsF?=
 =?us-ascii?Q?akjzNQLE/pXRQvGvXAWSnaLBYVy2LCG4bRZwfgn7hOBIf+Noxm6XXgml6aK0?=
 =?us-ascii?Q?uIkEKMXaqSlA4fjUSbFB5F/25I1cFjF+f15/9W5MBXvAhcbZVssjMeDfNBYn?=
 =?us-ascii?Q?UAtMET+vI7xaGIs/07AGGiOQnbkshnruByUBCZJN30EhCQmQNOViDIw/mQqt?=
 =?us-ascii?Q?+yGRe9vAwMy/Rc0WYJcGfdW8UHtQ+Vc3oqwhmVAaLdIvxu99LqoXGa1UtfqR?=
 =?us-ascii?Q?av7X42kITw7/xIO0SUYlvPhTBSJzF97W7Mfczhr8skH5T8rhxY25ep7JIlbW?=
 =?us-ascii?Q?m1jp9pHUKXWlpxibKNIVyhwmHgXYhkxTsmNjcWjbOFzVHJRH2vtIzu7dVRbz?=
 =?us-ascii?Q?p4+MuK8aYICYCeQfTJnAq/JyKPfgASDzUSYbUmfQ9pCH54KKBj7lE/qlDnfl?=
 =?us-ascii?Q?k+BxhIb0bAsHkP5EDQemjPibOGJxNOi2hE9NdMSH/8kcOgi532PZMi6DOlYC?=
 =?us-ascii?Q?eqn2fYKS0kZj+Uofc2qPbXUyLfy4ONa3A8LKZjiLwtaTmZDrCWm2abLmQG5P?=
 =?us-ascii?Q?LwAcWEjJGkrpzVnn0DwxgXBPFg3y2zRfqdqdATca6Q4nWCIdOI6TBDZlL3Rl?=
 =?us-ascii?Q?+eYtgQCIavTZrdbtrQckJWU3t4y40jNSwKj3fIz0Ew9biPyIAYsIN5H62nJg?=
 =?us-ascii?Q?4N9FoUqsftcj98ovcw5mqjDwMKLAFa3EKvJSciRu4a4Di/3oUSG5ZYj/H1cM?=
 =?us-ascii?Q?Zj3a1LXhWu3PDkJr1Bw20xiygpOTid6MCzGH9za9fWt5+kdW8cJYh1qsj4Ei?=
 =?us-ascii?Q?Nj+lukgZ5EroYZCM8/f8W+1Fo6y9Byk9XQr7OeUTsQlxyJb1VU5ryTiNDx4O?=
 =?us-ascii?Q?sARdBxnmtVPkNPBMrZgadSf4DbFRwGuqb8JoOaJvnsRjfxZisOqhNe6dGmd1?=
 =?us-ascii?Q?HJDXx33HcBtst58wBH33A7yWFOR+XTKRx2o2SPCJmwIx66q2m1JyNklzqSIL?=
 =?us-ascii?Q?L6y7IFuukSMlXcOJveC18DQf5sjNmrwnETRBzEs0glbbMP1Vm1TW5VJ0PiiO?=
 =?us-ascii?Q?fXybrOISCa44qdgoIky/m6f3ZGEK5RErms9Ti5Wc82uOf1unPXbH2wMc7E9X?=
 =?us-ascii?Q?2PvP0w3Qi7HE+WqoIcxoGXYx7mRR+ypM78T6RKtgnW/KhpylwMoSD8/8d+Ia?=
 =?us-ascii?Q?1nlMCHtwREEy1HUDHLlpct0WPGcyQfEQj1JwpTtL?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed20d7a2-91ff-4047-8a95-08dabbe89b85
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2022 09:08:14.1748
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: i8AVMrweK8UHOGx6t1jpxcPvmdvRzonst8ys/I9Ce4dfq0OMg6vmjQd5jXT/2pvFw5BuRi671Gv2gFPoNBck0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6252
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Eric Farman <farman@linux.ibm.com>
> Sent: Thursday, October 20, 2022 12:22 AM
>=20
> @@ -101,15 +101,20 @@ static int vfio_ccw_mdev_probe(struct
> mdev_device *mdev)
>  {
>  	struct subchannel *sch =3D to_subchannel(mdev->dev.parent);
>  	struct vfio_ccw_parent *parent =3D dev_get_drvdata(&sch->dev);
> -	struct vfio_ccw_private *private =3D dev_get_drvdata(&parent->dev);
> +	struct vfio_ccw_private *private;
>  	int ret;
>=20
> -	if (private->state =3D=3D VFIO_CCW_STATE_NOT_OPER)
> -		return -ENODEV;

Not familiar with ccw but just want to double confirm this removal
is intentional w/o side-effect?

> +	private =3D vfio_ccw_alloc_private(sch);
> +	if (!private)
> +		return -ENOMEM;
>=20
>  	ret =3D vfio_init_device(&private->vdev, &mdev->dev,
> &vfio_ccw_dev_ops);
> -	if (ret)
> +	if (ret) {
> +		kfree(private);
>  		return ret;
> +	}
> +
> +	dev_set_drvdata(&parent->dev, private);
>=20
>  	VFIO_CCW_MSG_EVENT(2, "sch %x.%x.%04x: create\n",
>  			   sch->schid.cssid,
> @@ -123,6 +128,7 @@ static int vfio_ccw_mdev_probe(struct mdev_device
> *mdev)
>  	return 0;
>=20
>  err_put_vdev:
> +	dev_set_drvdata(&parent->dev, NULL);

No need to set drvdata to NULL, iiuc