Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp2026410rwi; Tue, 1 Nov 2022 02:58:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5DCERZyyUCDlbFTUkwd4tLOvdprTjod1p0W0maFD7/u8pXXFiGxzwoZI2b3FE57yk59ODO X-Received: by 2002:a05:6a00:27a0:b0:56d:401c:6eb6 with SMTP id bd32-20020a056a0027a000b0056d401c6eb6mr13781741pfb.42.1667296739213; Tue, 01 Nov 2022 02:58:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667296739; cv=none; d=google.com; s=arc-20160816; b=zyQHSctLDRa9N8V8NIT2wFzPRHVxwPoJ+UYMDQuOuTw/H8wQV3VWZ3+rSt3z/Ul0cr uVE47q7hADy0c9oDN4d86za/6bK5WTLUR/sfUWZJ4Lh6ZRtaS2doKBMFdga8DoTMj3B2 3yg2pGA/TrYxxYWYjpYLnf+CJvqaE7Juub4ZqmhORa/buljIUJPGrKDDWr9UhU86GJUF P5VR+4vpv260KavCBMOvKxXA1iZiPkNT8kfnZZ+TMZeYKyQtmE/J0UvNtX93RG05VigZ DNsSCCcENZ032gEoZPtuo2bpNB9UoNK68ZC7Hb49+D3mbHU9Qbgzu9QvHHDzNbfLPyFT Iy8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=GtZxyyNZ208dqt8mYIqM2sVUcXt4H5XOo2GKGR5IExM=; b=ENVioWrVQen/VXrnwtYJnGfgHLWVRGOh3KJ+9TvEC1ChrlcW3mZP2HBI4NPSKyNi6z L9HHn4RJHgaayt1SKYf/ZaNjzhPjKkbhbxnvNQyfQoG7DcWyCf/KJWFOah4p5OhYO/XY 8gn62W9DJ1IDhSHLkkAHSXjPy82Bh8xXzfyyE/n1qQ5NpzQmDbpPUPK2CbKUeRW5AI0C sXICuzVzfEP8JPjbMd/HJC/euHG2LrEpi3mY1eOHlXbMw8XVgRqztC6e74qIoBxngGUz kEHtdoV2rO0VBXG/UxvPOpaUElwvgsQwRj+pQdQi+sIHdJp90G2EcP3ydtUkpSi/ZzOR UhNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s8-20020a655848000000b00460358671e2si11772787pgr.547.2022.11.01.02.58.46; Tue, 01 Nov 2022 02:58:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbiKAJew (ORCPT + 97 others); Tue, 1 Nov 2022 05:34:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230150AbiKAJe0 (ORCPT ); Tue, 1 Nov 2022 05:34:26 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02DA018B13; Tue, 1 Nov 2022 02:34:26 -0700 (PDT) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4N1l8m1Xl4zRnsP; Tue, 1 Nov 2022 17:29:28 +0800 (CST) Received: from huawei.com (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 1 Nov 2022 17:34:23 +0800 From: Kemeng Shi To: , CC: , , Subject: [PATCH 07/20] block, bfq: simpfy check for interactive bfqq in bfq_update_wr_data Date: Tue, 1 Nov 2022 17:34:04 +0800 Message-ID: <20221101093417.10540-8-shikemeng@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20221101093417.10540-1-shikemeng@huawei.com> References: <20221101093417.10540-1-shikemeng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The bfqq->wr_coeff will be set to bfqd->bfq_wr_coeff if bfqq is in interactive weight raising. So we can simpfy interactive weight raising check in function bfq_update_wr_data. Signed-off-by: Kemeng Shi --- block/bfq-iosched.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 20ae52882235..15e7d6c6fa83 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4997,8 +4997,7 @@ static void bfq_update_wr_data(struct bfq_data *bfqd, struct bfq_queue *bfqq) bfqq->entity.prio_changed = 1; } } - if (bfqq->wr_coeff > 1 && - bfqq->wr_cur_max_time != bfqd->bfq_wr_rt_max_time && + if (bfqq->wr_coeff == bfqd->bfq_wr_coeff && bfqq->service_from_wr > max_service_from_wr) { /* see comments on max_service_from_wr */ bfq_bfqq_end_wr(bfqq); -- 2.30.0