Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6593b620-9db5-3020-1817-c3a9ca839803@redhat.com>
Date:   Tue, 1 Nov 2022 10:44:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] mfd: intel_soc_pmic: allow COMPILE_TEST or
 I2C_DESIGNWARE_PLATFORM
To:     Randy Dunlap <rdunlap@infradead.org>, linux-kernel@vger.kernel.org
Cc:     Andy Shevchenko <andy@kernel.org>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Lee Jones <lee@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
References: <20221101055433.16891-1-rdunlap@infradead.org>
Content-Language: en-US, nl
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <20221101055433.16891-1-rdunlap@infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 11/1/22 06:54, Randy Dunlap wrote:
> Linus expressed a desire to have intel_soc_pmic_crc.o (INTEL_SOC_PMIC,
> for Crystal Cove) be built on an "allmodconfig" build, when
> I2C_DESIGNWARE_PLATFORM=m, to enhance build test coverage.
> 
> The PMIC driver won't work in this case since it requires
> I2C_DESIGNWARE_PLATFORM=y to operate properly, but adding
> "|| COMPILE_TEST" does improve the build test coverage.
> 
> Link: https://lore.kernel.org/all/CAHk-=wg=hh8xkPjiySnjAyR66AG64eyZ1Y9gHw+MCs8uuSZReA@mail.gmail.com/
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans


> ---
>  drivers/mfd/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -- a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -603,7 +603,7 @@ config INTEL_SOC_PMIC
>  	bool "Support for Crystal Cove PMIC"
>  	depends on HAS_IOMEM && I2C=y && GPIOLIB && COMMON_CLK
>  	depends on (X86 && ACPI) || COMPILE_TEST
> -	depends on I2C_DESIGNWARE_PLATFORM=y
> +	depends on I2C_DESIGNWARE_PLATFORM=y || COMPILE_TEST
>  	select MFD_CORE
>  	select REGMAP_I2C
>  	select REGMAP_IRQ
>