Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <Y2DXsnrQjQeP2PfO@elroy-temp-vm.gaiao0uenmiufjlowqgp5yxwdh.gvxx.internal.cloudapp.net>
 <alpine.DEB.2.22.394.2211010942210.2834@hadrien>
In-Reply-To: <alpine.DEB.2.22.394.2211010942210.2834@hadrien>
From:   Tanju Brunostar <tanjubrunostar0@gmail.com>
Date:   Tue, 1 Nov 2022 10:07:31 +0100
Message-ID: <CAHJEyKW0wcY8sSZWG6CpF8p8e+i12vN9mtOYngQQBRh8zxRr7Q@mail.gmail.com>
Subject: Re: [PATCH v2] staging: vt6655: change variable name wTimeStampOff
To:     Julia Lawall <julia.lawall@inria.fr>
Cc:     gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 1, 2022 at 9:43 AM Julia Lawall <julia.lawall@inria.fr> wrote:
>
>
>
> On Tue, 1 Nov 2022, Tanjuate Brunostar wrote:
>
> > Change the variable name wTimeStampOff to adhear to Linux kernel coding
> > style, which does not allow naming variables in CamelCase. error is
> > reported by checkpatch
>
> adhear -> adhere
>
> error -> Error
>
> Actually, the variable is written in Hungarian notation, given the little
> w at the beginning of its name.
>
> Maybe
>
> "Remove the use of Hungarian notation, which is not used in the Linux
> kernel."
>
> julia
>
Thanks
> >
> > Signed-off-by: Tanjuate Brunostar <tanjubrunostar0@gmail.com>
> > ---
> >  drivers/staging/vt6655/rxtx.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> > index 1e5036121665..9bdcf2337235 100644
> > --- a/drivers/staging/vt6655/rxtx.c
> > +++ b/drivers/staging/vt6655/rxtx.c
> > @@ -54,7 +54,7 @@
> >   */
> >  #define CRITICAL_PACKET_LEN      256
> >
> > -static const unsigned short wTimeStampOff[2][MAX_RATE] = {
> > +static const unsigned short time_stamp_off[2][MAX_RATE] = {
> >       {384, 288, 226, 209, 54, 43, 37, 31, 28, 25, 24, 23}, /* Long Preamble */
> >       {384, 192, 130, 113, 54, 43, 37, 31, 28, 25, 24, 23}, /* Short Preamble */
> >  };
> > @@ -130,7 +130,7 @@ static __le16 s_uFillDataHead(struct vnt_private *pDevice,
> >
> >  static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
> >  {
> > -     return cpu_to_le16(wTimeStampOff[priv->preamble_type % 2]
> > +     return cpu_to_le16(time_stamp_off[priv->preamble_type % 2]
> >                                                       [rate % MAX_RATE]);
> >  }
> >
> > --
> > 2.34.1
> >
> >
> >