Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp2057103rwi; Tue, 1 Nov 2022 03:22:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7z7T5zsVVWAbsm5HjFWNb9tpUf0f5Qjtl/oRqkt6dGLlC4n3ajh9J6zWMWHd4X1wHvJrmd X-Received: by 2002:a63:28c:0:b0:46e:9da9:80f8 with SMTP id 134-20020a63028c000000b0046e9da980f8mr16790793pgc.373.1667298134349; Tue, 01 Nov 2022 03:22:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667298134; cv=none; d=google.com; s=arc-20160816; b=P84o9YNrYBmZ5Yc3bi89wG03sYeeOTy3BEWQ2Y/gXzG6fJDRRt4y1SkjSi1Y3yDnrU NbESzePFlFw3UH/clWwHV6XGGOb/1iuQ0NTALjV9732wZPiOTyqO1GzftPfKSyAW4fVN a12uPI7dtLVlhcTqKWvjJK/72I8c19XxYu7TOaFUOOCHEn8UV7auUioko6cpPMwyCd5p F+qhJlov+MuyKyjxmQJeysO1EYTB6VZ7RP11JHJM3J8VIlV374PUP8EYPrrjfru2SeoG m5KLgN202KWLxAWccowO4E3VD3AwnqmgXugtjNkEsfuNSkgegpVgKzemTwzIYhcOeRnA gP+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5k44Xi1lhvoXFZWuJ77geE7RpIC/sY84LOFeQpra6ag=; b=c9XIsY5UnkLbWv0pclqUNyfreNzJbY4z/+DSXJmED/2vqxxSMdQGyZDw/ZimGa9YcL uABbMUdz6xLWldgykMmPe9v5cdxE6AAv7Z9PloJBXVP3iKiKOoohp+Jcp8N/drW6JSi6 n446/sSTsRuv4slj65/NF1tMOlJn0w5lBp58LpZnUCZHKVMRO5dM3N6K2XvnAezcv9h9 0vD8prNDWLPk5nZys0ddePLbbEKsABaRBiUjC6VHG4OnmNBDiu4Js518fZGm8wFk15gg 3A5y5T9GG/U0DnHjYvoHEYvLmo6wFAyQ/xWCJBC2m8FhOBbQ/9aomthsfgFPLhspeuxO 6PzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=GOjKx306; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b5-20020a170902e94500b001853ad3944dsi11079506pll.480.2022.11.01.03.21.59; Tue, 01 Nov 2022 03:22:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=GOjKx306; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230437AbiKAKDM (ORCPT + 98 others); Tue, 1 Nov 2022 06:03:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbiKAKDH (ORCPT ); Tue, 1 Nov 2022 06:03:07 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54EBE193DC for ; Tue, 1 Nov 2022 03:03:05 -0700 (PDT) Received: from zn.tnic (p200300ea9733e7f5329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9733:e7f5:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id AFD651EC063A; Tue, 1 Nov 2022 11:03:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1667296983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=5k44Xi1lhvoXFZWuJ77geE7RpIC/sY84LOFeQpra6ag=; b=GOjKx306L15AuDaGxFU7SlrFwAp/GWl71Gy43EsErnqxEmwG+50j/5mQhBBP9TVTTVwvAa ozWO3Z+H+NmFcQd2r8Xyz5JNdszPJ2Bq0/FyvMC6tPyb9ViW29URUTlofOqEEDdb+HlXBA 3wNYQAFtuz8cTYuZEORIPpO9eRyL3R4= Date: Tue, 1 Nov 2022 11:02:58 +0100 From: Borislav Petkov To: Juergen Gross Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" Subject: Re: [PATCH v4 16/16] x86/mtrr: simplify mtrr_ops initialization Message-ID: References: <20221004081023.32402-1-jgross@suse.com> <20221004081023.32402-17-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2022 at 10:48:10AM +0100, Juergen Gross wrote: > Hmm, with the cpu_feature_enabled() implementation it should be quite > obvious that this is all dead code. Yes it is. I ran ~100 randconfigs with both gcc and clang and not a single one failed the build so I guess you can say in the commit message that it is ok for this symbol to be not present on 64-bit as it will be eliminated anyway. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette