Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp2141000rwi; Tue, 1 Nov 2022 04:28:59 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4MqRsKd+GiE+6ZQNsN56m4BGK/PygElHhRGKlFdtfdZkk60oG6NJB3NsbYvKPVQnpA5qrq X-Received: by 2002:a17:903:26ce:b0:186:9029:fa22 with SMTP id jg14-20020a17090326ce00b001869029fa22mr18445772plb.140.1667302139557; Tue, 01 Nov 2022 04:28:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667302139; cv=none; d=google.com; s=arc-20160816; b=R2nQlDJ4AAeq9GCWxCkm2F17rrzPPiXNQiUf6UjstaPU2VI8sJrUSEIMT/WOEzLL14 VWVJtmNyuPdZwyHeV4//EHnqJaUXSjXCDaybjUDtpOMbgg/ZkWc+gC1o3bcTZArE2616 Da7CCbkZwiLA3govjeRc5lRK52yxqNY5eFR9A6Z1DttgkuNmfj/u33W3FeD6wYGyZO1M g3Da7OXh1nmk+GtvhQ0adgPC5jHfS8iFXie8jaWOkqCBzTU4L71IpjRiHMxeewramknp QK/X84hABjw1zhnnjVrNZMmrLoYmBjmvDm4WaZGRJyxaslu9o/HVnzn5X9G03TrSBwvM JI+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=9INiImrDVot8UE/8Cdx1V6rq3BTk5V8ovj2jAK8iZvg=; b=NsyHuMntR72YH7j0zOomeQwnwYo4RbgL+m1TBQiia7dzMd3BgnukLYXaBTdQ4qmw7b qmrIwqTsHOAo834UY7n/5/NnMtlaizooKubM+T/Rq2NGoaLcjFPQh0ZBupWn+GPsHC8Z yjT0KCRC8rUzDccPXV0hETjWsZD4dMfk4ZRrh0mQ+EFIAlulT8ArQFOJSuTJ+75FSkqd +fZyHq9O3D+vAx7rggjY+rdeiNCPFTnaIBXF5lzPKjcB8PDBFj9nVW0CyYH3N/wakeh5 y0X4JuNFyqXVqW/9OTSwluwMhDxHIWwTUhNra7AwW8YceMy44ficqKepl0tSssUFThLK c8xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r207-20020a632bd8000000b0046e96b9ecfdsi11875104pgr.801.2022.11.01.04.28.46; Tue, 01 Nov 2022 04:28:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229670AbiKALQ0 convert rfc822-to-8bit (ORCPT + 97 others); Tue, 1 Nov 2022 07:16:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230173AbiKALQX (ORCPT ); Tue, 1 Nov 2022 07:16:23 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BED6186C9 for ; Tue, 1 Nov 2022 04:16:22 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-148-T16JRegdN2KCP6Vv8a13JA-1; Tue, 01 Nov 2022 11:16:19 +0000 X-MC-Unique: T16JRegdN2KCP6Vv8a13JA-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 1 Nov 2022 11:16:17 +0000 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.042; Tue, 1 Nov 2022 11:16:17 +0000 From: David Laight To: 'Bo Liu' , "pbonzini@redhat.com" CC: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] KVM: replace ternary operator with min() Thread-Topic: [PATCH] KVM: replace ternary operator with min() Thread-Index: AQHY7cMaIkkRYJlAy0yMrTd+ywOc6K4p6rBQ Date: Tue, 1 Nov 2022 11:16:17 +0000 Message-ID: References: <20221101072513.7364-1-liubo03@inspur.com> In-Reply-To: <20221101072513.7364-1-liubo03@inspur.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bo Liu > Sent: 01 November 2022 07:25 > > Fix the following coccicheck warning: > > virt/kvm/kvm_main.c:5289:10-11: WARNING opportunity for min() ... > - return r < 0 ? r : 0; > + return min(r, 0); As has been repeatedly pointer out this is bogus. min() should only be used for 'sizes'. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)