Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221101121552.21890-1-chenzhongjin@huawei.com>
In-Reply-To: <20221101121552.21890-1-chenzhongjin@huawei.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Tue, 1 Nov 2022 05:37:09 -0700
Message-ID: <CANn89iLU4_YpS9abdsyckJ4ZWu+jtvHH=fHnxLe0ByPJ7gh8ng@mail.gmail.com>
Subject: Re: [PATCH net] net, neigh: Fix null-ptr-deref in neigh_table_clear()
To:     Chen Zhongjin <chenzhongjin@huawei.com>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
        dsahern@kernel.org, daniel@iogearbox.net, yangyingliang@huawei.com,
        stephen@networkplumber.org, wangyuweihx@gmail.com,
        alexander.mikhalitsyn@virtuozzo.com, den@openvz.org,
        xu.xin16@zte.com.cn
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 1, 2022 at 5:19 AM Chen Zhongjin <chenzhongjin@huawei.com> wrote:
>
> When IPv6 module gets initialized but hits an error in the middle,
> kenel panic with:
>
> KASAN: null-ptr-deref in range [0x0000000000000598-0x000000000000059f]
> CPU: 1 PID: 361 Comm: insmod
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996)
> RIP: 0010:__neigh_ifdown.isra.0+0x24b/0x370
> RSP: 0018:ffff888012677908 EFLAGS: 00000202
> ...
> Call Trace:
>  <TASK>
>  neigh_table_clear+0x94/0x2d0
>  ndisc_cleanup+0x27/0x40 [ipv6]
>  inet6_init+0x21c/0x2cb [ipv6]
>  do_one_initcall+0xd3/0x4d0
>  do_init_module+0x1ae/0x670
> ...
> Kernel panic - not syncing: Fatal exception
>
> When ipv6 initialization fails, it will try to cleanup and calls:
>
> neigh_table_clear()
>   neigh_ifdown(tbl, NULL)
>     pneigh_queue_purge(&tbl->proxy_queue, dev_net(dev == NULL))
>     # dev_net(NULL) triggers null-ptr-deref.
>
> Fix it by passing NULL to pneigh_queue_purge() in neigh_ifdown() if dev
> is NULL, to make kernel not panic immediately.
>
> Fixes: 66ba215cb513 ("neigh: fix possible DoS due to net iface start/stop loop")
> Signed-off-by: Chen Zhongjin <chenzhongjin@huawei.com>
> ---

SGTM, thanks !

Reviewed-by: Eric Dumazet <edumazet@google.com>