Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cee0b0176edc942ecc0ce6f4d585c239f9b7c425.camel@linux.ibm.com>
Subject: Re: [PATCH] efi: Add iMac Pro 2017 to uefi skip cert quirk
From:   Mimi Zohar <zohar@linux.ibm.com>
To:     Aditya Garg <gargaditya08@live.com>,
        "chyishian.jiang@gmail.com" <chyishian.jiang@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jarkko@kernel.org" <jarkko@kernel.org>,
        "dmitry.kasatkin@gmail.com" <dmitry.kasatkin@gmail.com>,
        "paul@paul-moore.com" <paul@paul-moore.com>,
        "jmorris@namei.org" <jmorris@namei.org>,
        "serge@hallyn.com" <serge@hallyn.com>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
        "linux-security-module@vger.kernel.org" 
        <linux-security-module@vger.kernel.org>
Cc:     "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Orlando Chamberlain <redecorating@protonmail.com>
Date:   Tue, 01 Nov 2022 07:57:17 -0400
In-Reply-To: <8CB9E43B-AB65-4735-BB8D-A8A7A10F9E30@live.com>
References: <8CB9E43B-AB65-4735-BB8D-A8A7A10F9E30@live.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Precedence: bulk

Hi Aditya,

On Thu, 2022-10-27 at 10:01 +0000, Aditya Garg wrote:
> From: Aditya Garg <gargaditya08@live.com>
> 
> The iMac Pro 2017 is also a T2 Mac. Thus add it to the list of uefi skip cert.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Aditya Garg <gargaditya08@live.com>

I found this list of computers with the Apple T2 Security Chip - 
https://support.apple.com/en-us/HT208862, but not a list that
correlates them to the system ID.  With this update, is this the entire
list?

thanks,

Mimi

> ---
>  security/integrity/platform_certs/load_uefi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c
> index b78753d27d8ea6..d1fdd113450a63 100644
> --- a/security/integrity/platform_certs/load_uefi.c
> +++ b/security/integrity/platform_certs/load_uefi.c
> @@ -35,6 +35,7 @@ static const struct dmi_system_id uefi_skip_cert[] = {
>  	{ UEFI_QUIRK_SKIP_CERT("Apple Inc.", "MacPro7,1") },
>  	{ UEFI_QUIRK_SKIP_CERT("Apple Inc.", "iMac20,1") },
>  	{ UEFI_QUIRK_SKIP_CERT("Apple Inc.", "iMac20,2") },
> +	{ UEFI_QUIRK_SKIP_CERT("Apple Inc.", "iMacPro1,1") },
>  	{ }
>  };
>