Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp2563044rwi;
        Tue, 1 Nov 2022 09:05:05 -0700 (PDT)
X-Google-Smtp-Source: AMsMyM73NyBfd0PiOcR5+iCUww3/hn/Q4qOn4NMu9RFB1MMpvrvMLD4gyI7yTUkWtmDyCxmhvkdl
X-Received: by 2002:a17:906:ee8e:b0:730:3646:d178 with SMTP id wt14-20020a170906ee8e00b007303646d178mr19403602ejb.426.1667318705366;
        Tue, 01 Nov 2022 09:05:05 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1667318705; cv=none;
        d=google.com; s=arc-20160816;
        b=yhKTzn3rDPshCFqdnMxkeMJGZwDubkaIa2U1akQR7B3qLbmkRbk2Tx4ACizAkbvIlp
         BcTQApLnIu7WRHLY9Z+OZEfFE9Gbv484fdGcEdiU4M/koy3XeVXX1GSY4hypPDuyzq4Q
         AElcN8eLHX8wFzMfGuhNlSBM2kom0LUZhSEvtuZsKVAf3DinKJcKP34gStPvINLcqRAl
         /0yDqSYowQH5uE46+Nuxb1auiLv7OCc34PESbjqEvLuIwzxXuup8Ya+C2zrIxsMUq2GX
         9B7zYhTUbsPki83/kNFctINaIvtQ4PprjwuO6PtfwdKNUkgyMMFD90q+WSHRFle3+NNG
         w0nw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=SQfKEOdg+WdJr1tCIhR7kogKF8WJ5q/AtzxpPLwf0Bg=;
        b=aZKAn8o/i9nTdQ5QckvjAU5f2Y/9NEtVlXzHeg+4SUHirYkNj4CxQFvEI2+0KrlxYn
         w+ejJfvZJZPIgYA78ujlrmUzYubXvA1EgA8bw0AKVtfNAt2Z9NpKN4bCVYmy1oc8MJaC
         /63l9j7l0kmGl5aqSLGgRFTU9mL0LKz287ykmcpRr+7eBYyv55qh9Gv/0Dk6b2w5laPz
         E5LMibLDy1Rg1GVUsUIQYgGdWmDWSbWMen6hl0Mfz3Zl4u/+NARu9bfzWRGzhiVnfLJQ
         yiDYYiFMv+tHQ8WwEJdhSrRwrSED9SgbOKczTLkCa34RQf/aekGB+CqvM4BnsjWEqT7O
         kSRQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GaYedyTU;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id gn28-20020a1709070d1c00b0078dbec2e632si13218516ejc.620.2022.11.01.09.04.39;
        Tue, 01 Nov 2022 09:05:05 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GaYedyTU;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231486AbiKAPv6 (ORCPT <rfc822;linux.lists.archive@gmail.com>
        + 96 others); Tue, 1 Nov 2022 11:51:58 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33182 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229533AbiKAPv5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Nov 2022 11:51:57 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BD5D17E04;
        Tue,  1 Nov 2022 08:51:56 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 2342F61584;
        Tue,  1 Nov 2022 15:51:56 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1ECB0C433C1;
        Tue,  1 Nov 2022 15:51:55 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1667317915;
        bh=4+88DLjvlI3igvKhb5L1IonUQmNERhUeCtjZWJhqOzE=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=GaYedyTUBkvoSSqQVLGZbGe7lp2SF3UgvxmfqQK5wP92ic4UfGmVVqvO7lTqtviux
         A0mMo3+1UDA2SJCS9e2Q23FxnbM7UJqXz2kefjUH9aOHbo9O3OATb4DRWJsbO32yYn
         K2Uw1JPqlY1FZpsBRce5Wprm/BQ2vCCi+XwazkQxZl3xRV9bWso+Ti19siner96C1P
         E5moscdaMFlrGpEm5cgLsl4VGimajIESc3VlZD4ss3eTErmWrFGjB0ZA8p2FgLIdxl
         lj/MuPFiSTe+plwEHvd2Mi+pdkNnqOMdczlsjbLLrvlb3nk4UBHb2R2VkMmqoQknIJ
         PqQyKYoG/yUnw==
Date:   Tue, 1 Nov 2022 08:51:53 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Richard Gobert <richardbgobert@gmail.com>
Cc:     davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        lixiaoyan@google.com, alexanderduyck@fb.com,
        steffen.klassert@secunet.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] gro: avoid checking for a failed search
Message-ID: <20221101085153.12ccae1c@kernel.org>
In-Reply-To: <20221024051744.GA48642@debian>
References: <20221024051744.GA48642@debian>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 24 Oct 2022 07:17:49 +0200 Richard Gobert wrote:
> After searching for a protocol handler in dev_gro_receive, checking for
> failure is redundant. Skip the failure code after finding the 
> corresponding handler.

Why does it matter? You see a measurable perf win?

Please fix the data on your system when you repost.