Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1c11a429-b5a9-fb55-fbef-b49e760e2d1e@oracle.com>
Date:   Tue, 1 Nov 2022 10:45:00 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v13 7/7] x86/crash: add x86 crash hotplug support
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com,
        tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com
References: <20221031193604.28779-1-eric.devolder@oracle.com>
 <20221031193604.28779-8-eric.devolder@oracle.com> <Y2A4TqyOaPYBu4Hk@zn.tnic>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <Y2A4TqyOaPYBu4Hk@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MEJTTW9RdkVBMHVqWkJxNXEvbm9sam1ZQ1NOYWhaVzNSbFlkRU5GUFU1U3l0?=
 =?utf-8?B?Nys3UGhTRWxjOHZqTXo5VDFqM3VpczJ3SkhDdjhhM3ExbnRwYUNTdlhrZFZa?=
 =?utf-8?B?ODB5TWhSWnRWZzU2ZTVEMkVUUmlEQ1VmZDk2U2xKNkFUN1VVWkZ2eFpXQkpH?=
 =?utf-8?B?V1dRdERKWlZncE9VdEtiUE5OcWFlb3dTYzNuclVRdnJxTWRNcXlvNnNtSklq?=
 =?utf-8?B?Vm11TkNlaUlMSlJrRjMvRWIvV2phSGExUjEzQzgvMEkrL3N0ZmRWS2llUmZ4?=
 =?utf-8?B?UjBLdnVWMmY5VVg1RVZPVG9hL3MwckhtQ3JRQkJ1T0FHSklRazAyKzJ1M3NC?=
 =?utf-8?B?OVV5bzRsR1JkNlJpMGRFci9WWXN3SXpMNjhLRnM5dUhtS0ZrZHdtTnBtbm5P?=
 =?utf-8?B?ZE5BR05KNlNaZWFvZlY4YmJoSndhQ3Q2L2s4em1uODRtNGM0TTVWUFlQUnVL?=
 =?utf-8?B?TW84aTFMVFlsay9lSVRrY1g2NFdOZEovcXhGZDViYytwNElpb0VjMzNuTnBI?=
 =?utf-8?B?TEIzMmpPd2xsamFXQWZiNlNsM0hUYVFwVmNvNktsdks4YVZqb0RxdTlHWFA0?=
 =?utf-8?B?b1dhMnpWNUF0QXFJKzZYeWdZaDRjOGQ1aEJpRzBBTGZsSmFhdWY4NCtIM2x2?=
 =?utf-8?B?NDFBWjRnUm9CUWJna3pqdWgwV2FDOTJyRGZyMlFaWS9lQWNFZE95Rndwb2NU?=
 =?utf-8?B?cVA4NmhYVkEweUVHMWtOeWJhQmFMTTlrQk5HZFcwVG1RTXExSDRFaTF6RFRQ?=
 =?utf-8?B?L2IxZ3MwYXpwZGwxamdaSXVCOGllUG1xdTI1TnZUWG1STkY0OVRaTFIxS1F5?=
 =?utf-8?B?Q1VSYmxqY3BJV29LaS9mZXA0UXpzVkRka3MvVUdRemhTb3E2U0VxTmZIeGxE?=
 =?utf-8?B?a3BxYThNa0FvUlFEcis3NmRXMmVSRVpDaDNvN3phM0VtNk5KUVJ5eXRCMFhs?=
 =?utf-8?B?RG5oa0ZCemcrWGhUOUpnc3I5QjZQbEhKUHhQWjMwRlVIMUgxOStpUThYaUJ4?=
 =?utf-8?B?N2R1VW11RFN3em1FUEJ6TFh4VGdKN215UkVma0dyQThPaFZwWjJ2VEFPdFVW?=
 =?utf-8?B?bFhkMi9RWFRtWU9yMER0NGhpSWhtRm9Eak13WXYvWC9FdXFqWjVyNXlDNEhU?=
 =?utf-8?B?cGVLY2haUXRJN2JCYk1iUGZBbUg1ZjVQUDV1dG9EYTRqS0hpak80OU53NGdX?=
 =?utf-8?B?cUNMcDJpRm1wNlJxanNoNlhoN3RMSnVZTmx2T3dneGN3VEtZcmpaTkpOUzZH?=
 =?utf-8?B?NG4ySlZGQzFtMGRJaTZJSTJ2THVNcHpkVm5OTFlvNGo4VlhiclBGdDBMcUV2?=
 =?utf-8?B?ZTJnak9EN2V3NW9mN0I1WE1PZGp5Z3g2L2lNZDBXeEUrZGJTS0FZdkZsRVRT?=
 =?utf-8?B?R1d6b3VaYk40YkU1aEsxdEREdzFpeFEvMUpTeENmeU96VFRQYWxQVEpSV0tC?=
 =?utf-8?B?ZmhyM09tamdFU1RENGZtNUNmYWNQWUQxZDFWL3ZyWnAvVGdLS284SFpoN1pr?=
 =?utf-8?B?NElXNHU3cWk3eFM0MWxwbllGOUVTWlBscXprd1lhSy9kUEx2T1hVSGt6dG9i?=
 =?utf-8?B?Y045RHhCcURlNGo0ejZGUEpEVzdzd3ZNZ0VzUnZFdS92a0RrQk9QbWdQK1dU?=
 =?utf-8?B?UVgwUUtVUDdvRmxVQVVqY25BNTZESFZJOC9zSkEwMnFaei9mY0NzakJCa2l6?=
 =?utf-8?B?S3NmQml1WEFuRDRpcmZablpuQnhkV0NRcnIyZTI5Zk5mQXN5ajlycFdrMTky?=
 =?utf-8?B?RTdnSFlWK1Bqd2tyQkZrSEJJM21uaS9jbG9BWk85YmNOS20xcGRHQXhDSFR0?=
 =?utf-8?B?NWVsTTJ5aXNjOE1EYTVLWFNiSFczZ3ZxRDRSS0l5WEthbm9zM1lBSkVESkcx?=
 =?utf-8?B?QTFLOHd2QXhUZVFJK25lUWxnZkdpRE9VM2JqNi92dFZmVVl2bkY0aWJHZmZD?=
 =?utf-8?B?OGwzMlBzaGZRbWRtQlZEYkxwTWlVOXJ6WlBuODg2RlJDS29wYlNuUUkwVzVP?=
 =?utf-8?B?bkZqYkh5Q2tLYk0yNjJaNjhsM2VZN0VMMzRmSVZERkc1bTBrOXU5YnYwcFlq?=
 =?utf-8?B?WkZlK0k4T1p3TlB4eXlyYms4Q3pUMjRCb3RVMTV5M0dVSE5KYkVvMEdxRXBC?=
 =?utf-8?B?OEllVTkwSDdGcFNoUUtSK0E0VFB4cmtHQks0SzhSaU5Ga1VXNU5XVVZibm1o?=
 =?utf-8?Q?ihODmPaN8JCasUJsNlWuRik=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6139aa3-65c7-4bf6-c472-08dabc200e93
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 15:45:09.8386
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SeWp/xABybCjbA1KxvO8WRJ87e1DjTc4xEWHJiuAQwvrWWEuGKmF6wYrcOn8qmDJLi++VC7/brTJCDdo0z13JsNjEAUxxMJCBd+L+Y8OOTU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5839
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-01_07,2022-11-01_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 suspectscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211010119
X-Proofpoint-ORIG-GUID: 1s80tL9bTgpUcoG9mFb_79EryPpA_sMS
X-Proofpoint-GUID: 1s80tL9bTgpUcoG9mFb_79EryPpA_sMS
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 10/31/22 16:04, Borislav Petkov wrote:
> On Mon, Oct 31, 2022 at 03:36:04PM -0400, Eric DeVolder wrote:
>> +#if defined(CONFIG_HOTPLUG_CPU) || defined(CONFIG_MEMORY_HOTPLUG)
> 
> What happened to that here:
> 
> https://lore.kernel.org/r/Y1e85gqB3kzlx7qL@zn.tnic
> 
> ?
> 

When I was evaluating the suggestions, I realized that that particular ifdiffery was now used in 
only 3 locations, twice in kernel/crash_core.c and once in x86 crash.c.

With that realization, and the fact that we just jettisoned CONFIG_CRASH_MAX_MEMORY_RANGES for a 
#define, it seemed that there wasn't a compelling need to replace the HOTPLUG_CPU || MEMORY_HOTPLUG 
with a new CRASH_HOTPLUG Kconfig item.

As I'm re-reading that message, I suspect now the preference is to just to strike this ifdiffery 
line in this file and have the code always present?

If the preference is actually for CRASH_HOTPLUG, then let me know.

Thanks!
eric