Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5574dc8c-1665-d736-eeda-cbdbef422394@gmx.de>
Date:   Tue, 1 Nov 2022 16:30:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH v1 1/2] fbdev: ssd1307fb: Drop optional dependency
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Javier Martinez Canillas <javierm@redhat.com>,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20221101150947.67377-1-andriy.shevchenko@linux.intel.com>
From:   Helge Deller <deller@gmx.de>
In-Reply-To: <20221101150947.67377-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:caIEGPY3TKs=;Hi65LKaBmmaPJ3fLNjmPbtC17nz
 ZgoGhHy4KjtbxohlC+yOLPzmQIRzvUghdnzO7dyd2YNkvnSBiJdPgx1f9+fiYudWkywJg09mQ
 LRqLu0uM8zgARjFU2zwhox7Mk/sf6JVxqovrUxhc0wibJ4xT8fb/c2t6cdmNRIU5N/IN9QoQn
 YE5hgvjSu4ff1egF4dCAL+jKBknVm8wNo2TMbQkU1Vwm2AINPR87Q1QWWpQuUpe3NCarZUoyt
 4Gyb50L1KQBv2k8/2i8ieeV8+dfIFYYV+TuvdcHNq6tlvSoIU2DFCMnnsqgXQOCOjKXdwb0xl
 TC+w1hh4r2rnBBuH5fI1Eik9OZNmE8GfOxaEsILlKMqgdibn7z0VE7T1+eFze9RScmHmT06Ba
 KbCMJt/LuHJ5pUDqGirLoxD+A/5/2nkpMMqhx23IyMSvHvWm2OjiBKVJY2c2biPVuWyJ9pcwv
 vDt5oE6D5aQYOxp8g4OC51rlfET04EWomqSQrMbY+X9X03nm3l6uuibTrWUQAsPUKTARLcGD5
 H1xjyz4L+2kXPcg9RQ1ca3DoO8dwrmgLzrysD5OzoJrrjps+s34lrtHS+uKdMH5nvahXoqN0j
 oFSpQIkXmnEmhG0sNA1hpjztU63ohHWEvegypGmCrvKA9NRz4XZVdcL0fUxyY2pC9BwZkMDWw
 YZov38q/795YBFNLMpmMR8UyJWQFRTKCTuLa/aYdK6jr2oessPXTmVS0jHGwSSPAoqKsEW5W7
 sMznNt+BK6nfH3uw0+Q+viZZgaeXSe77goihLSASGjXJLKArQoNGxv5YdJyQjPBxCmFH10uTD
 j+B9ebH2SZTORYNXFtFgPQANi7pmtVKsSiwMDQRJTSDkKGZNZV1XFMEKBogvYIpDjvrFFq8oy
 frE4q/jedWMRj6XJp5zAHx2J2glAw9aFr+gqxhc0VrF04akQ91Z5iYAEWsWv2+3am1k1aFNgq
 ALzJmXNbYRdxMYbUo17Je7GH81k=
Precedence: bulk

On 11/1/22 16:09, Andy Shevchenko wrote:
> Only a single out of three devices need a PWM, so from driver it's
> optional. Moreover it's a single driver in the entire kernel that
> currently selects PWM. Unfortunately this selection is a root cause
> of the circular dependencies when we want to enable optional PWM
> for some other drivers that select GPIOLIB.
>
> Fixes: a2ed00da5047 ("drivers/video: add support for the Solomon SSD1307=
 OLED Controller")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Both patches applied to fbdev git tree.

Thanks!
Helge

> ---
>   drivers/video/fbdev/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index a98987aa2784..b88d8bfe992e 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -2218,7 +2218,6 @@ config FB_SSD1307
>   	select FB_SYS_COPYAREA
>   	select FB_SYS_IMAGEBLIT
>   	select FB_DEFERRED_IO
> -	select PWM
>   	select FB_BACKLIGHT
>   	help
>   	  This driver implements support for the Solomon SSD1307