Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c33efd7e-7cb5-0933-4511-bfb84ff662aa@nvidia.com>
Date:   Tue, 1 Nov 2022 14:53:29 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 10/11] usb: host: xhci-tegra: Add Tegra234 XHCI support
Content-Language: en-US
To:     Thierry Reding <thierry.reding@gmail.com>,
        Wayne Chang <waynec@nvidia.com>
Cc:     gregkh@linuxfoundation.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, treding@nvidia.com,
        heikki.krogerus@linux.intel.com, ajayg@nvidia.com, kishon@ti.com,
        vkoul@kernel.org, p.zabel@pengutronix.de, balbi@kernel.org,
        mathias.nyman@intel.com, jckuo@nvidia.com,
        linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, singhanc@nvidia.com,
        linux-i2c@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-tegra@vger.kernel.org
References: <20221024074128.1113554-1-waynec@nvidia.com>
 <20221024074128.1113554-11-waynec@nvidia.com> <Y1vblCOXOCtX/RTP@orome>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <Y1vblCOXOCtX/RTP@orome>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDJKbVBHWUNGNDFZUU5nbjJlSEFEdEg2S0tETmg4M0QxUWZDejNUZGhQYmpa?=
 =?utf-8?B?ZGxucCtpM08vMkRQS2xLWDlHdDNGQUJ3Tld0M1FhWWltYWs5aXd6ODNJM0t6?=
 =?utf-8?B?QU5lV0x3WGttSkRsaVpRSjNFRktIUGNuMVJuWldmaDVjdjc3QTZDN0NESzBn?=
 =?utf-8?B?YW9aV2ZEMVRiaVFJbEdFYi9iZlQvVUtGZ0crOFRSK3hBUHRoclhWT09NM1Zh?=
 =?utf-8?B?a0YvQzN1dWdvWWxCdHdmalZ4RFl5dU1aQlcycEJjTnk4cHE0RzRyT3FrNHpK?=
 =?utf-8?B?L3V1cWJ2dVJnRFRxRzFTbVM2SXpjbk1TcG95UEd6K0tmcEdTaEliWDllanJr?=
 =?utf-8?B?TkVEVVBnMnNuaU5BZXFDSzhmZkluRTNUQUJPN1JoektRYnhYbVVwUEJyVHVR?=
 =?utf-8?B?RmFzNXVMMlpwQmRpd0JXUExZMlluclRGL0phNFBMMUsxbTUzdDhmRWw4NW9D?=
 =?utf-8?B?cmxkZ21XbXpvVzBJYUtTRjR0NjZYOFNYNnlJL0drYTlhN2cxNCtUVlJjVXhS?=
 =?utf-8?B?WWtqbXBpdUtZaWFpODBRYUhiNUoxeG1nVWwvcVYyeEZTWW1aYUFHN3QzZklI?=
 =?utf-8?B?M1oyUkpqTEhVZUNNdVlUS1pmT21Fc0g5VzdaRUVXdlJIc08vejZsS0l5ZnVS?=
 =?utf-8?B?VDB4cHJSYkNUaCtENWFZK1BhSEdQck5lVVlYZU9lRnVrb3FBTFNVbDNqVTFY?=
 =?utf-8?B?aHdZMElTdUFxc2ZiTDR6YVgrVzQ3aS9MM2FHT204Nytjbnh5NW9peE4xZUlG?=
 =?utf-8?B?YXI1Smw4YkxXblgrcml5d0lFV1NNQnlUalZmSm82eTFEaWNqelloMjhWVDlD?=
 =?utf-8?B?ZjlyczVpSjIyb3BEZExqaDRtZnpUcVVYdzNsM2J4U3YrdVhvaXBVMi9QdHhs?=
 =?utf-8?B?OXNwVkpRL00wZDh5RVd4SFpKZEZGc1Z0UklHWnpoRloybVkzaS8weW1SUm05?=
 =?utf-8?B?Mnp5cnc0TWY1bTNGdWxGVDY3U2tSeDFtc1hQMGlmZE03UjNiMjRJdE1pQ0pn?=
 =?utf-8?B?dEJmZE5hQ3ZVRzVWWGNFTkRSUGhvZDBqMnJHZnE5elh2M2lLbERDRnRTY3dJ?=
 =?utf-8?B?QzBKeXFQbVExYVlDSEYzOG5nVngrb3pWeTVlUkhpSG9uOFZNUXRIMEZDT3d6?=
 =?utf-8?B?dU5PKzZQRS8rdzlsZjIzT0daakVWYm9qTUt0VlZ6Ny9GUmV0eUUwVXNEek9L?=
 =?utf-8?B?a2FtWXZUVnd2T1BmQXRXWmxPMEVXMkFlZk9RTEl3QTVzS0FhRjEzOThtdTRs?=
 =?utf-8?B?Nlk4dVpxZ1kweVJ6OFd0aWtpS1Y4RlFsS25lZ1pIeEc2WGVjcmhOWXc2NnN6?=
 =?utf-8?B?Ti9DbXk2dVJIRTFEUG80MHZ1V01aR05GUmFPMVNJdkVLWXJjbG9ZQXIvTzE4?=
 =?utf-8?B?NkdLUk5Za0FEbEk4ZjVTY1NmV2xVK2tORkFOYXN6VlQ0aUg1RkEraEhLU0Y4?=
 =?utf-8?B?NE5aYzJzWW9hN1djOWYxcTA0bk51bnkzbDYreVVxS0lRRUZLSGIxeW1vVkt2?=
 =?utf-8?B?ZFFzMFYxMDQ4OXZ1ZVFaTU9URVplcnl5U2RmbnBxb2VQMDZJckN1aG4xKzc2?=
 =?utf-8?B?QmVNanhmUWJLUGVMUXRUMmJRUGVIUzNlQ3VXczA1Q2owdHorNlNXVi9oS0Mv?=
 =?utf-8?B?eGZBL0xzVjVnSHBFaUtUaFV5dDlINE5mbVR0ajErWk1YNWZ0WkRrTmRBd2ZO?=
 =?utf-8?B?cTBUOE9YUlZqeDFjT000RkpSNWFvNXNjMksyRnhKRzNQQUdvVERNMTJtL2VO?=
 =?utf-8?B?cklPWnNsMUswb09uS2grdzRod1RNNnRKL0hybmZWMzE1SjRWWjA4S0E1aDls?=
 =?utf-8?B?cVE4blkrcWQ3cGMyMm1MaUtOcEN1L040amNrVU5ldE5CUU5RS3JkckU5ZTd3?=
 =?utf-8?B?THVTWklNR1VpMzMxZUs3LzhKNjRvZC9LMzlnZmgvUjhkajk5U3J2VkIwVk53?=
 =?utf-8?B?TWdqbm5wN0JwUUpkTGVrUTNUR3FCK0NydVZYdXhnVkJEQkJGR1Jpa1ZzMTRY?=
 =?utf-8?B?WDRNOENXMWRHdTBQWlNISWptZnk4d0RBWUx0NGRpNWh6T0hJQkRwQTlFRm4r?=
 =?utf-8?B?bXdBZ0VVbWQ0dk1XaHhIRXdibHhxKy9teDhzM2trRmYrOFpIM09XMDVxU2d1?=
 =?utf-8?B?cnBJSDBha0h3SUhmM2JaV1NmMG9MVEt2ZjJjNWczWE9Jb0VKWXJiZC9tTlUx?=
 =?utf-8?B?Y3c9PQ==?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82c76c51-66ce-455a-2f2f-08dabc18dba5
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 14:53:37.9756
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CWfFeR3nc3mU8RwHE1YS2e2+ZZmVoWUpNiuH0uvfmaHZnEMwUaqXdrMMevonpc1AV+P+r2QK0ijKWLfJt67x4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6141
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28/10/2022 14:39, Thierry Reding wrote:

...

>> +static const struct tegra_xusb_soc tegra234_soc = {
>> +	.firmware = "nvidia/tegra234/xusb.bin",
>> +	.supply_names = tegra194_supply_names,
>> +	.num_supplies = ARRAY_SIZE(tegra194_supply_names),
>> +	.phy_types = tegra194_phy_types,
>> +	.num_types = ARRAY_SIZE(tegra194_phy_types),
>> +	.context = &tegra186_xusb_context,
>> +	.ports = {
>> +		.usb3 = { .offset = 0, .count = 4, },
>> +		.usb2 = { .offset = 4, .count = 4, },
>> +	},
>> +	.scale_ss_clock = false,
>> +	.has_ipfs = false,
>> +	.otg_reset_sspi = false,
>> +	.ops = &tegra234_ops,
>> +	.mbox = {
>> +		.cmd = XUSB_BAR2_ARU_MBOX_CMD,
>> +		.data_in = XUSB_BAR2_ARU_MBOX_DATA_IN,
>> +		.data_out = XUSB_BAR2_ARU_MBOX_DATA_OUT,
>> +		.owner = XUSB_BAR2_ARU_MBOX_OWNER,
>> +		.smi_intr = XUSB_BAR2_ARU_SMI_INTR,
>> +	},
>> +	.lpm_support = true,
>> +	.has_bar2 = true,
>> +	.has_ifr = true,
>> +};
>> +MODULE_FIRMWARE("nvidia/tegra234/xusb.bin");
> 
> Can you prepare a patch to add this firmware to the linux-firmware
> repository? I don't see it there yet.


Actually, we should remove the MODULE_FIRMWARE completely for Tegra234. 
Per the commit message the variable 'has_ifr' is used to indicate if the 
firmware is loaded by calling request_firmware() or via these IFR 
registers. I wonder if we need this 'has_ifr' variable if we should just 
avoid setting the 'firmware' variable for Tegra234 and use this instead 
of the 'has_ifr'?

Jon

-- 
nvpublic