Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp2631284rwi; Tue, 1 Nov 2022 09:50:01 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7uiUaOKaiqlnaPNT2a/lJ959ylnImsxYh2t5eGcxDqzvSLKlMjLCiPYLkOeKA75vze/jWG X-Received: by 2002:a05:6402:1941:b0:457:138:1e88 with SMTP id f1-20020a056402194100b0045701381e88mr19877757edz.394.1667321400921; Tue, 01 Nov 2022 09:50:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667321400; cv=none; d=google.com; s=arc-20160816; b=fzui84MfcIGC4ZBTEpf/fLylKNvbhpnDKtM2PMcJH0rKlAnSF/2bCMnS5lc3GNoTR/ 2hlybaiTKyy/4AxHUzqzds7ZY0CS5aBv71uIwr5toAhKF8A2JWrmaCWFa4oghLEFDpnP 3xmRWDagpHDGQ/1zvdylzwihQlO8y4JUGUDPGoeL7yeMDLGteNVe4w/ztSuKB8XAuB0K a3jnIB+2bv+hWtWQPMw8mvLhNsx6cFudbY5g7kzAMri//njaHD2O58fGXWoM3ViLzpDt ZUHIzuczo1pY3d75HACpxjfX+U0dITKSTEy1hHerhB5yz+0AtZbbcSKj5TnvsdYmNyGP FMeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1fsBVDnm8hy+DctJMMCqY6Ap6gJHi5gvPoChw6Lc/vI=; b=J6W6y++wZ/H7PddBeZ57yV9lkdqyPQ5652XGHnuXwbpveHkt6NJf6OyPWHZvxbVaSe dcAx3H+IDJJgkKtVcJ1M0LaHZMw5wEsM/9Sy1uRKHcRL1TGKh7mMJSJg4MgYkEDbnHCy kPqVDQzdxYUw1ruShyIbzdCj3tDKjTB4A17sXutea1qrkWsd0kfjaniEo2TUNLqwI6GA Hnj7OorlaZtW8KWnp+cuMYTb0NGzI9qQY68nzrQtXXlMW8jnD0NroTXuN339ZIJvIFOc +9u1HAqMgkbYn1Nx2bxPpzfAm2sphoCHVR7mwUspTnWxo86QtXcSnkBTXBroxWmPDUOr mEgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@moc6.cz header.s=mail20201116 header.b=O4uU7lg6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=moc6.cz Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw35-20020a1709066a2300b0079b9f472d85si13570687ejc.698.2022.11.01.09.49.37; Tue, 01 Nov 2022 09:50:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@moc6.cz header.s=mail20201116 header.b=O4uU7lg6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=moc6.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231356AbiKAPm3 (ORCPT + 96 others); Tue, 1 Nov 2022 11:42:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbiKAPm1 (ORCPT ); Tue, 1 Nov 2022 11:42:27 -0400 Received: from moc6.cz (hosting.moc6.cz [IPv6:2a02:c60:c70:8900::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 94AF2BCB1 for ; Tue, 1 Nov 2022 08:42:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=moc6.cz; s=mail20201116; h=In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Reply-To; bh=1fsBVDnm8hy+DctJMMCqY6Ap6gJHi5gvPoChw6Lc/vI=; b=O4uU7lg6MaJiTlT8a9jo1a6TCG xGAheeinRU4BL+6LdBLQWwjxkFxnKn5/MeSGKxrdkWI7SGG0cvs7f7YPFrNgYC5goCdHGqPL8r9B3 P8J2ko3FXt9Yo06FWd/buMAv9Qw//BuXYW86bmr38KBcwgMfkt+uYWX9YOwiR1W6cg/envmY2JdOB ihBgAeJG4wjRCFq267AEwyABt3hEgimqPXvnJpK5WOJlCK6jZJusO5YUdcFGFGy5/fwbBW/mkYVYW /ySPAC7GakqNjP44kUDr1sCXKxW5nMdi8JIfpecatl3bOtoauzrHHvvvnQlOiPr0FUhvRwFYGi+lJ oYkVjkMD2QXgwn4IQWhDfpEP8uqUggnQWuIeQ8XTSZfjrmlIqP/kvvJ/7TK+xBQGh1BlZbwZTBvEw NPfT6ywnOQlkKIR+4Hs5PEdPDCsdm8oG2iClqSHqIqQsQCQl31nW2LvFk1O0CJo5UVuo2PjmNAKZL 3DyepqrGd0l5iiujlpL/96GzCIRmP8+TozRKZH2VyBL5HfHyc1ymzviCELzZS/aILY8xRcbamWk0I h+DBStifvFIe7WukF+ok0aaYkFKAbpyitnkxcC0h8MhzS0grJ5reVmJDW+AOrgv1W/ViPk7/F8046 J2WtmNcYdz7YTvkDett6EW527lCbl/DWWPuGX1x/c=; Received: from Debian-exim by moc6.cz with local (Exim 4.94.2) (envelope-from ) authenticated: Debian-exim id 1optPB-00119c-O5; Tue, 01 Nov 2022 16:42:21 +0100 Date: Tue, 1 Nov 2022 16:42:21 +0100 From: Filip Moc To: Alex Deucher Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , David Airlie , "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= Subject: Re: [PATCH] drm/amd/display: add parameter backlight_min Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Alex, thank you for your response. Yes, I have HP ENVY x360 Convertible 13-ay1xxx, and backlight_min=2 seems to work the best in my case. I added a dmi based quirk table. So far with support only for display 0 to make it simple. Support for more displays in quirk table can be added later if ever needed. According to [1] HP ENVY x360 Convertible 13-ag0xxx also needs a quirk so I'm going to use this to cover both: DMI_EXACT_MATCH(DMI_SYS_VENDOR, "HP") DMI_MATCH(DMI_PRODUCT_NAME, "HP ENVY x360 Convertible 13-") So far it seems to be working fine. I'll send this in v2 once I do some final tweaks and do more tests. [1] https://bugzilla.kernel.org/show_bug.cgi?id=203439#c5 Filip V?Mon, Oct 31, 2022 at 11:36:09AM -0400,?Alex Deucher napsal(a): > On Sun, Oct 30, 2022 at 5:26 AM Filip Moc wrote: > > > > There are some devices on which amdgpu won't allow user to set brightness > > to sufficiently low values even though the hardware would support it just > > fine. > > > > This usually happens in two cases when either configuration of brightness > > levels via ACPI/ATIF is not available and amdgpu falls back to defaults > > (currently 12 for minimum level) which may be too high for some devices or > > even the configuration via ATIF is available but the minimum brightness > > level provided by the manufacturer is set to unreasonably high value. > > > > In either case user can use this new module parameter to adjust the > > minimum allowed backlight brightness level. > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203439 > > Signed-off-by: Filip Moc > > Does your system require an override and if so, what is it? It would > be good to add a quirk for your system as well so that other users of > the same system wouldn't need to manually figure out an apply the > settings. > > Alex > > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++ > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++++++++++++++ > > 3 files changed, 33 insertions(+) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > > index 0e6ddf05c23c..c5445402c49d 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > > @@ -200,6 +200,9 @@ extern uint amdgpu_dc_debug_mask; > > extern uint amdgpu_dc_visual_confirm; > > extern uint amdgpu_dm_abm_level; > > extern int amdgpu_backlight; > > +#ifdef CONFIG_DRM_AMD_DC > > +extern int amdgpu_backlight_override_min[]; > > +#endif > > extern struct amdgpu_mgpu_info mgpu_info; > > extern int amdgpu_ras_enable; > > extern uint amdgpu_ras_mask; > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > index 16f6a313335e..f2fb549ac52f 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > @@ -43,6 +43,7 @@ > > #include "amdgpu_irq.h" > > #include "amdgpu_dma_buf.h" > > #include "amdgpu_sched.h" > > +#include "amdgpu_dm.h" > > #include "amdgpu_fdinfo.h" > > #include "amdgpu_amdkfd.h" > > > > @@ -853,6 +854,20 @@ int amdgpu_backlight = -1; > > MODULE_PARM_DESC(backlight, "Backlight control (0 = pwm, 1 = aux, -1 auto (default))"); > > module_param_named(backlight, amdgpu_backlight, bint, 0444); > > > > +/** > > + * DOC: backlight_min (array of int) > > + * Override minimum allowed backlight brightness signal (per display). > > + * Must be less than the maximum brightness signal. > > + * Negative value means no override. > > + * > > + * Defaults to all -1 (no override on any display). > > + */ > > +#ifdef CONFIG_DRM_AMD_DC > > +int amdgpu_backlight_override_min[AMDGPU_DM_MAX_NUM_EDP] = {[0 ... (AMDGPU_DM_MAX_NUM_EDP-1)] = -1}; > > +MODULE_PARM_DESC(backlight_min, "Override minimum backlight brightness signal (0..max-1, -1 = no override (default))"); > > +module_param_array_named(backlight_min, amdgpu_backlight_override_min, int, NULL, 0444); > > +#endif > > + > > /** > > * DOC: tmz (int) > > * Trusted Memory Zone (TMZ) is a method to protect data being written > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > index eb4ce7216104..e2c36ba93d05 100644 > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > @@ -3911,6 +3911,21 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, > > dm->backlight_caps[bl_idx].min_input_signal = AMDGPU_DM_DEFAULT_MIN_BACKLIGHT; > > dm->backlight_caps[bl_idx].max_input_signal = AMDGPU_DM_DEFAULT_MAX_BACKLIGHT; > > #endif > > + > > + if (amdgpu_backlight_override_min[bl_idx] >= 0) { > > + if (amdgpu_backlight_override_min[bl_idx] < dm->backlight_caps[bl_idx].max_input_signal) { > > + DRM_INFO("amdgpu: backlight[%i]: overriding minimum brightness from %i to %i\n", > > + bl_idx, > > + dm->backlight_caps[bl_idx].min_input_signal, > > + amdgpu_backlight_override_min[bl_idx]); > > + dm->backlight_caps[bl_idx].min_input_signal = amdgpu_backlight_override_min[bl_idx]; > > + } else { > > + DRM_ERROR("amdgpu: backlight[%i]: minimum brightness override (%i) is not below maximum (%i)\n", > > + bl_idx, > > + amdgpu_backlight_override_min[bl_idx], > > + dm->backlight_caps[bl_idx].max_input_signal); > > + } > > + } > > } > > > > static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps, > > > > base-commit: d8c03bfe146fd5e081a252cd34f3f12ca0255357 > > -- > > 2.30.2 > >