Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp2631353rwi; Tue, 1 Nov 2022 09:50:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6IRlfRGRHi1dEAjxZawgeHoX11Q/fCnT8fIrV5lrGqEjj/Esv4+FELjDxbqD9we+EwMM8z X-Received: by 2002:a05:6402:616:b0:463:e2cd:a88d with SMTP id n22-20020a056402061600b00463e2cda88dmr441443edv.400.1667321403587; Tue, 01 Nov 2022 09:50:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667321403; cv=none; d=google.com; s=arc-20160816; b=dgewVEhuQHg2QEBD3EXbPEcflrghTJ3kRiWdvO1renXuTIac0BLx1Lua4KGesbqTWH 1r4/q1D62OCM8Zzc2RQNIfs6F82nejD6sxnlgNDctsMz9B43rtV/mdb9mMfHJOJ0PlAP ootAeS8x6VTFTaZ2xZolLGjv/ZcjV+QRJGljUJtKd/thJRhvSGp3t0znYLPh6r94o4yG Hu//C8yFyWFUdH76mlWuoTgq1oYRp7qy+BAdapJUyBk2OuRCOdbJCar+3WtKXm2Mi7um hDM03F92ZGeHLTwlSCoNSqaKQeFFfdxn26YJShc+9bIRC3mxB1EvUQP7rn/cR+EzaHBJ mTPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=EIvCsNcYvM6/Hsp4ajqEM/CHCcHllUHTLyim4Fdl4PQ=; b=iNthQYoA27xGRaZR9DU33hzgd4mOySr7jf1ieCNYrdIZhGULqMShGywRpljaa9Ayq7 aOjP/JVymN13iT17SQcunST9iDk5X8bib74C5ztLrKn3ep3UHcRhfDONsWeDHwLyAMGA /oObdsza94Xi9PkLt/4eVAXrbILvoItzswuM696py+H0lDR3UJhhMBndajQmNN9NrL33 3Z7lxSE5KAavyvPB0BxaGQOOYRDxUbFJjJCMr6ARRInzYv/ep2Ic8QVzNPmPuw5APr8H MiAgVwnqMo9mt3Mqa+JcJJWI8+odxzNdY22hzZAcuQgMKqAP7axM3lMadCK0EpGcUpPe TmSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Ci/4R5cj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y6-20020a50eb06000000b00461c0cb486asi11326059edp.311.2022.11.01.09.49.39; Tue, 01 Nov 2022 09:50:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Ci/4R5cj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230190AbiKAQHP (ORCPT + 96 others); Tue, 1 Nov 2022 12:07:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbiKAQHK (ORCPT ); Tue, 1 Nov 2022 12:07:10 -0400 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEF3718B35 for ; Tue, 1 Nov 2022 09:07:08 -0700 (PDT) Received: by mail-oi1-x22d.google.com with SMTP id s206so16394955oie.3 for ; Tue, 01 Nov 2022 09:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=EIvCsNcYvM6/Hsp4ajqEM/CHCcHllUHTLyim4Fdl4PQ=; b=Ci/4R5cjQS65fqeKJcqsOF3dXNAO9yGdtsYGsGuG6ITYtLKDGXMZ+E54KSHs0x7TFv AAt7wWNEhTv6+eFgud0NrPs20ruzTbW0a65k7xxqrQ2iazFb3wG/04dj4shaKnfB+X3c 0W7nqGmDY+1Of3QtcY0DIcn72+gfYv5iuT0FN/65X4wLMhn1DM6ekTf53yVhcrqlbbiM lUoUVdaxThUqrBLHofdXdYett/2k9bUeau5FO/gxqqU2OSXusZrFV5cYl64o8YUSCFZE HWZZvC0OqfyAs2cOVBTyB19AMA0p3pFhXBNzxo+1DbQfF441S0eUWU+LocCKAIEEt8HN wMnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EIvCsNcYvM6/Hsp4ajqEM/CHCcHllUHTLyim4Fdl4PQ=; b=faGQGVcnhpSW82lLvCM6eyBA1YppMNdj40dLQOk0wcTlY2HV8Yx4IiQXJ1NgaLCu85 CS/xz+dzxE791PGWyLVlw7LbBwFbKpKzsHWx2yDxjH2pWMb8XDEBc6o/Js8qObTlcCkA SkuKMd0MJIP1qFwBNhthJDA7YahiN/NI/sbQy7xu6ZY377fe3eyqKT0X3eiZYUuiF4PH IOwG25yxK2OPbT4gCDX9LJAhECtcFnCKRi0/04AwE9ytOcrCAZnyk8Vt0r10Mpp6N7F6 p3SMjv8qZkaErOX/zOGwPT1lSdAlG1wqivD7QIs5/zdma2l0HO6yhOHZie9Cw9c9RY5Z Q2+g== X-Gm-Message-State: ACrzQf2Cs1wlHA2w+LrlZzrGBjMgvzBwMhf5fhxlVGJOxEuCJgwtP4C8 dojWkPEaIPvjEwAeEvPuMqTp6NuO16YJFgL96WY= X-Received: by 2002:a05:6808:14d2:b0:354:c733:abd3 with SMTP id f18-20020a05680814d200b00354c733abd3mr10488249oiw.96.1667318828044; Tue, 01 Nov 2022 09:07:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alex Deucher Date: Tue, 1 Nov 2022 12:06:55 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: add parameter backlight_min To: Filip Moc Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , David Airlie , "Pan, Xinhui" , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 1, 2022 at 11:42 AM Filip Moc wrote: > > Hello Alex, > > thank you for your response. > > Yes, I have HP ENVY x360 Convertible 13-ay1xxx, and backlight_min=2 > seems to work the best in my case. > > I added a dmi based quirk table. So far with support only for display 0 > to make it simple. Support for more displays in quirk table can be added > later if ever needed. > > According to [1] HP ENVY x360 Convertible 13-ag0xxx also needs a quirk > so I'm going to use this to cover both: > DMI_EXACT_MATCH(DMI_SYS_VENDOR, "HP") > DMI_MATCH(DMI_PRODUCT_NAME, "HP ENVY x360 Convertible 13-") You might want to add an additional check for the panel name/vendor from the EDID as well in case HP uses multiple panels from different vendors on that system. Alex > > So far it seems to be working fine. > I'll send this in v2 once I do some final tweaks and do more tests. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=203439#c5 > > Filip > > > V Mon, Oct 31, 2022 at 11:36:09AM -0400, Alex Deucher napsal(a): > > On Sun, Oct 30, 2022 at 5:26 AM Filip Moc wrote: > > > > > > There are some devices on which amdgpu won't allow user to set brightness > > > to sufficiently low values even though the hardware would support it just > > > fine. > > > > > > This usually happens in two cases when either configuration of brightness > > > levels via ACPI/ATIF is not available and amdgpu falls back to defaults > > > (currently 12 for minimum level) which may be too high for some devices or > > > even the configuration via ATIF is available but the minimum brightness > > > level provided by the manufacturer is set to unreasonably high value. > > > > > > In either case user can use this new module parameter to adjust the > > > minimum allowed backlight brightness level. > > > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203439 > > > Signed-off-by: Filip Moc > > > > Does your system require an override and if so, what is it? It would > > be good to add a quirk for your system as well so that other users of > > the same system wouldn't need to manually figure out an apply the > > settings. > > > > Alex > > > > > > > --- > > > drivers/gpu/drm/amd/amdgpu/amdgpu.h | 3 +++ > > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 15 +++++++++++++++ > > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 15 +++++++++++++++ > > > 3 files changed, 33 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > > > index 0e6ddf05c23c..c5445402c49d 100644 > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h > > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h > > > @@ -200,6 +200,9 @@ extern uint amdgpu_dc_debug_mask; > > > extern uint amdgpu_dc_visual_confirm; > > > extern uint amdgpu_dm_abm_level; > > > extern int amdgpu_backlight; > > > +#ifdef CONFIG_DRM_AMD_DC > > > +extern int amdgpu_backlight_override_min[]; > > > +#endif > > > extern struct amdgpu_mgpu_info mgpu_info; > > > extern int amdgpu_ras_enable; > > > extern uint amdgpu_ras_mask; > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > > index 16f6a313335e..f2fb549ac52f 100644 > > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > > @@ -43,6 +43,7 @@ > > > #include "amdgpu_irq.h" > > > #include "amdgpu_dma_buf.h" > > > #include "amdgpu_sched.h" > > > +#include "amdgpu_dm.h" > > > #include "amdgpu_fdinfo.h" > > > #include "amdgpu_amdkfd.h" > > > > > > @@ -853,6 +854,20 @@ int amdgpu_backlight = -1; > > > MODULE_PARM_DESC(backlight, "Backlight control (0 = pwm, 1 = aux, -1 auto (default))"); > > > module_param_named(backlight, amdgpu_backlight, bint, 0444); > > > > > > +/** > > > + * DOC: backlight_min (array of int) > > > + * Override minimum allowed backlight brightness signal (per display). > > > + * Must be less than the maximum brightness signal. > > > + * Negative value means no override. > > > + * > > > + * Defaults to all -1 (no override on any display). > > > + */ > > > +#ifdef CONFIG_DRM_AMD_DC > > > +int amdgpu_backlight_override_min[AMDGPU_DM_MAX_NUM_EDP] = {[0 ... (AMDGPU_DM_MAX_NUM_EDP-1)] = -1}; > > > +MODULE_PARM_DESC(backlight_min, "Override minimum backlight brightness signal (0..max-1, -1 = no override (default))"); > > > +module_param_array_named(backlight_min, amdgpu_backlight_override_min, int, NULL, 0444); > > > +#endif > > > + > > > /** > > > * DOC: tmz (int) > > > * Trusted Memory Zone (TMZ) is a method to protect data being written > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > index eb4ce7216104..e2c36ba93d05 100644 > > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > @@ -3911,6 +3911,21 @@ static void amdgpu_dm_update_backlight_caps(struct amdgpu_display_manager *dm, > > > dm->backlight_caps[bl_idx].min_input_signal = AMDGPU_DM_DEFAULT_MIN_BACKLIGHT; > > > dm->backlight_caps[bl_idx].max_input_signal = AMDGPU_DM_DEFAULT_MAX_BACKLIGHT; > > > #endif > > > + > > > + if (amdgpu_backlight_override_min[bl_idx] >= 0) { > > > + if (amdgpu_backlight_override_min[bl_idx] < dm->backlight_caps[bl_idx].max_input_signal) { > > > + DRM_INFO("amdgpu: backlight[%i]: overriding minimum brightness from %i to %i\n", > > > + bl_idx, > > > + dm->backlight_caps[bl_idx].min_input_signal, > > > + amdgpu_backlight_override_min[bl_idx]); > > > + dm->backlight_caps[bl_idx].min_input_signal = amdgpu_backlight_override_min[bl_idx]; > > > + } else { > > > + DRM_ERROR("amdgpu: backlight[%i]: minimum brightness override (%i) is not below maximum (%i)\n", > > > + bl_idx, > > > + amdgpu_backlight_override_min[bl_idx], > > > + dm->backlight_caps[bl_idx].max_input_signal); > > > + } > > > + } > > > } > > > > > > static int get_brightness_range(const struct amdgpu_dm_backlight_caps *caps, > > > > > > base-commit: d8c03bfe146fd5e081a252cd34f3f12ca0255357 > > > -- > > > 2.30.2 > > >