Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Oliver Graute <oliver.graute@kococonnector.com>
To:     Bo Liu <liubo03@inspur.com>
CC:     "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
        "michael@amarulasolutions.com" <michael@amarulasolutions.com>,
        "dario.binacchi@amarulasolutions.com" 
        <dario.binacchi@amarulasolutions.com>,
        "wsa+renesas@sang-engineering.com" <wsa+renesas@sang-engineering.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Input: edt-ft5x06 - replace DEFINE_SIMPLE_ATTRIBUTE with
 DEFINE_DEBUGFS_ATTRIBUTE
Thread-Topic: [PATCH] Input: edt-ft5x06 - replace DEFINE_SIMPLE_ATTRIBUTE with
 DEFINE_DEBUGFS_ATTRIBUTE
Thread-Index: AQHY7coQC9zJB9+CUkaELN80gM46ga4qNuWA
Date:   Tue, 1 Nov 2022 15:47:25 +0000
Message-ID: <A805401B-39FB-4575-8C2B-CC7343199869@kococonnector.com>
References: <20221101081458.8119-1-liubo03@inspur.com>
In-Reply-To: <20221101081458.8119-1-liubo03@inspur.com>
Accept-Language: de-DE, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DtKpty5sVj5SI+vUhQkhv+cGbTQCngQhVMOnnHwvuUhDP2QqVbYiGR+0L/IB?=
 =?us-ascii?Q?w2PUQUPLD1r1Dx4+NhSNFznwdQwSUk6bJXeyhe9+GhC2DqMAEgWF3t+cuQSs?=
 =?us-ascii?Q?qUDmp9wiNihcfGV6NKEDRr/GJ/GWtN9YpiEOcYcrv8cPfX6jKZRQkASbNdgo?=
 =?us-ascii?Q?U3ZZecU+C3vUyvZCC6SXDNyvSk35+P+f1t/1RZCH0A+3B5ZXZbaR4owWPm6M?=
 =?us-ascii?Q?jFFQ2F5BJN5b/VH8oByl5tJgNCDpm9ArequYf7TiFcuw5bXVSLg1BWIQ8KiI?=
 =?us-ascii?Q?e/+x6vdrNZfnA/OmujAIj+1vdSsagjyK6VdcKHzifSd7YdmftIEoiCAgaqPm?=
 =?us-ascii?Q?wNrpNCactt0AQI7U9YynjJhWn4KiAKGmf9dst1j9Om69G/BzdZZSuMfwnsMv?=
 =?us-ascii?Q?Ht4KhTV8b6o/aweclp6vs3SedSIIa4xlxgjwuTo7qoyUYrQDjW3efF/QZccG?=
 =?us-ascii?Q?P6RMl2zISiMjOWlZIIgoi0SxV8mc9oR//4W0uyouFaM43Esf/cYtaRpdOWB6?=
 =?us-ascii?Q?pZRWCp+mU8JKVCkszz9MoDTC9MDLwRQs9Py2lbS+d95lnZfzNzrH4pza2JKf?=
 =?us-ascii?Q?QobM3Ymy3LBFrZzj8Lwt+MmLWP3EzzMgKru2l96WHmaSEwWwm2kTsMx4O96B?=
 =?us-ascii?Q?nBVaOre7uf8TLvlYZtzZwlHV7Zw199xvw6bLnsVuXyndV2kubLx3V5geHmEj?=
 =?us-ascii?Q?DymQxfnDvqgbFNPXPj9O73RxnHU1grTKujawTMnpuxdLIahYOV7GbLMIiMrA?=
 =?us-ascii?Q?rdeZviehIFPtqNw5Aqx5lbPk3lXZgmR4JY43uQgQN+Q7epQwJo6IE5nZKP6v?=
 =?us-ascii?Q?2Q/WW9osbNDFUMuPL9zpyUxfA3fo6iFB4FswtRjGFfOtkc6cFN/ekHMelSDV?=
 =?us-ascii?Q?HzU94llrTt+M/A+WZuVTlm1MI1ZpTMekHCLw8il+AMfRXNh+OGkSqS2oJ4GL?=
 =?us-ascii?Q?Kh6mEqunecyMN4SU64svDxDDYnx4oHl1strhFDbQNigjDqgqs6Mp31YTunaJ?=
 =?us-ascii?Q?QDnkST1aXD98jAW0PTSppMPwCb/R2u8fatTGMXujMxwJrcpktUzjgXcaNk4p?=
 =?us-ascii?Q?hhi2L1911FRBSvtW7KTRj32aUfg+wO1U1qudOHDRUkId3x4is6g6XTJH7Qk7?=
 =?us-ascii?Q?DLOD1qk4EYiN1NACh43OMOAunuGq1wcLKr1GqJXfY+d1gr0Tj8AI+lUeE5s9?=
 =?us-ascii?Q?D8f//F/Jx1V5fyPSA8SHrbpxiaqR7JDbmvdPuWboTyZ7nP7jOtEc1iGNClEW?=
 =?us-ascii?Q?sJEYwliiPiFbjVDCKA+I/NoykF7Fe7NsYgnhIavZkiynuagwXqVU4UHgNMu4?=
 =?us-ascii?Q?O0hAPLKjdj1/pAHkNztbzV3pYjyNA8DkNJ1TGGdYR+U0FGINrzoZjyJs2PKv?=
 =?us-ascii?Q?xzK9LNbORwy+Xlu3ayqnU4WIEusi5wClCvupBjAOBrdhudoj6maBYZgzN862?=
 =?us-ascii?Q?LytAGv8L2nBusi3i5VofRWwY5ha/73fqnBeHUNS8G4bC42YsNxMhalpOBz/8?=
 =?us-ascii?Q?KR/nc4AsV9EdPxgpD6Nz1ugIJoL2azt0tkV4Va0/dwuUAeRQlKPXS/BJQMXB?=
 =?us-ascii?Q?QFPpqGfOlkosvoarng/dfK+7Yy8uPRP33B80u7Sna1jRfqzbbR1aEN+ordVp?=
 =?us-ascii?Q?cI30lSqoxaohQmaYMbXDCDI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <35133F2372318342B49978F052B74290@eurprd09.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: kococonnector.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR09MB4884.eurprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1affe05d-dd96-48cd-e3d9-08dabc205fc2
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2022 15:47:25.7772
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 59845429-0644-4099-bd7e-17fba65a2f2b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MXrxKeP6jfWEb63BcmnYSCuHA3Mt4SJnxISbKq/x5yl9O3tZoXltixunpmSLbyCRnsmAdkohsL5VaKYVHwsxsBbhBKOjXnr6I89YGTiiH7M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR09MB4431
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Am 01.11.2022 um 09:14 schrieb Bo Liu <liubo03@inspur.com>:
>=20
> Fix the following coccicheck warning:
>  drivers/input/touchscreen/edt-ft5x06.c:756:0-23: WARNING:
>    debugfs_mode_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE
>=20
> Signed-off-by: Bo Liu <liubo03@inspur.com>

Reviewed-by: Oliver Graute <oliver.graute@kococonnector.com>

> ---
> drivers/input/touchscreen/edt-ft5x06.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touch=
screen/edt-ft5x06.c
> index 9ac1378610bc..a184425b6985 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -753,7 +753,7 @@ static int edt_ft5x06_debugfs_mode_set(void *data, u6=
4 mode)
> 	return retval;
> };
>=20
> -DEFINE_SIMPLE_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get,
> +DEFINE_DEBUGFS_ATTRIBUTE(debugfs_mode_fops, edt_ft5x06_debugfs_mode_get,
> 			edt_ft5x06_debugfs_mode_set, "%llu\n");
>=20
> static ssize_t edt_ft5x06_debugfs_raw_data_read(struct file *file,
> --=20
> 2.27.0
>=20