Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp2694288rwi; Tue, 1 Nov 2022 10:33:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Tii+00Z4RjsMjyny4vZ4qO+WgLQAFPgjZijv74d8qsHgFe6YeL16SCCGJ1CRfYORUxYaQ X-Received: by 2002:a17:906:99c2:b0:7a8:c167:1d93 with SMTP id s2-20020a17090699c200b007a8c1671d93mr18500317ejn.490.1667324005958; Tue, 01 Nov 2022 10:33:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667324005; cv=none; d=google.com; s=arc-20160816; b=tTchdyhzWuvk/Q0nPGXq/dSRs/AVon7atw0wbrUYRG1j1rl6W0xmC/4o+9GWRl+SMS EmtqDfCy7DvrfhqngVuRV6ZUZUI6Gt/4oNXSlknvQlexHbc8O8//RgCRFCuqBEBsEv/R 2KKLEKfKZV60k6RsCO+iA8J75KXK/RcSa2sdt79s+sSnupDCcu1ZzTVd8crXs/xNKqSZ J9grvtsE7q7VwsqFcrh1RA1tSRAs0iDP5oKK/RelKpEO5AiPu9QATT1KpWWjfwTkQ5rh eUqZoQ4FOxspH1s9M2tEvtZ4f1CsgJ3N/nkzj2NjvY11mtpqN9/m7ZWHRJF77CePyhrF Jtcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=w6QuvmsH5BmRu4lDmsjS2B7I62RoetJ4/W78g/lBrBE=; b=tM2Ei6w3rKgAuyXvjtwIkMgcgXAlILbBor0vs4xEwU2me64ChrWrsp7mMHezQ9FzQo 7LtDej7YhkvbVJbkdsmyvOGgZnNAFzEy6mTKGg+/hX5YSirXLhmEHtP1CYwBqiwzNRuF /bBwLv61Hp1En3Xk6YPvuonjkFaC7cpK2FRaEl/C0Gr4TSHzshUOZautE+ld8eSJtj1R +dtYJjFI4Dk713IwjSQF0Z53z7RwyZtzD0k4MbiX5HKAwQnMAGSxw4Y+lmDldsO8/plR ZX3LdzD6wjRhGOGKOQSw/3bHo4n4tXJ9IVsgn1U2ba0dEcqJjtMlx8crV8DFdeTKNsnq InZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=r97rDMtt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc37-20020a1709078a2500b0078d00203ab2si13324646ejc.41.2022.11.01.10.33.02; Tue, 01 Nov 2022 10:33:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=r97rDMtt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229866AbiKARHN (ORCPT + 96 others); Tue, 1 Nov 2022 13:07:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbiKARHL (ORCPT ); Tue, 1 Nov 2022 13:07:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74431D8B; Tue, 1 Nov 2022 10:07:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1305C61689; Tue, 1 Nov 2022 17:07:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E3D9C433C1; Tue, 1 Nov 2022 17:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667322429; bh=zn7NZi96GnAH9OuevXZ3NMEyZN6iJDlWvNSmPLTGW0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r97rDMtthJKdqtKH95n7oyDI0R8m9qEkCEYiB5MWfj6uRGkeP5e5x7Wkm6F3Q1Bj5 HOr8WiN9k3OvLnhimeaU+TMfo4zit7uOCFh4COuqw32ib9AJ/x7i4GOjltnCIHBCG+ Zxo7grs5xItH28LbKpVVWhvlJbDqSGu/d+jEl1M4= Date: Tue, 1 Nov 2022 18:08:01 +0100 From: Greg KH To: Naresh Kamboju Cc: Nathan Chancellor , Oleksandr Tymoshenko , christophe.leroy@csgroup.eu, davem@davemloft.net, edumazet@google.com, linux-kernel@vger.kernel.org, sashal@kernel.org, stable@vger.kernel.org, w@1wt.eu, llvm@lists.linux.dev Subject: Re: [PATCH 5.4 086/255] once: add DO_ONCE_SLOW() for sleepable contexts Message-ID: References: <20221024113005.376059449@linuxfoundation.org> <20221029011211.4049810-1-ovt@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 01, 2022 at 09:42:12PM +0530, Naresh Kamboju wrote: > Hi Greg, > > On Tue, 1 Nov 2022 at 11:55, Greg KH wrote: > > > > On Tue, Nov 01, 2022 at 05:48:29AM +0100, Greg KH wrote: > > > On Mon, Oct 31, 2022 at 11:27:21AM -0700, Nathan Chancellor wrote: > > > > Hi Oleksandr, > > > > > > > > On Sat, Oct 29, 2022 at 01:12:11AM +0000, Oleksandr Tymoshenko wrote: > > > > > Hello, > > > > > > > > > > This commit causes the following panic in kernel built with clang > > > > > (GCC build is not affected): > > > > > > > > > > [ 8.320308] BUG: unable to handle page fault for address: ffffffff97216c6a [26/4066] > > > > > [ 8.330029] #PF: supervisor write access in kernel mode > > > > > [ 8.337263] #PF: error_code(0x0003) - permissions violation > > > > > [ 8.344816] PGD 12e816067 P4D 12e816067 PUD 12e817063 PMD 800000012e2001e1 > > > > > [ 8.354337] Oops: 0003 [#1] SMP PTI > > > > > [ 8.359178] CPU: 2 PID: 437 Comm: curl Not tainted 5.4.220 #15 > > > > > [ 8.367241] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 0.0.0 02/06/2015 > > > > > [ 8.378529] RIP: 0010:__do_once_slow_done+0xf/0xa0 > > > > > [ 8.384962] Code: 1b 84 db 74 0c 48 c7 c7 80 ce 8d 97 e8 fa e9 4a 00 84 db 0f 94 c0 5b 5d c3 66 90 55 48 89 e5 41 57 41 56 > > > > > 53 49 89 d7 49 89 f6 07 01 48 c7 c7 80 ce 8d 97 e8 d2 e9 4a 00 48 8b 3d 9b de c9 00 > > > > > [ 8.409066] RSP: 0018:ffffb764c02d3c90 EFLAGS: 00010246 > > > > > [ 8.415697] RAX: 4f51d3d06bc94000 RBX: d474b86ddf7162eb RCX: 000000007229b1d6 > > > > > [ 8.424805] RDX: 0000000000000000 RSI: ffffffff9791b4a0 RDI: ffffffff97216c6a > > > > > [ 8.434108] RBP: ffffb764c02d3ca8 R08: 0e81c130f1159fc1 R09: 1d19d60ce0b52c77 > > > > > [ 8.443408] R10: 8ea59218e6892b1f R11: d5260237a3c1e35c R12: ffff9c3dadd42600 > > > > > [ 8.452468] R13: ffffffff97910f80 R14: ffffffff9791b4a0 R15: 0000000000000000 > > > > > [ 8.461416] FS: 00007eff855b40c0(0000) GS:ffff9c3db7a80000(0000) knlGS:0000000000000000 > > > > > [ 8.471632] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > > > [ 8.478763] CR2: ffffffff97216c6a CR3: 000000022ded0000 CR4: 00000000000006a0 > > > > > [ 8.487789] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > > > [ 8.496684] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > > > [ 8.505443] Call Trace: > > > > > [ 8.508568] __inet_hash_connect+0x523/0x530 > > > > > [ 8.513839] ? inet_hash_connect+0x50/0x50 > > > > > [ 8.518818] ? secure_ipv4_port_ephemeral+0x69/0xe0 > > > > > [ 8.525003] tcp_v4_connect+0x2c5/0x410 > > > > > [ 8.529858] __inet_stream_connect+0xd7/0x360 > > > > > [ 8.535329] ? _raw_spin_unlock+0xe/0x10 > > > > > ... skipped ... > > > > > > > > > > > > > > > The root cause is the difference in __section macro semantics between 5.4 and > > > > > later LTS releases. On 5.4 it stringifies the argument so the ___done > > > > > symbol is created in a bogus section ".data.once", with double quotes: > > > > > > > > > > % readelf -S vmlinux | grep data.once > > > > > [ 5] ".data.once" PROGBITS ffffffff82216c6a 01416c6a > > > > > > > > Thanks for the report! The reason this does not happen in mainline is > > > > due to commit 33def8498fdd ("treewide: Convert macro and uses of > > > > __section(foo) to __section("foo")"), which came as a result of these > > > > issues: > > > > > > > > https://github.com/ClangBuiltLinux/linux/issues/619 > > > > https://llvm.org/pr42950 > > > > > > > > To keep stable from diverging, it would probably be best to pick > > > > 33def8498fdd and fight through whatever conflicts there are. If that is > > > > not a suitable solution, the next best thing would be to remove the > > > > quotes like was done in commit bfafddd8de42 ("include/linux/compiler.h: > > > > fix Oops for Clang-compiled kernels") for all instances of > > > > __section(...) or __attribute__((__section__(...))), which should > > > > resolve the specific problem you are seeing. > > > > > > I think we should do the latter, fighting with all of the different > > > section entries would be a pain. > > > > > > Unless someone beats me to it, I'll go make up a patch for this... > > > > Can someone test the following patch: > > I have tested the following patch and confirmed that reported issues > have been fixed. The test performed on 5.4 with patch applied and > built with clang-nightly and ran the LTP CVE (cve-2018-9568 ) connect02 > test case on qemu-x86-64. Thanks for testing. But how did this get through the original testing? I didn't see any reports of this being an issue until after the release. What went wrong with our testing frameworks? thanks, greg k-h