Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Nov 2022 14:27:08 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Long Li <longli@microsoft.com>
Cc:     KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Leon Romanovsky <leon@kernel.org>,
        "edumazet@google.com" <edumazet@google.com>,
        "shiraz.saleem@intel.com" <shiraz.saleem@intel.com>,
        Ajay Sharma <sharmaajay@microsoft.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [Patch v9 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure
 Network Adapter
Message-ID: <Y2FW7Ba/krWc4nwP@nvidia.com>
References: <1666396889-31288-1-git-send-email-longli@linuxonhyperv.com>
 <1666396889-31288-13-git-send-email-longli@linuxonhyperv.com>
 <Y1wO27F3OVqre/iM@nvidia.com>
 <PH7PR21MB3263C4980C0A8AF204B68F1FCE379@PH7PR21MB3263.namprd21.prod.outlook.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PH7PR21MB3263C4980C0A8AF204B68F1FCE379@PH7PR21MB3263.namprd21.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SFb5Ba8lXwHICKGOlt+0xIk5oUDbW9ese3CBqVLaXmoUec+FzQIykFjbzzik?=
 =?us-ascii?Q?BIDFHDnqKXwFcwUsat60+F1+6Q974Z0qNm4OgTZnUrA3OE6rvUGMDUGXKpWn?=
 =?us-ascii?Q?gAyP5rFtkxWecuRQ9G57rooQe2+CPCr8Yqn9x7z56VAU6E4BQpVN1uYsoA5a?=
 =?us-ascii?Q?srCGwTL/670+EllGNV5iKhjAnxuKsKvegqTWnz1qxySGufqlubG7HT+IEVup?=
 =?us-ascii?Q?GnB5IlFM72UwMqVpKGDxReWwHJoMe3OVoO8aHd+qqLT39zHx4ZwiESFxcWub?=
 =?us-ascii?Q?9MkmTG8WUQR4pZy6v6rMlAQ6fxnbQk5JfjzMxFusTH+27cBJqBSXrbV1i73g?=
 =?us-ascii?Q?mzNHSe3w4kCVRXsLQULD7oqzTyHn9VmyWSCV4y7TAxQkldyKwX2eFZJXGast?=
 =?us-ascii?Q?CX1SMTIIOgjKeBbqA7GeA6O7K+AqjJOI7dDS2ifwtKtqdSyM7W1C3wjFEGZR?=
 =?us-ascii?Q?2FyfK8gMvgcM0E0NdLGDw4/vlHEYnI2rx16YA5O8i4jkS1gW6yhdfhYzY047?=
 =?us-ascii?Q?jJacIB6j9ngbQV9aACXBnputAggEqkESC+bJ0PgXA5qbLuAz9tTCgvP31pyx?=
 =?us-ascii?Q?4Ps1N5ifMPS93Z95/RHd/DuRzFg/BbNTRH2AlXLkU7uVK2VoMepwQK7ZcLX4?=
 =?us-ascii?Q?mfDXINqYFemFKmBgxyNE03EqO1ZV+fJ8/EiICiMuO6B53mcbTL++y/w88m0i?=
 =?us-ascii?Q?pMOSqTq9U0g3sT7uolO33n2IUeJmZ36bibgLHMYCNDbN5uBdWU+IuVYmBvfJ?=
 =?us-ascii?Q?JM5TKypQTfgG67uAbH7hUBwfDnP+6hjiiaqSxCKiYOKiZeI5DCIEN7wzL4TU?=
 =?us-ascii?Q?0KSWavxHgw3WBLqOYtTysOsSgOrFe/XUNsxjjfvR30gJUPBLV3/D2zf6MFaX?=
 =?us-ascii?Q?pR9jxPYZVLYhdBRdetH+NKp2c8c8VwF73FYuXNHe932pjgsbyxE+nUyPE2MH?=
 =?us-ascii?Q?WV3cn1+890P9tM4p8VH7HkX8c9vo1XFIDdue7qz9ezEpMMQAzabqgCl6S+BL?=
 =?us-ascii?Q?iXn5mFP31QQcL5iOylgtZH6L3EFNZ9PKPCLgbrFlu2LbvJyyhE494uUFQkxk?=
 =?us-ascii?Q?TKx73Td8ffMzaH1/pwHycMt1DWQJKsKeGJdaF937M/JyCdudhVZMPLvaJbOx?=
 =?us-ascii?Q?cbssbUNdkUo7dypW/nq+YhvJdIrzDkpXi/ec5xEMSUlEt4Uc7nLbrkzAQPRH?=
 =?us-ascii?Q?8F7nCX4ebQuYuxaVz2yr64MLIOowzu5PASkDwAOgFYqW3FIGmr0vGHwmOlKd?=
 =?us-ascii?Q?/ZRBUYNlqJmlayAP6uKi8OyVJALPyij7LDNTf5O6/PARA4Vy4Giph1KxtBid?=
 =?us-ascii?Q?iMdp+HxB+AjYKMsJtaT20ixwiYFEgGzVoRg9ex07pIu0fG3GTpQexIFTXVQR?=
 =?us-ascii?Q?z+Gn6Afn2unew8jONpzTQtNut9bHvQTDcLE9gKlB+LsBfFtwtl5TEU8SttGi?=
 =?us-ascii?Q?FW+HAggVio0nS387FRPgq/qqwXUgbXgeuFEwm2c4VW78t8UP2hTREimfbmHe?=
 =?us-ascii?Q?6EYMmhAGcR53NJH6p4nun7g8MOEeuuYeFaSL7cQKfbVMJmOu+NuYU7gy4eoQ?=
 =?us-ascii?Q?dwFi3M/igxUQFxCKBU8=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 306fad81-116d-4fca-c4c6-08dabc2e4e44
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 17:27:09.5868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Z29LbiD+8Bxkav0PCxWVI7Y/W7DNZKWi0OM/Q9q3w5zJxCpSlF59vEc3cuidRrdc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5809
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 31, 2022 at 07:32:24PM +0000, Long Li wrote:
> 
>         page_addr_list = create_req->page_addr_list;
>         rdma_umem_for_each_dma_block(umem, &biter, page_sz) {
>                 page_addr_list[tail++] = rdma_block_iter_dma_address(&biter);
>                 if (tail >= num_pages_to_handle) {

if (tail <= num_pages_to_handle)
   continue


And remove a level of indentation

>                         u32 expected_s = 0;
> 
>                         if (num_pages_processed &&
>                             num_pages_processed + num_pages_to_handle <
>                                 num_pages_total) {
>                                 /* Status indicating more pages are needed */
>                                 expected_s = GDMA_STATUS_MORE_ENTRIES;
>                         }
> 
>                         if (!num_pages_processed) {
>                                 /* First message */
>                                 err = mana_ib_gd_first_dma_region(dev, gc,
>                                                                   create_req,
>                                                                   tail,
>                                                                   gdma_region);
>                                 if (err)
>                                         goto out;
> 
>                                 page_addr_list = add_req->page_addr_list;
>                         } else {
>                                 err = mana_ib_gd_add_dma_region(dev, gc,
>                                                                 add_req, tail,
>                                                                 expected_s);
>                                 if (err) {
>                                         tail = 0;
>                                         break;
>                                 }
>                         }
> 
>                         num_pages_processed += tail;
> 
>                         /* Prepare to send ADD_PAGE requests */
>                         num_pages_to_handle =
>                                 min_t(size_t,
>                                       num_pages_total - num_pages_processed,
>                                       max_pgs_add_cmd);
> 
>                         tail = 0;
>                 }
>         }
> 
>         if (tail) {
>                 if (!num_pages_processed) {
>                         err = mana_ib_gd_first_dma_region(dev, gc, create_req,
>                                                           tail, gdma_region);
>                         if (err)
>                                 goto out;
>                 } else {
>                         err = mana_ib_gd_add_dma_region(dev, gc, add_req,
>                                                         tail, 0);
>                 }
>         }

Usually this can be folded above by having the first if not continue
if the end of the list is reached.

Anyhow, this is much better

Thanks,
Jason