Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp2744874rwi; Tue, 1 Nov 2022 11:11:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6qdvHwKIKVAGckq0sbYufSSnTGPrd8wkwB31LgIwmYi1lc4ZhYc015m8SrpTDaKnyS8YcA X-Received: by 2002:a17:902:ef47:b0:179:d18e:4262 with SMTP id e7-20020a170902ef4700b00179d18e4262mr20400294plx.22.1667326285867; Tue, 01 Nov 2022 11:11:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667326285; cv=none; d=google.com; s=arc-20160816; b=OAIofFTi6qF9rase6LB9+InecCqmXAqdxn/qFl05y31dpyBsxpOl0cUv8nvofpxCgs b/igQd7zui/CzXD9Dsnz1BcssU14ZMt7ZtWZw5oUq3NJgrR4kDYBZDv6MnbdOo33UPXF JtivuCdfLBpfBhtnietjD56oJYxXR0ENVjU3rvUMUtEfGL5aGCrIHBbQSqqh2tn7XZ/p GJOjUcSaXmuQbDSs/whJqp3RCkYhqRQQF7F75oH5lTrmxSyOqKOt0D49Bk4qLhxiLzBt rSNKcfZDMNF5zA5q3jCE+eswkFzmWVs7qZsIF0oxusyLaaGB7W3AQxvs+E823DgUYJ3S vKzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=uRpkPP1UpZBawLsAH/DW7PL2qoXlQElHM2KUhbmuHTM=; b=iv509tzzw/CMB29Wa74iq7/FC68vNrrmCRuaiBBUmwkGcr2YwBpP7HumnBo8kdjcCZ +1alxUuY8lCdtGY/RonXiYq0cX5lZaRrtXwyNpumjj68sVTIpkXqiZInNDJ8tb6Lnjiv m/OnpKmObHjjBInjmV65CAc9TO5RJ7j6Um6L/j0YWivS/udQ44S2K06sx5DKyxnED9gl O04UWanty4z+8Yarx61HBEQfAKlucGqqKew5NxLg6uKcOCpz9PEQWXf7M91gNss7EEDm PhajYl3RUFrWA4NDqXKYdE9Yzy2Op8kMGP3KkiuyGq+JhXSJ/A8rGsfcGSP6OLf3306f dzGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 84-20020a630257000000b004227041e9d2si13420727pgc.405.2022.11.01.11.11.13; Tue, 01 Nov 2022 11:11:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231187AbiKAReV (ORCPT + 96 others); Tue, 1 Nov 2022 13:34:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230273AbiKAReH (ORCPT ); Tue, 1 Nov 2022 13:34:07 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0369922C; Tue, 1 Nov 2022 10:34:06 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 757206732D; Tue, 1 Nov 2022 18:34:01 +0100 (CET) Date: Tue, 1 Nov 2022 18:34:01 +0100 From: Christoph Hellwig To: Jinlong Chen Cc: axboe@kernel.dk, hch@lst.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] blk-mq: improve error handling in blk_mq_alloc_rq_map() Message-ID: <20221101173401.GA20690@lst.de> References: <992db53bdeaba35d37de3784fe6f80879c9bbb35.1667314759.git.nickyc975@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <992db53bdeaba35d37de3784fe6f80879c9bbb35.1667314759.git.nickyc975@zju.edu.cn> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > if (!tags) > - return NULL; > + goto err_out; Using a label just for the direct error return here is a bit silly. The rest looks fine.