Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Nov 2022 17:22:13 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        Smita.KoralahalliChannabasappa@amd.com, mchehab@kernel.org,
        tony.luck@intel.com, james.morse@arm.com, rric@kernel.org
Subject: Re: [PATCH] EDAC/mc_sysfs: Increase legacy channel support to 12
Message-ID: <Y2FVxWXnleYkkTGL@yaz-fattaah>
References: <20221018153630.14664-1-yazen.ghannam@amd.com>
 <Y1+i5GvygCVfiCGx@zn.tnic>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y1+i5GvygCVfiCGx@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CAMubdKnuVhklOcgH5cywBI1Xr3ULUiLvF4eN7QJdKV0fKzM47Spe5lN6ov1?=
 =?us-ascii?Q?OL+Ok03irmL3KQz43xRqneWVx1cIa7nj8rB4tniCLJ5bEZvl3trCeo7Bq8KR?=
 =?us-ascii?Q?ctGeBJab8i47yKV0Vh5CK7xZYz9ZeckEYQUh7mylcI5khGt5Y64Y5TY5kckH?=
 =?us-ascii?Q?cpMWFB6NjLs2rtNscXxVZG+lMB23P26EFS4oqqDkvc1BONEnp3pfsUP+vbZ3?=
 =?us-ascii?Q?iMSIVniaOJUNW8GmrcfxOdAC/0NSK9wYNjdLypClBViiGv5TNKGT3+XTgMVR?=
 =?us-ascii?Q?TXideG0PkmmNoN9kc+jcdmvZY7NPrQKIFGzBTTq/Wy/w0EQCBn5zElPF54kK?=
 =?us-ascii?Q?r0Gm7g2vYPhF7ZCvzuG7NXVFKOWt0WBqUxPa6/4CDF0Rt9SvYps1rORRbh9k?=
 =?us-ascii?Q?k1I8KKqJNsWkxM2YeXhtJWJv3RXNbS7Ac9k1t/hmJWdX6oYTXGUCsteAhn2Q?=
 =?us-ascii?Q?4HnEi0/6zVh85TA9ByBTLB+AOFXQmyZXFsOvaKzMRF4YKB+I1CN4e6RmaIfS?=
 =?us-ascii?Q?D2YVFgjaH3EVmmDZ2edSN+dMb3CddHcWYbOOWtPukY29ubfSXGZyV3nmFf2Y?=
 =?us-ascii?Q?YQA95x+pN2/DmWSdC5Q2kmZ9Qj5nvE94el8cuWbzTntHKA7h3wADJDkHMwM9?=
 =?us-ascii?Q?HNPuQhzHDKlGZoUrK6I0Up2QQAEHDLaD/sq9Lp883cOazxklF/VOuYaXO/Pg?=
 =?us-ascii?Q?Mmb0uLoB+m1DJqLXjeeOd4TpLdiu1iaYfDtPLuRdkunS30CBO0oPHM0yGug5?=
 =?us-ascii?Q?wSYra0dtFQq6xXrBgso9qrsvURY0LwS8EQfCX0rlZF4nM7qegrnP0OYettKD?=
 =?us-ascii?Q?ydEp0WPMZS/382nQhMBQ0S0ssvC0jVNbxPCrZHFA2fP0jYSnI+WxVTJyz82C?=
 =?us-ascii?Q?TuFCa5rC2+WjrynOLvUE3ShE3S6lr1CnL7ibtmWgbSytvkcYI8cCEu20Eyx0?=
 =?us-ascii?Q?bY86vpmDZlZsP5t2k0p9DENuJsMe5fj86pSEGj2Ra7MZ/soVrVyw8cO1mPIS?=
 =?us-ascii?Q?BeZLJqmfM2LM9kOXUVsD6sub6oPyK6YXoZXgadcBlFpv+/pzuPyyAVDWldda?=
 =?us-ascii?Q?OBrtJsQcQ1GegN3Iq7g+4ZTiYiVSVr1aSeBCTm928uP2U4kq09YrLONMNH2B?=
 =?us-ascii?Q?/fjD4I6JSqCUGXwr7fB0K4iRZdqpuIMTM1UfRIn4R1YSU1XaVeNWDhQQ+kQA?=
 =?us-ascii?Q?E2fx/D9bKFobPy9f6KRVKZRWwKD3RWQvCez8geZ9dbfnOFEvLgDd0DzUFC9v?=
 =?us-ascii?Q?ILxWmD/lrgfVPhAQ66OEDH9+l1Q7b9/juabQiGQz7dfhT5ZCkZhLU0OM3stw?=
 =?us-ascii?Q?ae/uzFd8x8xbTADM4+7BRvrBzhEj4Ib0GqWIXMaVBzCksIW52q3ukTYMxPS+?=
 =?us-ascii?Q?l9gyuANRtt09dIieq7NMrToOOCMP/ZpUfbS8e+3f1jD3mzzQXohOOZxaJJCn?=
 =?us-ascii?Q?MVD26Vi+TdhirSLvwwTsOy2G4AYsuRBroIr62TAiJujleQjAp5zt5PJt+1uY?=
 =?us-ascii?Q?fxNDDwPAgaX1AORQmkVuriW1BexO+qsVwSkJFZqoMJCOAn4g1bhTiIdgNmXk?=
 =?us-ascii?Q?YsKyC656NHerTs7NLnS2exeUf54mWy/sePpZviB3?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 498da115-eaa6-449e-e9bb-08dabc2d9fda
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 17:22:17.0164
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uhB9494S5MK5dZ3kIQw5xUlTsC0uRzcvRDbZwFfvH9iZk44H/3wU8vnLoFYfBBJn+vTTXzzfUv9GABH2PXSbig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5491
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Oct 31, 2022 at 11:26:44AM +0100, Borislav Petkov wrote:
> On Tue, Oct 18, 2022 at 10:36:30AM -0500, Yazen Ghannam wrote:
> > Newer AMD systems, such as Genoa, can support up to 12 channels per EDAC
> > "mc" device. These are detected by the device's EDAC module, and the
> > current EDAC interface is properly enumerated. However, the legacy EDAC
> > sysfs interface provides device attributes only for channels 0 to 7.
> > Therefore, channels 8 to 11 will not be visible in the legacy interface.
> > This was overlooked in the initial support for AMD Genoa.
> > 
> > Add additional device attributes so that up to 12 channels are visible
> > in the legacy EDAC sysfs interface.
> > 
> > Ignore checkpatch warnings about "Symbolic permissions" to maintain
> > coding style.
> > 
> > Fixes: e2be5955a886 ("EDAC/amd64: Add support for AMD Family 19h Models 10h-1Fh and A0h-AFh")
> > Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
> > Cc: <stable@vger.kernel.org>
> > ---
> >  drivers/edac/edac_mc_sysfs.c | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> 
> Applied, thanks.
>

Thank you!

-Yazen