Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp2783357rwi; Tue, 1 Nov 2022 11:40:48 -0700 (PDT) X-Google-Smtp-Source: AMsMyM60cZISmoclRfCe566rTP3N9QE8LBD/bNdbFIs6wTg5WTvGtyATHL+cVVVPGIGobD8EtmnB X-Received: by 2002:a17:902:d4ce:b0:186:c8b9:c301 with SMTP id o14-20020a170902d4ce00b00186c8b9c301mr20925627plg.27.1667328048598; Tue, 01 Nov 2022 11:40:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667328048; cv=none; d=google.com; s=arc-20160816; b=a8HOi9viNbVdf8efK1c+nj4Ls3EJxvWCP8O+RHRyLdDGb1HuJi70flsWGU9LL0tBUR BTo54ymPq5mnSgVE7NJGVwL7gb8UOHXY6e6jepinkF2opEurzQ4qjno2P5qSCsoYnvlS Ie3wYh3jLJ4miKiP2nkTos/baCl5mpEn6uC0lpcDd8lKz9fP02QEgsplv7P4feGTKM6X bB1+2U//J7sdbk7bLBtXbqNL3cXqkxASenj6NW/n10SQ5AK+fcmaORsRUW0NFyPtabsW ulRkBVwE9dxzPNgC1XRkLeZ8pA+svh/VGB9FSWpEmzrVthGKQQn9yfh9yAAMqFzoD4ow LH6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=2yIMEyIdM9BFDMzy8xupZjUmRK55OQN/jxJjTBfmY5U=; b=gjPdJh8HyLBzOl4gmDl9IFRVXNS0MUnxO4XoZEFLD24sODaJgAoO69C5GqhgGV3g3+ y+zY7MqoEGFqsMrzRil8mOWGwcS8MNormESNBZ2tjz60yN7p1yXalSYL2jWcYrtRQl1d f+vL5lv5o06c2smUMo5KlnoCQ6/727V0H7jpFckR/6ErVFGWOGmV4cew3WPsSrHM01RO jDkdjUiK3cLtVAO+48gU4JvnvlhyriPAP+p15osVJSsXX722SUpU2wq4VBPhVzk2YPC9 Xr/Nwui26PfT5yskSaPAQZzjudPQ/uKsc2tOQ9Zj0Dhk7SAeiJa8PZMy6TuSNjIsQJ2H 41lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=byGLyGcJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fu2-20020a17090ad18200b0020ab20c54fesi11423651pjb.114.2022.11.01.11.40.34; Tue, 01 Nov 2022 11:40:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=byGLyGcJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230046AbiKASTF (ORCPT + 96 others); Tue, 1 Nov 2022 14:19:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbiKASTD (ORCPT ); Tue, 1 Nov 2022 14:19:03 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36744272E for ; Tue, 1 Nov 2022 11:19:01 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id p184so13019771iof.11 for ; Tue, 01 Nov 2022 11:19:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2yIMEyIdM9BFDMzy8xupZjUmRK55OQN/jxJjTBfmY5U=; b=byGLyGcJKLOMhhsYAQFyqJgNnvmQuTaMJQnsrFQK//IAZfxxe+xgXEs+28NOOOYHHH P3N1E7F8M5Qg1/BsI4pmCP49cuq6ySdvXOMOHoWE1E5wS81OUbvo9uRZyL31R2zHRHp4 lqh1Se/P+OPv+OlJ8BHfH3YNvIi/j6Yj0GfMA2/pY1j28kb0EbyxGQNfr9LCP0gIx/i4 6GAXOXVkQssZuJ7+Fd4EKtfhXm4HKZz6uTB4zGzozInOGnx6fM4lxvbDbTBnXu6qrJlo 0HcGlZI2DmfGX3Pfi8+9F39NPJFrRbvbKlfztyNk60Ng5aE1Ex0uyLrVrYignOIwK6VA Mv5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2yIMEyIdM9BFDMzy8xupZjUmRK55OQN/jxJjTBfmY5U=; b=uke/CKqgRGUtiw3Iea4E6bpfS2ENx4Zo1vX+SYme4yuZ4yhji8R47gq5thfhxnTtxp dO5tRNd6Vl6DrBmEQQQTtp/QzvMQzeOYp7adYvQBh7AakkqluYn8esX2FK4JzNRQewp1 UPzb+IOMen6xKS9GvmZKAfn6QHfsAlCK/5iDXpIsghqxI2GfGkoWLJRSujLdskTR2hKo oGAFUTiIw6zCjhu7vsxGC0aM4CoBY0HSxNXs3GsbCjfVfwAKiDAb4lcjk0kMuqNeFk0J oo+eO0GCF4n1AltX48jVALNiThJdzsr2Bvw+CsA94H7slog6+K+d/mGU+whI/quybW9v 067w== X-Gm-Message-State: ACrzQf2jOu+pft2rbi6BYk0M+vvfxz47dcoLHhtgxC40sSCuMsaLDSFH C6Ajrp38kwXpd8cGFENTLW696Q== X-Received: by 2002:a6b:ba8a:0:b0:6d3:c907:63c3 with SMTP id k132-20020a6bba8a000000b006d3c90763c3mr1750723iof.15.1667326740519; Tue, 01 Nov 2022 11:19:00 -0700 (PDT) Received: from [192.168.1.94] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id bg3-20020a0566383c4300b00375217ea9b6sm4108469jab.45.2022.11.01.11.18.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 11:18:59 -0700 (PDT) Message-ID: <37138d05-c2b2-a106-416c-6be134d94046@kernel.dk> Date: Tue, 1 Nov 2022 12:18:58 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH 2/4] blk-mq: improve error handling in blk_mq_alloc_rq_map() Content-Language: en-US To: Christoph Hellwig , Jinlong Chen Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <992db53bdeaba35d37de3784fe6f80879c9bbb35.1667314759.git.nickyc975@zju.edu.cn> <20221101173401.GA20690@lst.de> From: Jens Axboe In-Reply-To: <20221101173401.GA20690@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/1/22 11:34 AM, Christoph Hellwig wrote: >> if (!tags) >> - return NULL; >> + goto err_out; > > Using a label just for the direct error return here is a bit silly. Plus that's not idiomatic code for cleanup, just keep the NULL return if there's no cleanup to be done. -- Jens Axboe