Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4929fc7f-eb31-6ee4-0365-1b0f61ad5946@schaufler-ca.com>
Date:   Tue, 1 Nov 2022 14:12:56 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH 1/1] smack_lsm: remove unnecessary type casting
Content-Language: en-US
To:     XU pengfei <xupengfei@nfschina.com>, paul@paul-moore.com,
        jmorris@namei.org, serge@hallyn.com
Cc:     linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, casey@schaufler-ca.com
References: <20221026082923.3400-1-xupengfei@nfschina.com>
From:   Casey Schaufler <casey@schaufler-ca.com>
In-Reply-To: <20221026082923.3400-1-xupengfei@nfschina.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/26/2022 1:29 AM, XU pengfei wrote:
> Remove unnecessary type casting.
> The type of inode variable is struct inode *, so no type casting required.
>
> Signed-off-by: XU pengfei <xupengfei@nfschina.com>

Thank you. Added to smack-next:
	https://github.com/cschaufler/smack-next.git#next

> ---
>  security/smack/smack_lsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index b6306d71c908..853c6878edc0 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -1409,7 +1409,7 @@ static int smack_inode_getsecurity(struct user_namespace *mnt_userns,
>  	struct socket_smack *ssp;
>  	struct socket *sock;
>  	struct super_block *sbp;
> -	struct inode *ip = (struct inode *)inode;
> +	struct inode *ip = inode;
>  	struct smack_known *isp;
>  
>  	if (strcmp(name, XATTR_SMACK_SUFFIX) == 0)