Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Nov 2022 22:52:36 +0100
From:   Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To:     Angel Iglesias <ang.iglesiasg@gmail.com>
Cc:     linux-iio@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Nuno =?utf-8?B?U8Oh?= <noname.nuno@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Paul Cercueil <paul@crapouillou.net>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] iio: pressure: bmp280: convert to i2c's
 .probe_new()
Message-ID: <20221101215236.ihoqkx2xckilom67@pengutronix.de>
References: <cover.1667151588.git.ang.iglesiasg@gmail.com>
 <af8ed10a85d48531c50823163e6c55b2a72371ef.1667151588.git.ang.iglesiasg@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="7pjkg57m7im34odb"
Content-Disposition: inline
In-Reply-To: <af8ed10a85d48531c50823163e6c55b2a72371ef.1667151588.git.ang.iglesiasg@gmail.com>
Precedence: bulk


--7pjkg57m7im34odb
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Sun, Oct 30, 2022 at 06:53:11PM +0100, Angel Iglesias wrote:
> Use i2c_client_get_device_id() to get the i2c_device_id* parameter in the
> .new_probe() callback.
>=20
> Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> ---
>  drivers/iio/pressure/bmp280-i2c.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/iio/pressure/bmp280-i2c.c b/drivers/iio/pressure/bmp=
280-i2c.c
> index 0c27211f3ea0..20073b09b3e3 100644
> --- a/drivers/iio/pressure/bmp280-i2c.c
> +++ b/drivers/iio/pressure/bmp280-i2c.c
> @@ -5,11 +5,11 @@
> =20
>  #include "bmp280.h"
> =20
> -static int bmp280_i2c_probe(struct i2c_client *client,
> -			    const struct i2c_device_id *id)
> +static int bmp280_i2c_probe(struct i2c_client *client)
>  {
> -	struct regmap *regmap;
> +	const struct i2c_device_id *id =3D i2c_client_get_device_id(client);
>  	const struct regmap_config *regmap_config;
> +	struct regmap *regmap;
> =20
>  	switch (id->driver_data) {
>  	case BMP180_CHIP_ID:

What is the motivation for moving regmap? I thought reverse christmas
tree is only a thing in network code? I would have left the regmap
declaration where it is.

> @@ -65,7 +65,7 @@ static struct i2c_driver bmp280_i2c_driver =3D {
>  		.of_match_table =3D bmp280_of_i2c_match,
>  		.pm =3D pm_ptr(&bmp280_dev_pm_ops),
>  	},
> -	.probe		=3D bmp280_i2c_probe,
> +	.probe_new	=3D bmp280_i2c_probe,
>  	.id_table	=3D bmp280_i2c_id,
>  };
>  module_i2c_driver(bmp280_i2c_driver);

Best regards
Uwe

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--7pjkg57m7im34odb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmNhlSEACgkQwfwUeK3K
7AmT1Qf/crN47+a7Fx3l82hw5q8rL/w8pRU6kiS3TE59qc8syW0rcWMQgkJM3war
fWXMV3f7AHRpEAqyLi3b90ZGAdRE6XbN0iOHl+/BHHYoafGA/MsJ7E9Dzf9bEUVp
NhegFgleuMS0S7CgZzVHFPummi3yKkK84/lhytfaNteHLfFpuTUoiAzh5/2OYfYn
zC1dVEet/pwoicDvayDqD9hBAQKZ6SDY3V34+Il1FqU8UAsV36EzCtSJfydctliy
8eZLpJ7/TmMSVnHRIwJ8l28e9PgqaN0ZO1jF6olr8WVZ82HrBErvHT36RFB+cVuu
O6byR1+2UmY5v4yFJMfNDejqbzS0Sg==
=2U3q
-----END PGP SIGNATURE-----

--7pjkg57m7im34odb--