Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp3064227rwi; Tue, 1 Nov 2022 15:33:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4kcI1rP+2g2IAJ9q905lOCR03bnyz//hd6HlYug1QB6V0VWOijc4ces7IFyugdcmYeGbVq X-Received: by 2002:a17:907:3f26:b0:78d:9c30:4529 with SMTP id hq38-20020a1709073f2600b0078d9c304529mr20281254ejc.195.1667342021239; Tue, 01 Nov 2022 15:33:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667342021; cv=none; d=google.com; s=arc-20160816; b=TSvYkHqAYXWPRAVXWbC6NjMQxsu1KRErc43rBm6XWjNuHdK1nSff0PCqGCrtkmF7pV ljU/D2HwgumOwozOz6IG5YJgMRl+rZ75bvS6nZC7R5B5wAzWmvWgkSoPp0GkgPayERfy YmhwQ8G5Ze9FsNXnopu6JwqoiHFQE6O9x5r4dNrtBphOWoU2JloNcqkzKyNPE5iSj7JD 2rMi6c9kwetYe4N/jqvBku79m8vEpL5+lk37iwNoLx8fkKZqs2W7Yj8ZrbC+gOIYVHg2 eT3RjnRPCSRoO64QC/N3erQ7Ygvmbg8WWcPvSY4y6Z5oE56hl2Wzh7b+zHwfnSqtVuiz 964w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=+Tj6LMlid1xqeP/OugEx6eshEoLxwhpJ2MaPH/4J8sc=; b=J9yKqijbhgV2VKGBPZdcEuRnWgi3kmaCyX/4ka64xGe7ihEcEh8cNmDqOQdrtvd840 w90ue0f9Fd4+Y1PCRG6afGeQjzkIl7Hwn4jGTbqDHvp7WJW8uJQA6s45+fBZ/lBQM66j SdQCiJ6PrBzPkc+uWwmy/2FptP8KBMtKqbjv2Q2eyDTxoKwEZSccp7Cly2HIJx2HYEJp 8FJKR2d5kx2AG4EJa0piXgh0L0QUzAIEj4geJg46+yeo6XZ8Y5uUYCAgjcUiqTxbcI/H IuRgmWPvSyDMaie3dV6HXQeb99L6WIsVJ+cVyRYKxbkToEu6YhZrBG54ko6EsI0hcUE2 4ULQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HTFJBL9J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h20-20020a170906111400b007ad8ba75a29si10129938eja.359.2022.11.01.15.33.07; Tue, 01 Nov 2022 15:33:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=HTFJBL9J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbiKAWPn (ORCPT + 96 others); Tue, 1 Nov 2022 18:15:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229587AbiKAWPl (ORCPT ); Tue, 1 Nov 2022 18:15:41 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14D541A383 for ; Tue, 1 Nov 2022 15:15:40 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id f5so19124864ejc.5 for ; Tue, 01 Nov 2022 15:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+Tj6LMlid1xqeP/OugEx6eshEoLxwhpJ2MaPH/4J8sc=; b=HTFJBL9J0F7Z1cd/8Hjsp3KSPVYnmAiSIdeEF+dtoljPVhoG5SMj9H8jzOvl/1ur2b INV80sxQYR6xrhtKoMgnQI8qr+moluapFVh0T1sGH+k+oTlVt7CzdEzhLmSpfMfCTEMz Mu/uX7n+gyVhBQASGIOpfy+OmRrgQHvseyi5eDbcLrqm5AoKI+hsZPfXIWOkgmJK4CPd LL9gCZS8ptzuhukIUo8s51ZwGvvmAfMT0Os816kLJYxWsjUCUUAVb+aIXgYClDB82h8J XRhihvbP1Mivm2jnjFuB+8KkIxrwluOUZs4YeisAirTZzli6odoGA5JrkhKAJf7ECoW8 j/DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+Tj6LMlid1xqeP/OugEx6eshEoLxwhpJ2MaPH/4J8sc=; b=BdUIqgR62V98io7oXoRpcmqJ15OLlpOujmSNI8yVhu8+yQoEeBGZga+4zR0ekEeITa oSuxtD50a0xq625nwH7QrLD6ycrQZZGyWPh0v/gEz/+X+jo0ZrmMKCW7wXyBla2mUmyX 9hBxONnc2zVFGrgiWqPcBYvE2rcQxFmkmV5OvdBghHr4mA2vmJbrsmDkjBKr3dEKybSa vTh4et308NO7HZetkSnfKlb1aqj1PP9h8wbejzX03aamw+9VZiCYSeJMhu+mUdQUS4su lMFdm8sifr4AESfaSqdDtVKWFs0E0fvabPviEp3kd1u1uO8DxxHXaMFEhA4vIK2V7auV z2CQ== X-Gm-Message-State: ACrzQf39a1yDK5KMMrRz23WsyxHlt4GjOxHfCzfoHAWH5P/I7llHDGSb Iqy3mXtfwni3ZYxqdzxJbdg= X-Received: by 2002:a17:907:971f:b0:7ad:e232:f115 with SMTP id jg31-20020a170907971f00b007ade232f115mr8922207ejc.754.1667340938658; Tue, 01 Nov 2022 15:15:38 -0700 (PDT) Received: from ?IPV6:2003:c7:8f2a:b885:c7c8:ee47:4872:331d? (p200300c78f2ab885c7c8ee474872331d.dip0.t-ipconnect.de. [2003:c7:8f2a:b885:c7c8:ee47:4872:331d]) by smtp.gmail.com with ESMTPSA id d25-20020aa7c1d9000000b00456c6b4b777sm4874818edp.69.2022.11.01.15.15.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 15:15:38 -0700 (PDT) Message-ID: Date: Tue, 1 Nov 2022 23:15:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 0/2] staging: vt6655: some checkpatch fixes in the file rxtx.c Content-Language: en-US To: Tanjuate Brunostar , gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev References: From: Philipp Hortmann In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/1/22 19:17, Tanjuate Brunostar wrote: > These fixes are focused on the function s_vFillRTSHead > > v3: changed the function name from fill_rts_head to fill_rts_header as > head is conventionally used in lists > > v2: changed confusing changelog messages > > Tanjuate Brunostar (2): > staging: vt6655: change the function name s_vFillRTSHead > staging: vt6655: Join some lines of code to avoid code lines ending in > ( > > drivers/staging/vt6655/rxtx.c | 48 ++++++++++++++++------------------- > 1 file changed, 22 insertions(+), 26 deletions(-) > Patch failed at 0001 staging: vt6655: change the function name s_vFillRTSHead WARNING: line length of 138 exceeds 100 columns #58: FILE: drivers/staging/vt6655/rxtx.c:915: + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); WARNING: line length of 138 exceeds 100 columns #67: FILE: drivers/staging/vt6655/rxtx.c:934: + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); WARNING: line length of 138 exceeds 100 columns #76: FILE: drivers/staging/vt6655/rxtx.c:948: + fill_rts_header(pDevice, byPktType, pvRTS, cbFrameSize, bNeedACK, bDisCRC, psEthHeader, wCurrentRate, byFBOption); May be you need to consider to break this lines. Bye Philipp