Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9bfd45cb-ab5c-1d46-1e16-03417c89298b@intel.com>
Date:   Tue, 1 Nov 2022 15:26:01 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.1
Subject: Re: [PATCH 12/14] platform/x86/intel/ifs: Add current_batch sysfs
 entry
Content-Language: en-US
To:     Jithu Joseph <jithu.joseph@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221021203413.1220137-13-jithu.joseph@intel.com>
From:   Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20221021203413.1220137-13-jithu.joseph@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b2lsSTdXR1BrN3p4TEVEbng0cFpNVmNjRGJmbmFUdDBEdkdOdGtOWlZ4TjBH?=
 =?utf-8?B?K0UyREdsZXZ3b2xkaVdIeDNZeGNSbnVOYlYxbk0yS21UK2Q1UEUyalZKMzVz?=
 =?utf-8?B?Ti9mTzdVSzBLM0J3TlhYMmJaa0xYZTMvSnVOVElVN2FsY3h3UEtCVmFDTUdl?=
 =?utf-8?B?U1FnQWJFNFYwaHJIcGNDMEh4d25VM1FEQnp3OHhNbFNOQVpQMGp0YlB1YTRL?=
 =?utf-8?B?ay96ekJuZlFDNC8rd2dwODZzL00rVTByL1dNay9PK2p5QVVCblBERmRFYnF5?=
 =?utf-8?B?c3ZVTGJYMVRqQkVrVmRJMU8vTzNHd1hMSkh4ODJKN0FJeHNVdWZubVFkbnZW?=
 =?utf-8?B?ZjlCM1N5bjNsdThpa2RMUHNnS0VBaHI3V1hZVTAxODBUVVhVeHJWU2pjeTY5?=
 =?utf-8?B?LzBib2NDU0NnMEtEcjY5cGpoMDExVks0UFdka2kxWFBPNzlSNjJubnFLOVVH?=
 =?utf-8?B?U1UrVWNFTHlGMDZhaUdSeE5rb0FIdmtVejJFZmE0V3FvYWJ1YWs4UTlPcUNP?=
 =?utf-8?B?YWtjVlpSMTVzWnVBMlkxZWc5YjhWdmZoRllUMUVqQ3BSOUxJMk0vc05uc0JP?=
 =?utf-8?B?OVhtZTZTMXVEVFQvVmZ1V1ZqbkpDT2RCYSs5L3VoSDJ4ZzF0eVFGaHlqcGFW?=
 =?utf-8?B?VDdVVmx0eVNiYnVPMlprT1l2S3dBSDlrQ04yQVo1WFYwM0RtVWNzWVZBVjZh?=
 =?utf-8?B?bkxGSzF0UEpyTU1TQ2JYR2s4QUgycncrYU1lY3Y3MlBwazNsZVNXczJmUU9Y?=
 =?utf-8?B?VzVUblE1VWpiVFh1NFhmMFQ3eDY4SzlJS0VlTzlqc3BTMnUzekpuWTNQSE9y?=
 =?utf-8?B?TWpKaHFCWnFMbXViT2tQVzdIdHBTUEtpMVU5aVZPRlhEdXdabFhYNkpZUXdY?=
 =?utf-8?B?OXpudzFIb3d6T3hndmJQOW1RRkJ0N21ndDZFYWd0cStKcWR3cEhNVWFETlR2?=
 =?utf-8?B?enR0UDRYd0tKd0c1Q0EveThBblBPSmZrYTVOMmx3b1EvYWptcmVyN0JyMGJL?=
 =?utf-8?B?MEFUZjZBV0xvd2Q1R21xNjFsV3U5RHV1VDVDZXlhNEx4VWRBTzJZejdtekF6?=
 =?utf-8?B?ZmRMNzJHR1pCVkxLZVVXbFQwazZNdTE1VlBpWjh6Z3QrbHpUMUFXcG1FUFdh?=
 =?utf-8?B?Um9RcElXREdVUWNMR1BDakh1QldHVmhvRWVjYTFJN2sxTHZPTFE4RXdvc3lC?=
 =?utf-8?B?Y1ZHQmFtWngraU91WVJsR3c3VWMyZjY3dUh4Y0ZkOGRXMUlhQTIwbnowMEFP?=
 =?utf-8?B?MzZFZ21sN3F2OFVTOFFqS05lUlI3R1VGMVl3blpkaHJNVStkaTRieDBkQUho?=
 =?utf-8?B?Q2V2NnZtSU8vNDFzWXlvQTJudmMxNVRsajRSY2pOaFkwNTRQUnJGN0dpUlRL?=
 =?utf-8?B?NjFwcHIzZy9tMFNDR3V5bUpvcE1DOEtrcjVPa3VENWNUeFY2b2hHbFdwYmhu?=
 =?utf-8?B?TUxhNnp6WVF1MWttZ0R3ZzBNOGVSUWUzVFhjeUJWUjZseEVIUzhFSWZpb3RK?=
 =?utf-8?B?bFpSazBIRTFWcjdLa3gwOWZOMjJJRzlkRkNYQnNXelFSdGJjdUMvVFFGUDFC?=
 =?utf-8?B?clhBYmZLcDdMNGVmNmJZNVg5NldJZEV5Y0RxamNNZzJNWGFqQWRhNGFFQWpD?=
 =?utf-8?B?dUxBZ0NxeVJLcW5TWXArb2MzWEZKdlc1ODhkTlMrYlpCS1VLdWVQVHdlbWpZ?=
 =?utf-8?B?ZU1RdlhJakdSVHB1NDVyNnlnU3p6VVF1QVpWdStBZ2E5bzdPT3cxQ2xaRWhV?=
 =?utf-8?B?ejc3czFpSE9ybUFhZFd6dnk3UTQ1TGFRYnpWRTRGeUZ2aENXcFRScFc4Q3Js?=
 =?utf-8?B?d25meEl5L3M3RHBBTGQ0QlN4OWhNVGZ6S0VKNng4ZmVFckFmejlUajRuU0x3?=
 =?utf-8?B?VWFGZlllWkFlYkRhM3Bsdm1wTjFWeHk3TDlNU0FQVGZQbEMwY1p3TTEwenJG?=
 =?utf-8?B?U2habjFsMk9sL1pTU25TNkVBRVFDZk1VeGNiUXhLNi9Hem9jdVpHQUNPTTFr?=
 =?utf-8?B?U2x2VDlzQzV1TXgyR2pxODNIMzNzQ3ZueXQxakliV1VqUU5sMldhTFp6VWwy?=
 =?utf-8?B?VDAxYi9vVHpodHNpQVhvck9TVWk2QURxNUhBUHRwSnppdnVyZytXV2Jrb0hl?=
 =?utf-8?B?ekZkWUZVd2lIcXNDN3o0SjlwUlZKRkxCMHY4MUR4MnEyUW5KUEZoakVnd3Rv?=
 =?utf-8?B?Mmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c8652805-474b-4c87-1c8d-08dabc580f5a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 22:26:02.7835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hdRCTus6/jHmtJsgygUWDeYmlTzMT7EBtOLCpzrC4KfLSaRBM3AU66S/RuxGs3TcrWmFH+xcqmgXVzXe3rafYQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5879
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/2022 1:34 PM, Jithu Joseph wrote:
> Initial implementation assumed a single IFS test image file with a
> fixed name ff-mm-ss.scan. (where ff, mm, ss refers to family, model
> and stepping  of the core)
> 
> Subsequently, it became evident that supporting more than one
> test image file is needed to provide more comprehensive
> test coverage. (Test coverage in this scenario refers to testing
> more transistors in the core to identify faults)
> 
> The other alternative of increasing the size of a single scan test image
> file would not work as the  upper bound is limited by the size of memory
> area reserved by BIOS for loading IFS test image.
> 
> Introduce "current_batch" file which accepts a number. Writing a
> number to the current_batch file would load the test image file by name
> ff-mm-ss-<xy>.scan, where <xy> is the number written to the
> "current_batch" file in hex. 

Any specific reasoning why the name "current_batch" was chosen? To me, 
batch seems to suggest multiple or a group of files. But in reality only 
one test file is loaded at a time.

Naming can sometimes be quite subjective so it might be useful to get 
multiple opinions here.

As per my understanding, there is sysfs file called run_test which runs 
a loaded test. Instead of current_batch how about the name load_test (or 
maybe current_test)?

load_test - Write a number less than or equal to 0xff to load an IFS 
test image. (Description as-is from the documentation patch)


>    * Running tests
>    * -------------
> @@ -207,6 +217,7 @@ struct ifs_data {
>   	int	status;
>   	u64	scan_details;
>   	int	cur_batch;
> +	int	test_num;
>   };
>   
>   struct ifs_work {
> diff --git a/drivers/platform/x86/intel/ifs/core.c b/drivers/platform/x86/intel/ifs/core.c
> index 5fb7f655c291..1f040837e8eb 100644
> --- a/drivers/platform/x86/intel/ifs/core.c
> +++ b/drivers/platform/x86/intel/ifs/core.c
> @@ -22,6 +22,7 @@ MODULE_DEVICE_TABLE(x86cpu, ifs_cpu_ids);
>   static struct ifs_device ifs_device = {
>   	.data = {
>   		.integrity_cap_bit = MSR_INTEGRITY_CAPS_PERIODIC_BIST_BIT,
> +		.test_num = 0,

Is this initialization really needed? Wouldn't it default to 0?

Maybe if you explain what does test_num refer to it might answer the above?


> +static ssize_t current_batch_show(struct device *dev,
> +				  struct device_attribute *attr, char *buf)
> +{
> +	struct ifs_data *ifsd = ifs_get_data(dev);
> +
> +	if (!ifsd->loaded)
> +		return sysfs_emit(buf, "%s\n", "none");

Why not:

sysfs_emit(buf, "none\n");

> +	else
> +		return sysfs_emit(buf, "0x%02x\n", ifsd->cur_batch);
> +}

Sohil