Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5edd67d3-e16e-5696-57b4-a9514aa6de63@intel.com>
Date:   Tue, 1 Nov 2022 16:27:12 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Subject: Re: [PATCH 12/14] platform/x86/intel/ifs: Add current_batch sysfs
 entry
Content-Language: en-US
To:     Sohil Mehta <sohil.mehta@intel.com>, <hdegoede@redhat.com>,
        <markgross@kernel.org>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <x86@kernel.org>, <hpa@zytor.com>,
        <gregkh@linuxfoundation.org>, <ashok.raj@intel.com>,
        <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>,
        <platform-driver-x86@vger.kernel.org>, <patches@lists.linux.dev>,
        <ravi.v.shankar@intel.com>, <thiago.macieira@intel.com>,
        <athenas.jimenez.gonzalez@intel.com>
References: <20221021203413.1220137-1-jithu.joseph@intel.com>
 <20221021203413.1220137-13-jithu.joseph@intel.com>
 <9bfd45cb-ab5c-1d46-1e16-03417c89298b@intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <9bfd45cb-ab5c-1d46-1e16-03417c89298b@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkJ1R21kYTNCRi84Y1BOcWMvYXFFbXM5RVBNaDJiZDBIUlpGRGRpNzNLWEx4?=
 =?utf-8?B?a0lidnk3UVJJNmw3ZFF4czVRYzBIbmNIUkdWanIydDcvS0I5ZldNZ2Rac0E4?=
 =?utf-8?B?ZVBKZWtMYks3UEMxdytIMDk5MDNFMTBqNjFWdWRkU3FsVzJFYnBNNEFwZ1Nz?=
 =?utf-8?B?S2R0dlNJUmVCZDNIN2t1NnQzNlV1TGo5VVltZlMzRjBQcjB1Zzc1VUFkb245?=
 =?utf-8?B?R0hTcEpvRHZNOWp2enJ4cXRobmRhbVphZFJPNlhDVmNqTXBnTXJ2bkRYUzYr?=
 =?utf-8?B?OWFHb2pObVdzR3k0YXc3YldlWjN6dFRBZk9DdFJ5VHAwejQrSWFUTytYV0F1?=
 =?utf-8?B?ZGJpeUlHd1NqL0lVSy85bHlFeUFsdEdYQ2RmektMeGxCa0wzYXg0cUNIWXF3?=
 =?utf-8?B?Nlpjdk8vclVRZnhQZHVyeU53b2pIYitUTkw4eThlUTA0U0NHSnJPdUxCTEFO?=
 =?utf-8?B?NGU4NFRqam5nZjlaS1NueGFYdDIwdUtNYnJOQjRNMHVveEV3RUVXUlMzdDN5?=
 =?utf-8?B?UlF3VkZuR0pXVzRhaEF2SXNuVnFJOVpBRFVabnNXd2hKd0cvbUc4ekw1RkRC?=
 =?utf-8?B?UWh3UGNod0dOZnltOWtBR2k2S3dwTThLemppM3oybXdjTlhUTXlFMWRJZ09v?=
 =?utf-8?B?dUMvdUw2OG0wM3NPeXdWa1VJeEhPZGUvcE05VmgrbERNaGZsK3pxTElGYnZj?=
 =?utf-8?B?QWZtam9URDJIenhpRkxrc0J2eUFHTG1SU3BGa1YxU1huOGJRMzNxR2IrcEJK?=
 =?utf-8?B?NTk1NmxodUs0TTJPRjdxOTY2NW9SdEt4WUtHWTYxMjVaSWptRmVHUUY5d2hi?=
 =?utf-8?B?c1puYmc0bHBHd1NoQjkvdmdMNnN0WjJiVzFuZVp0emRIUnpVQjFSWjVUam90?=
 =?utf-8?B?ODFINmFQRFpDNmpieVNVVVlPNDVtVGJXcHNJNVpjSzJYR2cxbWk0L3kvbnNG?=
 =?utf-8?B?dnZqTkd6N25yNytocWR0OTlYUm9WcWtkTmZjR2FnTUxURy9FbmFOQm9yVG9I?=
 =?utf-8?B?cWN1dXFhdWhxZTh4ZURHNlZ0aDF6NVVDQklDTHNYbVV1UDA2RnRzS0d3WUdi?=
 =?utf-8?B?Z2dsTnlwNzhHbVFZUE5EcTZkdkpUS0NRdlNQakNYUnJwWjRPUHhyTVp5K09j?=
 =?utf-8?B?aTVyKzMxSkNXNDJ1aWE2QkszRXRCRGVIdDU5QS81ZHNDZ2pCUDZtamhWZjla?=
 =?utf-8?B?ZithbFI0ZGI0SGJFemJaU3VtNnFaTEQvUlBKYVFERUdJajljTkhlYjlhcEhn?=
 =?utf-8?B?cFI0YzI1TjE3Zldzb1JNWXZTZUd1MTJuYjFIejFsYzdPdFpzRHNmQ0Z3TE0w?=
 =?utf-8?B?UTI1N0xuS3dpTDZHSWYvTE5iTUl4dU0wRm5HMW44d0x1MUgwWjNrVmFtanRT?=
 =?utf-8?B?dmU5M1k4SXN3NTZMY1hlS2F0ckVod2RRZThHMVZVUVRpK2ViditDQjN1RGFk?=
 =?utf-8?B?RjI3RUtiOGZNMGVUeEJrUjhyRkljWndwRFV1QkdhZy9YNkpaREVFdXNqSUdX?=
 =?utf-8?B?MU0yUnpselBnMGZBb2hpME1qdVNmV2ErcFgvUHAwOHZ0SVhCazdyRWRZTnZM?=
 =?utf-8?B?TjFWakFxbEl1U0lVcmFwUllNM2Rlc0RlYzVZNEtXTHNOQXVpZllrWWpYMEFS?=
 =?utf-8?B?dTVDd1YvWkpyOG9zakE0T29iY0hRSTRvM0hTSVR0RWdweGpMNWNzNnduWVo4?=
 =?utf-8?B?NmFGZ0IvckoyOFZXSURvUDNGWjNoZ21MNDRwdHBOVVNGeU5obkhRTmtLME1I?=
 =?utf-8?B?NkcwOG1PcllKMmloN1lVMS9ra1VocjVTSmF3dmxDRm1KRGJRUVV3VytEaUdh?=
 =?utf-8?B?MmRrTTdmTkRPQUl1MnNCcTI5TldMNkovVER1MDFnYW94N0t2bUpTWU4wNk84?=
 =?utf-8?B?WThGV0dSTy9mODZ4b2xWSG9qNDBkZTcyU3RPbXoyTlp1Qi81Umw5OUROWktZ?=
 =?utf-8?B?eHVjVTU2d3NXTlg1V2JlbWthRlVsVjd3L1oycTBXYy83bVE4SHpkSFlyQk9C?=
 =?utf-8?B?QVhjYmZGZkUzMXFkanB0bmF2ZWpYRy8zQzVUUERXTnVNd1VpUzVnMCtKdzAy?=
 =?utf-8?B?b1RpVjdMZENlZHZObU9tUW81WUsxYklpelFPOVZpbzYzUG5kTzNGRTA3RU5J?=
 =?utf-8?B?b1d4T09tZXNRd3pMbitxZ3lDNzIzTVZqOS9BUWsxeTFiTUlwcXBldVRFZzJS?=
 =?utf-8?B?NUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b0ae0d2-fa93-43bd-c430-08dabc609d62
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2022 23:27:17.7536
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lO8q2uDcxT8qsSuQiN7dc05jAOpsqBCXJsCDFYW44cPpoLYcK+TE9iXEpMSwr+Dhs9qQkImGgFuZ3KQ35uou2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6898
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/1/2022 3:26 PM, Sohil Mehta wrote:
> On 10/21/2022 1:34 PM, Jithu Joseph wrote:
>> Initial implementation assumed a single IFS test image file with a
>> fixed name ff-mm-ss.scan. (where ff, mm, ss refers to family, model
>> and stepping  of the core)
>>
>> Subsequently, it became evident that supporting more than one
>> test image file is needed to provide more comprehensive
>> test coverage. (Test coverage in this scenario refers to testing
>> more transistors in the core to identify faults)
>>
>> The other alternative of increasing the size of a single scan test image
>> file would not work as the  upper bound is limited by the size of memory
>> area reserved by BIOS for loading IFS test image.
>>
>> Introduce "current_batch" file which accepts a number. Writing a
>> number to the current_batch file would load the test image file by name
>> ff-mm-ss-<xy>.scan, where <xy> is the number written to the
>> "current_batch" file in hex. 
> 
> Any specific reasoning why the name "current_batch" was chosen? To me, batch seems to suggest multiple or a group of files. But in reality only one test file is loaded at a time.

There would be a batch of test files (6 in the e.g described in the commit message). At a time you can load one by writing its suffix into "current_batch". So "current_batch" was more like a short form for "current_file_in_the_batch_of_files"

> 
> Naming can sometimes be quite subjective so it might be useful to get multiple opinions here.
> 
> As per my understanding, there is sysfs file called run_test which runs a loaded test. Instead of current_batch how about the name load_test (or maybe current_test)?

Each file would contain multiple tests. All these tests contained within a file would be executed when you write 1 to "runtest".
Given this load_test too would be confusing (more appropriate than "load_test" would be "load_test_file" or "load_file" or "current_file")

> 
> load_test - Write a number less than or equal to 0xff to load an IFS test image. (Description as-is from the documentation patch)
> 
> 
>>    * Running tests
>>    * -------------
>> @@ -207,6 +217,7 @@ struct ifs_data {
>>       int    status;
>>       u64    scan_details;
>>       int    cur_batch;
>> +    int    test_num;
>>   };
>>     struct ifs_work {
>> diff --git a/drivers/platform/x86/intel/ifs/core.c b/drivers/platform/x86/intel/ifs/core.c
>> index 5fb7f655c291..1f040837e8eb 100644
>> --- a/drivers/platform/x86/intel/ifs/core.c
>> +++ b/drivers/platform/x86/intel/ifs/core.c
>> @@ -22,6 +22,7 @@ MODULE_DEVICE_TABLE(x86cpu, ifs_cpu_ids);
>>   static struct ifs_device ifs_device = {
>>       .data = {
>>           .integrity_cap_bit = MSR_INTEGRITY_CAPS_PERIODIC_BIST_BIT,
>> +        .test_num = 0,
> 
> Is this initialization really needed? Wouldn't it default to 0?
> 

Not strictly needed when we have a single test

> Maybe if you explain what does test_num refer to it might answer the above?

It is currently used to form the path in ifs_load_firmware() for the test image to be loaded

> 
> 
>> +static ssize_t current_batch_show(struct device *dev,
>> +                  struct device_attribute *attr, char *buf)
>> +{
>> +    struct ifs_data *ifsd = ifs_get_data(dev);
>> +
>> +    if (!ifsd->loaded)
>> +        return sysfs_emit(buf, "%s\n", "none");
> 
> Why not:
> 
> sysfs_emit(buf, "none\n");

Will change

Jithu