Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d464a5319e1571613abcd7f0b3120e82a6f62e6e.camel@gmail.com>
Subject: Re: [RFC PATCH 1/2] i2c: core: Introduce i2c_client_get_device_id
 helper function
From:   Angel Iglesias <ang.iglesiasg@gmail.com>
To:     Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     linux-iio@vger.kernel.org,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Wolfram Sang <wsa@kernel.org>, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Wed, 02 Nov 2022 00:53:56 +0100
In-Reply-To: <20221101145421.jwytax2srno4hhrl@pengutronix.de>
References: <cover.1667151588.git.ang.iglesiasg@gmail.com>
         <aeac9f372ffe0013757e261229e6e23f76f2d8f9.1667151588.git.ang.iglesiasg@gmail.com>
         <20221101145421.jwytax2srno4hhrl@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.1 (by Flathub.org) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-11-01 at 15:54 +0100, Uwe Kleine-K=C3=B6nig wrote:
> On Sun, Oct 30, 2022 at 06:52:18PM +0100, Angel Iglesias wrote:
> > Introduces new helper function to aid in .probe_new() refactors. In ord=
er
> > to use existing i2c_get_device_id() on the probe callback, the device
> > match table needs to be accessible in that function, which would requir=
e
> > bigger refactors in some drivers using the deprecated .probe callback.
> >=20
> > This issue was discussed in more detail in the IIO mailing list.
> >=20
> > Link:
> > https://lore.kernel.org/all/20221023132302.911644-11-u.kleine-koenig@pe=
ngutronix.de/
> > Suggested-by: Nuno S=C3=A1 <noname.nuno@gmail.com>
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Suggested-by: Jonathan Cameron <jic23@kernel.org>
> > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> > ---
> > =C2=A0drivers/i2c/i2c-core-base.c | 15 +++++++++++++++
> > =C2=A0include/linux/i2c.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0 |=C2=A0 1 +
> > =C2=A02 files changed, 16 insertions(+)
> >=20
> > diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
> > index b4edf10e8fd0..e6623226e393 100644
> > --- a/drivers/i2c/i2c-core-base.c
> > +++ b/drivers/i2c/i2c-core-base.c
> > @@ -2236,6 +2236,21 @@ int i2c_get_device_id(const struct i2c_client
> > *client,
> > =C2=A0}
> > =C2=A0EXPORT_SYMBOL_GPL(i2c_get_device_id);
> > =C2=A0
> > +/**
> > + * i2c_client_get_device_id - get the driver match table entry of a de=
vice
> > + * @client: the device to query
> > + *
> > + * Returns a pointer to the matching entry if found, NULL otherwise.
> > + */
> > +const struct i2c_device_id *i2c_client_get_device_id(const struct
> > i2c_client *client)
> > +{
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0const struct i2c_driver *drv=
 =3D to_i2c_driver(client->dev.driver);
> > +
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return i2c_match_id(drv->id_=
table, client);
> > +
>=20
> I'd drop the empty line after the return. Is it worth to note in a
> comment that it only works for bound clients? (Oopses otherwise)

Yup, my bad, that newline shouldn't be there.
Sure, seems reasonable to leave warn just in case.

Kind regards,
Angel

> Best regards
> Uwe
>=20