Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp3317309rwi; Tue, 1 Nov 2022 19:30:06 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Uhh6PtEoj9si2BO7rb60JPl1P7FgTo6NzTYUelUXcIqIbaz3BBBJu0CDbaJ2riJdcpp/P X-Received: by 2002:a05:6402:1454:b0:461:9b5c:2fbc with SMTP id d20-20020a056402145400b004619b5c2fbcmr21658964edx.276.1667356205884; Tue, 01 Nov 2022 19:30:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667356205; cv=none; d=google.com; s=arc-20160816; b=yl0E9tqq62DY4yX7kmMGaijCLKLRXKuSlS3oSY+l/2MWxFOyGgJHlqsRMsig0elNQN B0XGLjVjjvWo+DDsdKYbPiA/rMRFHlCV3v84TRQdkZtkbdod6Wtc7zBMb2AeJgavDj2E POyGmDzlySFsLco68iXcRqPfNi8AH3gTIsmcwq+WVkgk5Kdr+YC6Bmy0WPjY3aPouf/W /NhTiUU+MOH+7ZZAgSryWYTpJEboenRQMhucNzkWDJkWSoEez0rTrHUKrYV9ILj4UIPn EvJsklPBNu/GGyFOJe34/DFT/brnsqaTIFqacXUG6yXTGDyEf9UnkhwAyTOXu2OHrkBX i0jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=B/9nbqKAy6prDAS3oMmtklZfg/ZbEspQaEJ48FmeAmc=; b=vQuu28HtdCUvhN/D3F0aBUNtfnMk8ylEYcgYcztKM3rvoo9zLlnj+1xRGoL2FUiZXS 64HjB+A6RHkAqGMG/R3HDpF/9lURnnT3eMlWkuoOi/UOZxSUYzwHDYzCzHWy8a29vBsy fmiNfSldDByk9zGsQ0cU6l4fAnz/j4y8YsSJL2s7QRBxYhf8eRMsloxC9WqeYXV0tiSJ hsJuzczjOFEgj7FqRBfZKajoTr3FGFdJfXRsjWbeOSmkL/nY1NvCty5hs62LaeouGof4 33Y7v9Tmd0XxuFK4dp4xfTLWnH4ahd47L6bE8gGroAFm1YaatalZtLBAbX/PI2lf4VPv 7yxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=TrwwCrLq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r12-20020aa7c14c000000b00462e628189asi11696142edp.304.2022.11.01.19.29.37; Tue, 01 Nov 2022 19:30:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=TrwwCrLq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229561AbiKBCJz (ORCPT + 97 others); Tue, 1 Nov 2022 22:09:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229866AbiKBCJy (ORCPT ); Tue, 1 Nov 2022 22:09:54 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D68CC1D65D for ; Tue, 1 Nov 2022 19:09:52 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id d10so15135193pfh.6 for ; Tue, 01 Nov 2022 19:09:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B/9nbqKAy6prDAS3oMmtklZfg/ZbEspQaEJ48FmeAmc=; b=TrwwCrLqC7JAM1Uu/+yafOAtWgX5dY7pPM2NvZ69AMrgl3UEFM/DscGiTUUHN3pc+L uS7v2QJimbqhm1WnG9dnmFDRtAK7Yte8g4pmcY2GKK2Ytn0tZg9J9Dfz0LlYaXEDDxsx iiTD4UyqQ9/VzWkjBXBux22f7w4atH83ns9iux6Su51579Sjj45hARf3lqY0yH2OoybV v0M5WTlBw12gNGR7yEzNR+v5pJXL2RhLDZb6KkB4LTw9dVwWz1JNVzxYWwMm3Og/CFZy yEUtvs6A3IVvM93m1EbIcurAyJwCjGIC2c1FgMU708u88XVXA0b3UxJKLzPm463agT6c ZJiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=B/9nbqKAy6prDAS3oMmtklZfg/ZbEspQaEJ48FmeAmc=; b=psD4u+EbtuLSQH7KB+6UpXyg1fRx4fpodOztjLyk4DvpEx45WxytfXI6GQQlBeAYRG gx1tGul1zSu0xSQjjGgr4iFKinxD92pw9dFvfq49LpP3JHuDdp6xtkrxjz7EvGdRsVfd kKbEmzJ85Hh35cJE9jq/qFcIoJ9a6IW7X4rmpOBq2fFOcMwlDD9Ly8hg9ia6l/DQEE9b uoUVUIdnUjoDVk4TYRqTk3/jT9tjFloj6AGo88Sv2BQc5GI5Dbrzg2EE8PFQ177zyPuT 9TEp+uIkAnshXKktgXorKWMis0AnPbRrYjKpJPR2HHbBPNL46BK3hL5Sp1CT8GxN2fmC b15Q== X-Gm-Message-State: ACrzQf1owz1q1ty12L9qAQoc0Qpsy7DxaP8djYDtUH1C8H3+rxTMBQ/h M+VT4iGo1Z54JFX4NpBU+WhmXA== X-Received: by 2002:a63:35c6:0:b0:470:d38:7c63 with SMTP id c189-20020a6335c6000000b004700d387c63mr17783pga.249.1667354992155; Tue, 01 Nov 2022 19:09:52 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id k1-20020a170902c40100b0016c9e5f291bsm7018876plk.111.2022.11.01.19.09.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Nov 2022 19:09:51 -0700 (PDT) Message-ID: <7f7e59cb-e0b8-0db5-7c46-11aea963bcfa@kernel.dk> Date: Tue, 1 Nov 2022 20:09:44 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH -next v4 1/5] block, bfq: remove set but not used variable in __bfq_entity_update_weight_prio To: Yu Kuai , jack@suse.cz, paolo.valente@linaro.org Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yi.zhang@huawei.com References: <20221102022542.3621219-1-yukuai1@huaweicloud.com> <20221102022542.3621219-2-yukuai1@huaweicloud.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20221102022542.3621219-2-yukuai1@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/1/22 8:25 PM, Yu Kuai wrote: > From: Yu Kuai > > After the patch "block, bfq: cleanup bfq_weights_tree add/remove apis"), > the local variable 'bfqd' is not used anymore, thus remove it. Please add a Fixes tag. -- Jens Axboe