Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp3324429rwi; Tue, 1 Nov 2022 19:37:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7f4RhZ0BynbroiFb/eCtUdcEoI3YD37eSjlklrOU/zu3EqP7bjtExYyd+tDFQ00xT/dyNI X-Received: by 2002:a05:6402:1d86:b0:457:e84:f0e with SMTP id dk6-20020a0564021d8600b004570e840f0emr21980156edb.241.1667356651561; Tue, 01 Nov 2022 19:37:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667356651; cv=none; d=google.com; s=arc-20160816; b=SR/f+3x9ibCPBS/2kLEnOg0IiRA7Zc/GnJ3XUYnsIys7RiCxNaJB6eu3D3Gtvr0H2T PRTD/2CN6r/QpZ73khF4rSC4biDFhvKDjx5GGrzAzfOWfRuwE7k8B+5foUTcM5JeOYnH SYvwUta3TCtYqeZVymTuTTdJj/aaDlxlZXsEsz8ocoBLl/XpaI4YVvk6RLc5Sm5DZQuz JkA7yC6nHrxtq36fp+dujFbTFfYdeb9Z0zSeDy5xyX5A3Pf1BItycb2CCwCKzhzXaF2g Wk6eslh/CaZZX+LhdsEeWn8zKC5tQ9CWFH0ALUGKPpc2e4VpJ569E+/8zL+1PPRWZq+R 47qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=Fa4+ODjcbUmaAkzkEYpmZ5/Di62toXfDf0uw8VZTsL4=; b=ztPmjf0fIyLOOoH1EC/CMbqwDI06Zv3/9Sn+DR3sVHgt1BqFy8WUVRM9z5+uqId0+b SmAzOhxwIz85BTrvS6hWY1RRSsYnpCvc3QRE2jsES7wLQy+3AOGswoBZfRyKyB99y0sw t7l4R5k/CrcCv9WLlda9mGo/GLihSdqaopVkewIvruh0xTdRFOYaHavQNGYYyIqP+Yni i0W0ciJb+q3omykOKUuCJgy674Khf35cLJYJuB1XkEeUsdfvylIKzFbY3TL2o/YHpvNk oGms3sj6OPo6/mcorooyUAQEl+uJRX0SnKxeKi/AjhHlUaOpDJfHD13Ij+39LUflszn0 Q72Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga32-20020a1709070c2000b007adfed505casi1509331ejc.156.2022.11.01.19.37.06; Tue, 01 Nov 2022 19:37:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbiKBCSS (ORCPT + 97 others); Tue, 1 Nov 2022 22:18:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiKBCSQ (ORCPT ); Tue, 1 Nov 2022 22:18:16 -0400 Received: from dggsgout12.his.huawei.com (dggsgout12.his.huawei.com [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B55311EED6; Tue, 1 Nov 2022 19:18:15 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.153]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4N29Tn4cF0z6PYPv; Wed, 2 Nov 2022 10:15:41 +0800 (CST) Received: from [10.174.176.73] (unknown [10.174.176.73]) by APP4 (Coremail) with SMTP id gCh0CgCX8+Vk02FjQFNMAg--.26377S3; Wed, 02 Nov 2022 10:18:14 +0800 (CST) Subject: Re: [PATCH -next v4 1/5] block, bfq: remove set but not used variable in __bfq_entity_update_weight_prio To: Jens Axboe , Yu Kuai , jack@suse.cz, paolo.valente@linaro.org Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, "yukuai (C)" References: <20221102022542.3621219-1-yukuai1@huaweicloud.com> <20221102022542.3621219-2-yukuai1@huaweicloud.com> <7f7e59cb-e0b8-0db5-7c46-11aea963bcfa@kernel.dk> From: Yu Kuai Message-ID: <61725ff6-6da3-3d3c-4261-7f05c57ab9da@huaweicloud.com> Date: Wed, 2 Nov 2022 10:18:12 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID: gCh0CgCX8+Vk02FjQFNMAg--.26377S3 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYz7AC8VAFwI0_Gr0_Xr1l1xkIjI8I6I8E 6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28Cjx kF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI8I cVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87 Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE 6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72 CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7Mxk0 xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr 1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE 14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7 IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY 6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa 73UjIFyTuYvjfUoOJ5UUUUU X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, 在 2022/11/02 10:11, Jens Axboe 写道: > On 11/1/22 8:09 PM, Jens Axboe wrote: >> On 11/1/22 8:25 PM, Yu Kuai wrote: >>> From: Yu Kuai >>> >>> After the patch "block, bfq: cleanup bfq_weights_tree add/remove apis"), >>> the local variable 'bfqd' is not used anymore, thus remove it. >> >> Please add a Fixes tag. > > Looks like the rest were good to go, so I added it myself. Thanks for helping out. I'm not sure which commit id to use since the fixed patch is not in linux-next yet, does the commit id stay the same when the patch applied from for-6.2 to next ? Thanks, Kuai >