Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b7bcc99c006c91871f0518c1a132035d2a148f24.camel@nxp.com>
Subject: Re: [PATCH RESEND] mfd: Add Freescale i.MX8qxp Control and Status
 Registers (CSR) module driver
From:   Liu Ying <victor.liu@nxp.com>
To:     Lee Jones <lee@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com
Date:   Wed, 02 Nov 2022 11:49:17 +0800
In-Reply-To: <afa29fcc11436dd957314a4066c9141937f0470c.camel@nxp.com>
References: <20221017075702.4182846-1-victor.liu@nxp.com>
         <Y1/sUfeVy1a6EKZQ@google.com>
         <afa29fcc11436dd957314a4066c9141937f0470c.camel@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OHppT3BwS3hTRTdVMlJBd2hXTWVmdW5LVEJwVjhVNFZrSE5iZWZIVjdtMXJ1?=
 =?utf-8?B?ak4vUWVMSTQyK2JNTmlQaGRNWjdzdXQxclozMmlGdWswTE9TM0MrK2NVM2lo?=
 =?utf-8?B?ZTlJRUlXbm5DdDJuMnhyWkN6WThPbGZ3dWRIajJsUWtOWS9kUitmR3RxdzJk?=
 =?utf-8?B?NkE3WWxBa2FxR1h1aXh6V2NRdTg5aUNuYXVkeS9makQ3NnN0RXhqZyt1UmRx?=
 =?utf-8?B?UU1ua2hYZnVsMkQrOEZMakJMaGJBNFMrVkFTVEozeFBQSTRsMFZJM1phWTJP?=
 =?utf-8?B?R2JzN1h3ZWNVMDAzYnhuV0tiajEzcXBKS2x0Q0oydFhXa0g4cDMzTUcwTDNo?=
 =?utf-8?B?elpZUHNLbEo4dTF4R1NQQmluZzVLbVNRa0pvTHRrNjVYR0orTU9Rc200dGd1?=
 =?utf-8?B?UFBqVGtpcDhBa1dRUC9ua2J3djhCWG5idFlkeUdEOC9kSnY2a0JIZmdTWllt?=
 =?utf-8?B?cjk5aUpWUjYrRGhHZzAyYlFCSklwekZmSHN4eXg2ald4NW4vZ3Y4cDB2dmt2?=
 =?utf-8?B?RndHK0JRVGVUb2o4c1QxRHRFdnhQeFZ4VkU0QjBROGx2Z3JoQmZJT2lqVjdI?=
 =?utf-8?B?ZjcrLzFlSVorVEZtaGRUNEJEVE1qMUtSQXhEN0oybE1zTklTcGl1aGUxcjJI?=
 =?utf-8?B?dlhHa3FpazBOY2ZWRE1MR3dwbm5yOTFVa0JBbEdmN2pJNUpaTkxxVUhBNUhN?=
 =?utf-8?B?R25LejVzaUFOYWw2Rm43Zitaa0k3OVUzVWYzL3QrVnd0eEZ4NW95bVpFYzFF?=
 =?utf-8?B?WUhlWnc1eTFyNTEwdE9FZWNTTTI4bWV4a2I3cFVqbDIvUk9OSGVDbGlTbEVw?=
 =?utf-8?B?MzEwbG9Bc0lJS0M4M3kxYm00QWhCSFA4OVFHNzU3OSt0VjV1T3hPNGNnNDc2?=
 =?utf-8?B?eGxBV05zNXZiSzNBVmpLWVpqOGJxdE85YkIvSWZMTS9mck9ON1UxcGd0aXNa?=
 =?utf-8?B?UVhacmhKNDl2aGlxWnBDbGtyRW1pV2U3ZUJnWld2REdlcDNFTlNhOVNBdFpj?=
 =?utf-8?B?YWtHOGhweDRSd3AxeWptSGgrbVlWQ0FHZ0xhaE1XZFZHenB3eGxkTWQrU2Qr?=
 =?utf-8?B?Q0tlSTVPRUpubjlKYWxONFpta3FLaG5WUkpaaXFFRWRhdlFudFgvMDU1YXpW?=
 =?utf-8?B?U2tMald1UnZ5Ynk5M0xPN1FUUjk1UkxCUEJ4cTBTa2lNcHF4VXVGUllURnI2?=
 =?utf-8?B?djNVVmJCbU4zejdFOHVVU3NVbWFDS0FjYlRBanE4WkM0WWE1MUd4T01zT0ts?=
 =?utf-8?B?dVlLV3pQa1ZrQXFOVUE5T0xwRmJTaG45Y3htL2Z4T1JFcVFPdkYrUjNxVlVB?=
 =?utf-8?B?ZUg2blNBb29ENFFvYnZnT3gyQjdwOHpCcFhXSEN6VCtVVzc2K2ZKbFpxOWtZ?=
 =?utf-8?B?S2xzWDBaMTQ4enNZdkduNnBxbkhObngwdlVYS1R3djU5M2VsY25WOExMTUI4?=
 =?utf-8?B?WjN5bEh3akFiMXN2bkpYNGNhQ3pYbHR3NVI4SWtRdDVsMWxJYjBPOWpqanZ5?=
 =?utf-8?B?WjNaWWNkdWY3NW5TUTc3QThxK0pvaXBaNWUyODh0UiszMktFYmQwb29WYlRY?=
 =?utf-8?B?cWhvaDZ3dWNlalV3V2hzSFNueEJOQURpT1N5UlpIQUpGQWdaaGZPd3F5Tk1B?=
 =?utf-8?B?SUY1K3BnMmd1aWMySTYrTWRKZGdVNEdlUU0xZzd3VjFTdFA3K0NERnFpWmEy?=
 =?utf-8?B?cC9pb1Z4OWpEWUtDRUtwTTZxYXVLUmNOS0QwYXB5ejB6aWlsMEEzbURHVGkw?=
 =?utf-8?B?SUZuYzEzam1tNUlNcUMxMWQ2dkFBc040elNDUFNCOERQZTRLRjVLeTVnSHNz?=
 =?utf-8?B?TWhFTlc3UTlSeXRNV1lSeEo1c2N4Wi9QNkdqTWNuTUE0NjJQYzNVY2pydkFP?=
 =?utf-8?B?VnIrbGczdlk1blIzb0hhUnBpdnpnZE1MVmhMNXhSUk5pQVduK0crcGpzMG5w?=
 =?utf-8?B?cC9Wcy9SdjU5Q3YwNWhITURLaCtoNGM4WFpqbVg0ay9jOHJPN3NPSmdHcC8r?=
 =?utf-8?B?NElkVk1PLzU5UllMK1o4SDFOams1dlFrWWFPcmJCclpFMnhjbjdHbUtWbU1M?=
 =?utf-8?B?L0JDa0IrWnVFZnlBZmxaM2ZZRzJEZUoxd2k0K05BTUVFTHJockF0UTgveHh0?=
 =?utf-8?Q?4eIZq/H0WKI+Zs+O98RF/jxNI?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 449043f9-e7ff-43c3-8bfc-08dabc854e75
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 03:49:56.2313
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2Nxp4UE2qLajy0zrqToHGUezGV2JAm6ZnD6YGvsFoKv0nr9rq3S0pgpohEetu2gc0GBxCGfWgwPytqaRHWfB0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8142
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lee,

On Tue, 2022-11-01 at 13:53 +0800, Liu Ying wrote:
> Hi Lee,
> 
> On Mon, 2022-10-31 at 15:40 +0000, Lee Jones wrote:
> > On Mon, 17 Oct 2022, Liu Ying wrote:
> > 
> > > Freescale i.MX8qxp Control and Status Registers (CSR) module is a
> > > system
> > > controller. It represents a set of miscellaneous registers of a
> > > specific
> > > subsystem. It may provide control and/or status report interfaces
> > > to a
> > > mix of standalone hardware devices within that subsystem.
> > > 
> > > The CSR module in i.MX8qm/qxp SoCs is a child node of a simple
> > > power-managed
> > > bus(i.MX8qxp pixel link MSI bus). To propagate power management
> > > operations
> > > of the CSR module's child devices to that simple power-managed
> > > bus, add a
> > > dedicated driver for the CSR module. Also, the driver would
> > > populate the CSR
> > > module's child devices.
> > > 
> > > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > > ---
> > > The Freescale i.MX8qxp CSR DT bindings is at
> > > Documentation/devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml.
> > > 
> > > Resend the patch based on v6.1-rc1.
> > > 
> > >  drivers/mfd/Kconfig           | 10 +++++++
> > >  drivers/mfd/Makefile          |  1 +
> > >  drivers/mfd/fsl-imx8qxp-csr.c | 53
> > > +++++++++++++++++++++++++++++++++++
> > >  3 files changed, 64 insertions(+)
> > >  create mode 100644 drivers/mfd/fsl-imx8qxp-csr.c
> 
> [...]
> 
> > > diff --git a/drivers/mfd/fsl-imx8qxp-csr.c b/drivers/mfd/fsl-
> > > imx8qxp-csr.c
> > > new file mode 100644
> > > index 000000000000..3915d3d6ca65
> > > --- /dev/null
> > > +++ b/drivers/mfd/fsl-imx8qxp-csr.c
> > > @@ -0,0 +1,53 @@
> > > +// SPDX-License-Identifier: GPL-2.0+
> > > +
> > > +/*
> > > + * Copyright 2022 NXP
> > > + */
> > > +
> > > +#include <linux/module.h>
> > > +#include <linux/of_platform.h>
> > > +#include <linux/platform_device.h>
> > > +#include <linux/pm_runtime.h>
> > > +
> > > +static int imx8qxp_csr_probe(struct platform_device *pdev)
> > > +{
> > > +	int ret;
> > > +
> > > +	pm_runtime_enable(&pdev->dev);
> > > +
> > > +	ret = devm_of_platform_populate(&pdev->dev);
> > 
> > The use of this API does not constitute a MFD.
> > 
> > Please use "simple-mfd" instead.
> 
> simple-mfd devices have "ONLY_BUS" set in simple-pm-bus.c, so the
> simple-pm-bus driver would not populate child devices of simple-mfd
> devices.  Also, the simple-pm-bus driver would not enable runtime
> power management for simple-mfd devices due to "ONLY_BUS", which
> means it would not propagate power management operations from child
> devices of simple-mfd devices to parent devices of simple-mfd
> devices.  That's why a dedicated fsl-imx8qxp-csr driver is needed. 

One more point which might be overlooked - as mentioned in commit
message, the CSR module is a child node of a simple power-managed
bus(i.MX8qxp pixel link MSI bus), which means the child devices of the
CSR module(as a simple-mfd device) won't be populated by
of_platform_default_populate() from of_platform_default_populate_init()
because "simple-pm-bus" is not listed in of_default_bus_match_table[]
and hence recursion of of_platform_bus_create() will stop at the
simple-pm-bus. This is also a reason why a dedicated fsl-imx8qxp-csr
driver is needed to populated those child devices of the CSR module.

The patch set to support i.MX8qxp pixel link MSI bus can be found at:

https://lore.kernel.org/lkml/20221017074039.4181843-1-victor.liu@nxp.com/

Regards,
Liu Ying