Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221101111655.1947-1-angus.chen@jaguarmicro.com>
In-Reply-To: <20221101111655.1947-1-angus.chen@jaguarmicro.com>
From:   Jason Wang <jasowang@redhat.com>
Date:   Wed, 2 Nov 2022 13:34:23 +0800
Message-ID: <CACGkMEs6ZTrf0NMXGuM=VYZC+zAujigiTG2CgE8gAdvxHc2Q7A@mail.gmail.com>
Subject: Re: [PATCH] virtio_pci: modify ENOENT to EINVAL
To:     Angus Chen <angus.chen@jaguarmicro.com>
Cc:     mst@redhat.com, virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, lingshan.zhu@intel.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Nov 1, 2022 at 7:17 PM Angus Chen <angus.chen@jaguarmicro.com> wrote:
>
> Virtio_crypto use max_data_queues+1 to setup vqs,
> we use vp_modern_get_num_queues to protect the vq range in setup_vq.
> We could enter index >= vp_modern_get_num_queues(mdev) in setup_vq
> if common->num_queues is not set well,and it return -ENOENT.
> It is better to use -EINVAL instead.

I'm not sure I get this. It would be better to describe:

1) what kind of issues can we see if we return -ENOENT
2) why -EINVAL can help in this case

Thanks

>
> Signed-off-by: Angus Chen <angus.chen@jaguarmicro.com>
> ---
>  drivers/virtio/virtio_pci_modern.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c
> index c3b9f2761849..edf2e18014cd 100644
> --- a/drivers/virtio/virtio_pci_modern.c
> +++ b/drivers/virtio/virtio_pci_modern.c
> @@ -303,7 +303,7 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
>         int err;
>
>         if (index >= vp_modern_get_num_queues(mdev))
> -               return ERR_PTR(-ENOENT);
> +               return ERR_PTR(-EINVAL);
>
>         /* Check if queue is either not available or already active. */
>         num = vp_modern_get_queue_size(mdev, index);
> --
> 2.25.1
>