Received: by 2002:a05:6358:111d:b0:dc:6189:e246 with SMTP id f29csp3502596rwi; Tue, 1 Nov 2022 22:52:03 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4j7/WAP/J7D/M4JDvCMHHe/VWNRWM619o4T89FVfBDCoIqJO+Jxq2svviRFTTjlDK5o4a8 X-Received: by 2002:aa7:d14f:0:b0:463:a5d3:fb95 with SMTP id r15-20020aa7d14f000000b00463a5d3fb95mr7879841edo.237.1667368322958; Tue, 01 Nov 2022 22:52:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667368322; cv=none; d=google.com; s=arc-20160816; b=wceEb00kNLchMtzpnxmDEMPWwgMLvi7vbj26Sb8NWUm7ACDeHQKJsqMFytNi5KlsT8 ffLG+gDpzd4/1iBgVECaB0wXNPaVezz1k5ohwdYk6zvgerakmb/JlzqOQV5jlYa3eXjx s2JVcWRlGOcPT4p5PkpAJMqRzDZ/55u0ZWh8YNqLYkICKQIt3G92JoGlqqXsyR0DaNWq 9hvDyT0zxbco7Wiqw5pXhD6cdPtJBLeDgiiUpOcdKezGN4rhiGOhrrxRU9r+qT3hshNO rpsguqgJsW7XNaBRwAy3O5sojpGnlOdIzq26i++IKrXhUg/1YYU7p7ESx17TGsNUrUnZ j05w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pTyQJMDswZvsjownmnP/toUJ9wQHXNgeQ5egG/TQWpQ=; b=Aam0B9CA7U1WotKr7mrIAC1oeZZvzP78T6uceZF33rxJqOYiIgwhOAooOpbHAqPtPn 0YqGU4XlsI56OFNvT12x0a0cZHz+NyBJEDgT3wdB/cIH4ik1hK2JVowU6Z/njSbRbTPf utV1RjbLRZ3iNan37jKoqkpFOKS92PGcr06xpmTS6By03j7syMoS0EChp7vL032v/IPc U6gyCkhwRlchpfAHpnx584EQoO/T3+Y6rl15/7FdaUXkeKhv1c4MzktmqkFEd2uYqxig A2UGScLKyrDxpSATUu0kcEoUgOJ+kspEklh70bDcJMZrFcOQ8gtOcKB3hAuSLfpMUwmy pixA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HyxuQLit; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t13-20020a056402240d00b00463c13a9ab7si3822368eda.32.2022.11.01.22.51.39; Tue, 01 Nov 2022 22:52:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HyxuQLit; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229684AbiKBFNW (ORCPT + 96 others); Wed, 2 Nov 2022 01:13:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229457AbiKBFNT (ORCPT ); Wed, 2 Nov 2022 01:13:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C37C1252AB; Tue, 1 Nov 2022 22:13:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 442EB617EB; Wed, 2 Nov 2022 05:13:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71C23C433C1; Wed, 2 Nov 2022 05:13:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1667365997; bh=X5ownL5/SLGdv+si92x3oobTQIguLhc5vCym52Z20MY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HyxuQLit/4cmu7jRRg4Fdl0RP3BH8N7DjW1mWNS8QOmSNwnnHFn5CwDpKQ8MTnS3R HKjFlUAElj2+daojXwgjVtioze5al16rvPm3jpfeUD1QSgeQMLv4sVH6n1b55ozHCE 5iZVIvLfmc3kTSFzrTj9MuSs+ole19eoTiNESdjA= Date: Wed, 2 Nov 2022 06:14:10 +0100 From: Greg Kroah-Hartman To: Elliot Berman Cc: Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , Srinivas Kandagatla , Amol Maheshwari , Kalle Valo , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 13/21] gunyah: vm_mgr: Introduce basic VM Manager Message-ID: References: <20221026185846.3983888-1-quic_eberman@quicinc.com> <20221026185846.3983888-14-quic_eberman@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221026185846.3983888-14-quic_eberman@quicinc.com> X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 26, 2022 at 11:58:38AM -0700, Elliot Berman wrote: > +#define GH_CREATE_VM _IO(GH_IOCTL_TYPE, 0x40) /* Returns a Gunyah VM fd */ Why 0x40? Why not just use the same KVM ioctl numbers and names as you are doing the same thing as them, right? Normally your first ioctl is "0x01", not "0x40", so this feels really odd. thanks, greg k-h