Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Jiaming Li <lijiaming3@xiaomi.corp-partner.google.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        lijiaming3 <lijiaming3@xiaomi.com>
Subject: RE: [RESEND PATCH 1/4] scsi:ufs:remove sanity check
Thread-Topic: [RESEND PATCH 1/4] scsi:ufs:remove sanity check
Thread-Index: AQHY7nxg7JegoaBYh0+mHw3z5ripcK4rOVqg
Date:   Wed, 2 Nov 2022 07:23:27 +0000
Message-ID: <BL0PR04MB65648BD218A08A3D55A6D12BFC399@BL0PR04MB6564.namprd04.prod.outlook.com>
References: <20221102053058.21021-1-lijiaming3@xiaomi.corp-partner.google.com>
 <20221102053058.21021-2-lijiaming3@xiaomi.corp-partner.google.com>
In-Reply-To: <20221102053058.21021-2-lijiaming3@xiaomi.corp-partner.google.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MaPuQS0Un1oPgr54ua8PtU3+ZKg0vJ+EAhLE+OvriSQHCJJpnausuWgXxYpP?=
 =?us-ascii?Q?NV+2j6XIUuLC0Z4HJ4xQGf1HJQmZdb72lgItR9ZXDNl/0s/uCRVHIM6fWb+p?=
 =?us-ascii?Q?6Jx9Q+EMvEHqalIKQ7lOS7c7d6ikg1KnqYFETrIFKj9yJop/4Znd31H4xTO7?=
 =?us-ascii?Q?yRn66mkBmydOXjiqxkdZzZvPLMV+gXIyqcph9le1PYi5GZOZMzyblo/Y4mlT?=
 =?us-ascii?Q?+4G+gp6imw6sH6K25Ud1/F/IOTkxFjzHd+dO+t8P/d1eSFNbGiZ7/2kxhmBw?=
 =?us-ascii?Q?3smHPzy2yqZN7yFnC2Yy5r++MZUf8XwK/xV1THo6MCpyh/VPvVnXu+0gla2V?=
 =?us-ascii?Q?e0YMWUEo7D1XI6IF2kFFv0anVhcQwP+jG7vxiU+CH6ALleNBFDX+fwOK0bFK?=
 =?us-ascii?Q?sv4IAA8RzSii79pNNu03ssP3qPidQSPxIE2+8orMKIdAdRBFnFcalesO/+zn?=
 =?us-ascii?Q?JssVqurIRcQjPAvHzdmzXzIrHLtXbDVsAQiab7KxiunkAZVg3WZn8LcciFUU?=
 =?us-ascii?Q?WrC+pVstPiG2VohwUfXbCWg+uxaBWqmvAcDUx+keBoamw04SF/zixzFLhguA?=
 =?us-ascii?Q?uzM/prEXUB6Pa01y0xN2X8vV82oHf+Rzo7p2XfwDoNuNqu44dELEv94ClY4d?=
 =?us-ascii?Q?ixgU2kwqVUPnarXkucKTJCNV4tjqHph8zy91rtFm76b50t0NntMMo6cyWNGI?=
 =?us-ascii?Q?HKUlWXZFzm6eDyfRZ2J5tmu/Bj7/03IsguXXKR3bAlUI9P+pUx0w8gLNznRA?=
 =?us-ascii?Q?WfzPpJux/Q72/ThOZT20S/g1z/9JiQunUBYc7YPZZlFs5vbxo3cQWKist/Zp?=
 =?us-ascii?Q?q0AF9c6JEdcCpjjzFn1CcEXxNoyrO8baX2cGbfnoc/N7SA6QvtZ9ypTSU8vA?=
 =?us-ascii?Q?VfEukmgbvp3qWWiYyHDiCW+gq85IU/Y0tTl8hnqSap5/kVU+XmLxIAwxpPaH?=
 =?us-ascii?Q?QlSkcF4Y5z9YNkLtVlTLGqOG4ZVzS2PnyGJXauiXfoibaW7VSSluW4CYgJsG?=
 =?us-ascii?Q?p9Jm29lm7O8dpgSaur7Z3CMTXV3pJuKPcGtPF64PUP/RClR9euCFBK1Bh1Sl?=
 =?us-ascii?Q?BbbbhFCnTCQF65n9UWQTcshXEZUSq0ijVfbEtHNHWwvzSgEsL0tt9Y1wycni?=
 =?us-ascii?Q?AkCkswH3IlvWjo8APyXrjxh5jG5ApCRWBY7CYt9shObSrmOjgMH/E2Logjtt?=
 =?us-ascii?Q?fhahJvDYEAPW4Dg0hmFkw2ssj36qkmBLr/oT1YRS4Bzd6iV2/UT43J20/N6n?=
 =?us-ascii?Q?M+oVUpn1NpbjdU7e3e77Rd9visZAyo6+6J0607PhWlxMXE7MCt6ttRklv0+0?=
 =?us-ascii?Q?hoXng5Tzgq+tQiSOan1PRfo3wdS9eG7nWsCIupPLIAAK89rD8tGcm+ImDCSa?=
 =?us-ascii?Q?UCbNuejQ4OKwmjCdr+CokmZj0iZJRF/P4Rfenb+yGrNAUN6S9zC3KOV9x3dC?=
 =?us-ascii?Q?CMb/XBIHIxPOMl7RnPRwLzxkGQa5WIFv6Msz6lz2uzjwxgmrKjgxfywFIxwP?=
 =?us-ascii?Q?vlv3t8MmDGPljX8xh8/XcXc75WuXOCsjxHb+W1jnA1T/Ja6H9VRkybtojtuQ?=
 =?us-ascii?Q?CfkyJWmZf8afXpGM/38ll5nZiy7xv/pyXnQbgcCh?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR04MB6564.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee34e60e-c675-4d77-a1d5-08dabca32293
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 07:23:27.1981
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: UZZu/Dq5X6oFX869n7zXikj0NnladM4DQzreFtqgeQVwvRScyvSgSt2jfb7uT21qo54Owml6WMwU756KtWlFVw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR04MB7296
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: lijiaming3 <lijiaming3@xiaomi.com>
>=20
> UFS descriptors assumed to have a 2 bytes header:
>  - Offset 0 - descriptor size
>  - Offset 1 - descriptor id
> However, the ufs spec does not mandates this, and as a matter of fact,
> QUERY_DESC_DESC_TYPE_OFFSET is not being used anymore now.
So maybe remove it from ufs.h as well?

> And future descriptors no longer follow this assumption. So remove this a=
s
> preparation of introducing the FBO descriptor.
>=20
> Signed-off-by: lijiaming3 <lijiaming3@xiaomi.com>
other than the nit above:
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  drivers/ufs/core/ufshcd.c | 8 --------
>  1 file changed, 8 deletions(-)
>=20
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index
> b1f59a5fe632..4bc5b8563a62 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -3458,14 +3458,6 @@ int ufshcd_read_desc_param(struct ufs_hba
> *hba,
>                 goto out;
>         }
>=20
> -       /* Sanity check */
> -       if (desc_buf[QUERY_DESC_DESC_TYPE_OFFSET] !=3D desc_id) {
> -               dev_err(hba->dev, "%s: invalid desc_id %d in descriptor h=
eader\n",
> -                       __func__, desc_buf[QUERY_DESC_DESC_TYPE_OFFSET]);
> -               ret =3D -EINVAL;
> -               goto out;
> -       }
> -
>         /* Update descriptor length */
>         buff_len =3D desc_buf[QUERY_DESC_LENGTH_OFFSET];
>         ufshcd_update_desc_length(hba, desc_id, desc_index, buff_len);
> --
> 2.38.1