Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Greg KH <gregkh@linuxfoundation.org>,
        Jing Leng <jleng@ambarella.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH v3] usb: cdnsp: Fix wrong transmission direction of EP0
Thread-Topic: [PATCH v3] usb: cdnsp: Fix wrong transmission direction of EP0
Thread-Index: AQHY7bm9uUxk3j0ujU6Lr3b5nXqmSq4p0U6AgAFt4aA=
Date:   Wed, 2 Nov 2022 07:35:01 +0000
Message-ID: <BYAPR07MB5381D40A2B48BCDEA6ED305CDD399@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20221101044433.5627-1-3090101217@zju.edu.cn>
 <20221101061730.8991-1-jleng@ambarella.com> <Y2DqOefwSAjmExof@kroah.com>
In-Reply-To: <Y2DqOefwSAjmExof@kroah.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FywoJZsYe0cNej/N6/g8EU0OGAXzEw4iDxnmQL7tOjgBgoun3b/7zPe+8d/s?=
 =?us-ascii?Q?f/Pkv0ksyBXvyvL3C3MxuMSwwMlwLDgcLXHAuKbqg1CAMBu4qVMtejUkF/Nc?=
 =?us-ascii?Q?zgzhmqillKGx4dkV1Bd1SSCAboL9G8KpnPSwdLlGehe3UXrWLAJF+yvJuV0J?=
 =?us-ascii?Q?4y77CWxikGJ8d1M22brMGE0h8mvB2NmqfXe300d8pyoLAB+I7DQu85KQv1Fu?=
 =?us-ascii?Q?vItomMO1mEYtOPBkG34rnRbNPXxLnxOBu6thzw7nqPCJLQfFfO6uLkol7Jhy?=
 =?us-ascii?Q?bcM/K7OJ1TBtj9Gr9NlYpMDeV4j69EwEXnlFd30U9IW7hGCzUEfK8/KMw752?=
 =?us-ascii?Q?RO2vjShq3VAf1+qsetyFwRYbNjNrq4spUVcyWrXiFKr8GjF+QNfPhFUJcY/L?=
 =?us-ascii?Q?ZE8kr0NnmkH23zqoVr93FgtYLVNFt1XQrWN5Ngh1m2jXy/YWgm/I+T5XbazK?=
 =?us-ascii?Q?fwtF/fMNT6k1CA+GlLNuFp1lyPcHkOZERnruocLDlym6iaVWZ7mQNjPC/ASh?=
 =?us-ascii?Q?OH0jBjoH+rDjO26WO2FqY/K9uqCSPVad4FfnbI3SsdoOS6j8O/3IhdFiFJdU?=
 =?us-ascii?Q?aY8yH/OaoQ+lI0FcBeSBQAGq9VEXVK54kU8Teurk76evOGKR4rS1ro3uIV6n?=
 =?us-ascii?Q?NCsG4G2oLsljdb623w/IWR9dAg0NqVjr0Ii7jg7/PJ29I2SvkrMXFOiB3ZkZ?=
 =?us-ascii?Q?Ujoto/ZLb8AOCij4iI/AmLH9+DTCma+FYzhsP+PHFGSXv1T2p1hrSZFmHQlv?=
 =?us-ascii?Q?fIu4mlcAZZeyp5/e0OowTY0H4OZ4vXvyeviksMnJQTkwvsZ3fHOp/svJ4hA3?=
 =?us-ascii?Q?r6a4+YfN4LnaLuCD/ZntA4wudGS2OoOky8GZ9WHzOjJvDRytyKOCM0bA5Is0?=
 =?us-ascii?Q?sObGhXap6K8o9DJtOo0nga36h7nHPTYHNAiZPdhHYtcqhyckG/mYnbrRowYg?=
 =?us-ascii?Q?jL5PL+2psYs+JpJpzb7n+KkYlvJDPOC6MA1Y6q1IGEjW3O187ptDAR0Qg5Bd?=
 =?us-ascii?Q?MHZAtIdDNIDQvvrow146xO5pih0c0jTi+8xk7JXJhAyvfnvlParZkiR6ZICV?=
 =?us-ascii?Q?N6xZDwhv4iPJ382SoryQamRSyF15im7M95xRIT+COA2H9M8e6PqQELYeS90d?=
 =?us-ascii?Q?mbNjQr0VqxafPGsItZhEplF7hRQ9J/+wBDv3NAWj+WQDn5hqIE5nsKyPBVwr?=
 =?us-ascii?Q?sjFPQJ/9Z+BTteRnWeE7+978DtNb97lluJp+dzWQkylfNGpnTH9HXILtTwW/?=
 =?us-ascii?Q?sg9FzUYQAVU3wKfT93GO+PIn2ubiL1axM9Em5HCZTnSx+0Ri3t9bLhmdH5Ho?=
 =?us-ascii?Q?AEDwd6O/MALsSc3zsGMPtzCM4Rg7gP0OglMvMyIOV5EOkiJxMV/7ImEXnlw8?=
 =?us-ascii?Q?4WNaGr1sZTU4HlqlYdmIwR0RmoesitrH3ZvFbeeRZ5Ip7gjrtaW4h85Xj4us?=
 =?us-ascii?Q?5F+0nAnpoF40/d84PjufRYHDYKep3xQaA2HpWAz5W7IFto5+QwzB3nb9U+sF?=
 =?us-ascii?Q?Y9D7X0MjNnsFv3jPWirAmSdvigYpFlvo/XRwYAWDWHMXP8kk1OKq7EBkxHK8?=
 =?us-ascii?Q?GdMIeM4dLm4ZC4nzj864k7aizqGIOnH57l66Hy9+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: cadence.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR07MB5381.namprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0f4f222-baab-4eb3-4209-08dabca4c067
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 07:35:01.4372
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Jat3gu4K+vpHd9F2lbLOl6dfvb5dQwkO52tqLMWVy2onwhr7+cVp7TQImvWGmRc0SzZfN1unC/NBxU+yGGosorcHWOWJcE/mDDOWijzZm70=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR07MB7550
X-Proofpoint-GUID: IWbxhE7zdfbU_JFVtpe8PwfAbKu07aZk
X-Proofpoint-ORIG-GUID: IWbxhE7zdfbU_JFVtpe8PwfAbKu07aZk
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-02_04,2022-11-01_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0
 lowpriorityscore=0 bulkscore=0 mlxlogscore=560 mlxscore=0 malwarescore=0
 phishscore=0 impostorscore=0 adultscore=0 spamscore=0 clxscore=1011
 priorityscore=1501 suspectscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2210170000 definitions=main-2211020045
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>
>On Tue, Nov 01, 2022 at 02:17:30PM +0800, Jing Leng wrote:
>> EP0 transfer is bi-directional, but in the cdnsp gadget, the
>> transmission direction of EP0 is not changed after it is initialized
>> to IN, so the OUT data from EP0 received by the host is invalid.
>>
>> The value of ep0_expect_in will change according to the value of
>> bRequestType in the SETUP transaction of control transfer, so we can
>> use it as the transmission direction of EP0.
>>
>> Signed-off-by: Jing Leng <jleng@ambarella.com>

Acked-by: Pawel Laszczak <pawell@cadence.com>

Thanks,
Pawel Laaszczak

>> ---
>> ChangeLog v2->v3:
>> - Repair my email address.
>
>Yes, it works, and it's validated!
>
>Nice job, thanks.  I'll let the cdns3 maintainer review it first, but just=
 wanted to
>say thanks for fixing this up, it makes my life a lot easier when acceptin=
g
>patches.
>
>greg k-h