Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
User-Agent: Microsoft-MacOutlook/16.66.22102801
Date:   Wed, 02 Nov 2022 16:06:37 +0800
Subject: Re: [PATCH] io_uring: fix two assignments in if conditions
From:   Xinghui Li <korantwork@gmail.com>
To:     kernel test robot <lkp@intel.com>, <axboe@kernel.dk>,
        Pavel Begunkov <asml.silence@gmail.com>
CC:     <llvm@lists.linux.dev>, <oe-kbuild-all@lists.linux.dev>,
        <io-uring@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Message-ID: <F8C3CD1A-A2C0-4772-8AB6-2F2ED04A9F76@gmail.com>
Thread-Topic: [PATCH] io_uring: fix two assignments in if conditions
References: <20221101072956.13028-1-korantwork@gmail.com>
 <202211012335.tCnMjA6q-lkp@intel.com>
In-Reply-To: <202211012335.tCnMjA6q-lkp@intel.com>
Mime-version: 1.0
Content-type: text/plain;
        charset="UTF-8"
Content-transfer-encoding: quoted-printable
Precedence: bulk


=EF=BB=BF=E5=9C=A8 2022/11/1 23:10=EF=BC=8C=E2=80=9Ckernel test robot=E2=80=9D<lkp@intel.com> =E5=86=99=E5=85=A5:

>    Hi,
>
>    Thank you for the patch! Perhaps something to improve:
>
>	......
>    If you fix the issue, kindly add following tag where applicable
>    | Reported-by: kernel test robot <lkp@intel.com>
>
>    All warnings (new ones prefixed by >>):
>
>    >> io_uring/poll.c:601:7: warning: variable 'apoll' is used uninitiali=
zed whenever 'if' condition is false [-Wsometimes-uninitialized]
>                       if (entry !=3D NULL)
>                           ^~~~~~~~~~~~~
>       io_uring/poll.c:608:2: note: uninitialized use occurs here
>               apoll->double_poll =3D NULL;
>               ^~~~~
>       io_uring/poll.c:601:3: note: remove the 'if' if its condition is al=
ways true
>                       if (entry !=3D NULL)
>                       ^~~~~~~~~~~~~~~~~~
>       io_uring/poll.c:594:26: note: initialize the variable 'apoll' to si=
lence this warning
>               struct async_poll *apoll;
>                                       ^
>                                        =3D NULL
>       1 warning generated.=20
>
>
>    vim +601 io_uring/poll.c
>
It is do a problem, I will sent v2.
Thanks a lot!
    --=20
    0-DAY CI Kernel Test Service
    https://01.org/lkp