Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Jiaming Li <lijiaming3@xiaomi.corp-partner.google.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        lijiaming3 <lijiaming3@xiaomi.com>
Subject: RE: [RESEND PATCH 2/4] scsi:ufs:add File-Based Optimization
 descriptor
Thread-Topic: [RESEND PATCH 2/4] scsi:ufs:add File-Based Optimization
 descriptor
Thread-Index: AQHY7nxiYzy11zcPc0KihkzA+PILzK4rQKcw
Date:   Wed, 2 Nov 2022 07:46:08 +0000
Message-ID: <BL0PR04MB65642CD12B5CFBCBB14CF602FC399@BL0PR04MB6564.namprd04.prod.outlook.com>
References: <20221102053058.21021-1-lijiaming3@xiaomi.corp-partner.google.com>
 <20221102053058.21021-3-lijiaming3@xiaomi.corp-partner.google.com>
In-Reply-To: <20221102053058.21021-3-lijiaming3@xiaomi.corp-partner.google.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uQD2lylNLCEeiXkG9SdVS3nwOSAt2rjtijVtPtjylFGzf5pGkQgJqV/gGkDO?=
 =?us-ascii?Q?G1N++W6mofLN3Fz0QdfxUnpUIloMl3ua4QbFhCCzptu47oXEWczhbtkxLxOj?=
 =?us-ascii?Q?WNUB7zoqpvZGSXJhbQzRRor/TcinGeasGotN8k1BHyeaKCTyRecQs6V281ki?=
 =?us-ascii?Q?TyImiWlYvYwUarzEJVnUZiCbtVDYhZeNpp+g7FemjGFiVIzOjF1pfSzBurWU?=
 =?us-ascii?Q?94WyTU3IHsm2xhQXlj6Y7rUoL8PawHsjM2JsL8gePqM2dm9lri2Ehh6at7yJ?=
 =?us-ascii?Q?t/YECU1TzdcRe2bXArzb4pKfOGcrjgTBMFoUmVKIiah+tX/9gz2JVaupXPmc?=
 =?us-ascii?Q?jp17m8aRIgex3rb4gR43BJ+iek1AfidAY2LSklh9yYuffBdY76W2F2FfNJRD?=
 =?us-ascii?Q?sURAlUFcz6llPf9N4+TJMo7tVYO7v5/W2EEXxXhBBrb8CYVhFokZMUdgLwwg?=
 =?us-ascii?Q?MMhygcbjyJtiB/mRbbwZky7ml5Ommqacsojv6SW2dNOunXLL13BbtauhT0dn?=
 =?us-ascii?Q?x00AE2lLAi5pFBCNM6e+/EzkIM+jXcrgTWH+Ggr3AagiZb9xXxJBOJMEOtCq?=
 =?us-ascii?Q?sHqHkWq/tn+9lIdPzqwlrwaSVJHUGafmjj8KJtqbwltmNPjJfg4V4XtUohz2?=
 =?us-ascii?Q?2/Pl7sMOgoFGWvjHQ+TZWhOjf+TWAh4VRmHeniUVPvFPmkQRQeXgw7nRPv3K?=
 =?us-ascii?Q?cHItsmeuwmjC/s2d/1wNFE1OJm11C53HTM0LUIlbxQXB/IvbRO8CmUvd3dEk?=
 =?us-ascii?Q?PBiBDRk4nW/J7PjwFX7X0+IrU++yqqwLj0ErStvL/0d7DN2qIX/U0kvyUwxI?=
 =?us-ascii?Q?P1hMuHGFe/W4NL/MY6tjbRfN0wa7X7axi7oPoEJok6RwHyYE4J22BfHD/iBh?=
 =?us-ascii?Q?fJ1YspCfQ8mcf3EDzfNmr034pG0d31z0kyKZGgv6HmaHYVAAh0yJ0NNxkm9z?=
 =?us-ascii?Q?hpS1M2z2x+bGEkt2ZbAnq55MLecTRArPom4jbtkOPSDTguCuuRaVXQciE7Hm?=
 =?us-ascii?Q?eoh0gc6px+gJX7R1Pa5ew6GeUMnluY+0K6Zbj1p2Z3DgvJbCMi05QdsqFgA/?=
 =?us-ascii?Q?mDELI3z3Cv26f1nc1+Ike40Ku7f83GxOzKTqD+H+b7Bwzqg9CAq/cAoIyJ9U?=
 =?us-ascii?Q?hfhrio8I/irLlfgB8242W6iiLHP0tsZT+vuBe4qsVA8JOw9381KJCurBPVLc?=
 =?us-ascii?Q?eqtQmGLYeiT1k0gXlI0NsaazXcrwe+MpIjAYTUi1gQaYS5eN5YqE5Nc23rM2?=
 =?us-ascii?Q?QCIHehPLZIZnnRHBnW8AGER4mc9xaYzUBf8QSq7HLyQrNsuH1u22rWuGYTKp?=
 =?us-ascii?Q?51b6gPY/WDAJAG7WtzfNTKhL2xnvv0kRVhODnoz0t48shhuZ1tKO9IZw5h51?=
 =?us-ascii?Q?5XpiLpH72IfxasRUxBolZwkveWNhK/RDx02+XNMKVKNytrnRx7LXiz0yRYxi?=
 =?us-ascii?Q?sOGwvQtA7qLjNWbo7OfKGZEmcY1i9S+ynl2bEEQSVV0ZyhTUwyyWSog8Hmzc?=
 =?us-ascii?Q?JX6YtzC3pq/KqAyrG/jLji4D5G2El/D3GMmnpJoooy8mdAFcz3kz3x7nlXKR?=
 =?us-ascii?Q?rOP1vzoZ72I19NH1s21vqOb8M3+/VcBU+QbB8s6i?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL0PR04MB6564.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1df45e87-fb84-4714-16da-08dabca64e26
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 07:46:08.7746
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: R8HozjLG0SBD/bm3x2LLHtYedRPalfi2KVDJxBtkFZPPZ0dEvn0c024HMxuUEiJBv8IeSjLkjCQ1a8bgwpCIpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR04MB3910
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: lijiaming3 <lijiaming3@xiaomi.com>
>=20
> The full information about the descriptor could be found at UFS
> specifications - FBO extension.
>=20
> Signed-off-by: lijiaming3 <lijiaming3@xiaomi.com>
For some reason there are spaces missing in the patch header: scsi: ufs: Ad=
d....
Other than that:
Reviewed-by: Avri Altman <avri.altman@wdc.com>

> ---
>  Documentation/ABI/testing/sysfs-driver-ufs | 65 ++++++++++++++++++++++
>  drivers/ufs/core/ufs-sysfs.c               | 26 +++++++++
>  include/ufs/ufs.h                          | 13 +++++
>  3 files changed, 104 insertions(+)
>=20
> diff --git a/Documentation/ABI/testing/sysfs-driver-ufs
> b/Documentation/ABI/testing/sysfs-driver-ufs
> index 228aa43e14ed..63daccbf7a8d 100644
> --- a/Documentation/ABI/testing/sysfs-driver-ufs
> +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> @@ -1710,3 +1710,68 @@ Contact: Avri Altman <avri.altman@wdc.com>
>  Description:   In host control mode the host is the originator of map
> requests.
>                 To avoid flooding the device with map requests, use a sim=
ple
> throttling
>                 mechanism that limits the number of inflight map requests=
.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/fbo_descriptor/fbo_version
> +What:          /sys/bus/platform/devices/*.ufs/fbo_descriptor/fbo_versio=
n
> +Date:          November 2022
> +Contact:       li jiaming <lijiaming3@xiaomi.com>
> +Description:   This file shows the version of UFS file-based optimizatio=
n. This
> +               is one of the UFS fbo descriptor parameters. The full inf=
ormation
> about
> +               the descriptor could be found at UFS specifications - FBO=
 extension.
> +
> +               The file is read only.
> +
> +What:          /sys/bus/platform/drivers/ufshcd/*/fbo_descriptor/fbo_rec=
_lrs
> +What:          /sys/bus/platform/devices/*.ufs/fbo_descriptor/fbo_rec_lr=
s
> +Date:          November 2022
> +Contact:       li jiaming <lijiaming3@xiaomi.com>
> +Description:   This file shows the recommended LBA range size of UFS fil=
e-
> based
> +               optimization to be used by the host. This is one of the U=
FS fbo
> descriptor
> +               parameters. The full information about the descriptor cou=
ld be
> found at UFS
> +               specifications - FBO extension.
> +
> +               The file is read only.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/fbo_descriptor/fbo_max_lrs
> +What:          /sys/bus/platform/devices/*.ufs/fbo_descriptor/fbo_max_lr=
s
> +Date:          November 2022
> +Contact:       li jiaming <lijiaming3@xiaomi.com>
> +Description:   This file shows the max LBA range size of UFS file-based
> +               optimization to be used by the host. This is one of the U=
FS fbo
> descriptor
> +               parameters. The full information about the descriptor cou=
ld be
> found at UFS
> +               specifications - FBO extension.
> +
> +               The file is read only.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/fbo_descriptor/fbo_min_lrs
> +What:          /sys/bus/platform/devices/*.ufs/fbo_descriptor/fbo_min_lr=
s
> +Date:          November 2022
> +Contact:       li jiaming <lijiaming3@xiaomi.com>
> +Description:   This file shows the min LBA range size of UFS file-based
> +               optimization to be used by the host. This is one of the U=
FS fbo
> descriptor
> +               parameters. The full information about the descriptor cou=
ld be
> found at UFS
> +               specifications - FBO extension.
> +
> +               The file is read only.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/fbo_descriptor/fbo_max_lrc
> +What:          /sys/bus/platform/devices/*.ufs/fbo_descriptor/fbo_max_lr=
c
> +Date:          November 2022
> +Contact:       li jiaming <lijiaming3@xiaomi.com>
> +Description:   This file shows the max number of LBA ranges supported by
> read/write
> +               buffer command of UFS file-based optimization. This is on=
e of the
> UFS fbo
> +               descriptor parameters. The full information about the des=
criptor
> could be
> +               found at UFS specifications - FBO extension.
> +
> +               The file is read only.
> +
> +What:          /sys/bus/platform/drivers/ufshcd/*/fbo_descriptor/fbo_lra
> +What:          /sys/bus/platform/devices/*.ufs/fbo_descriptor/fbo_lra
> +Date:          November 2022
> +Contact:       li jiaming <lijiaming3@xiaomi.com>
> +Description:   This file shows the alignment requirement of UFS file-bas=
ed
> +               optimization. This is one of the UFS fbo descriptor param=
eters. The
> +               full information about the descriptor could be found at U=
FS
> +               specifications - FBO extension.
> +
> +               The file is read only.
> diff --git a/drivers/ufs/core/ufs-sysfs.c b/drivers/ufs/core/ufs-sysfs.c =
index
> 53aea56d1de1..006d99b15be0 100644
> --- a/drivers/ufs/core/ufs-sysfs.c
> +++ b/drivers/ufs/core/ufs-sysfs.c
> @@ -871,6 +871,31 @@ static const struct attribute_group
> ufs_sysfs_health_descriptor_group =3D {
>         .attrs =3D ufs_sysfs_health_descriptor,  };
>=20
> +#define UFS_FBO_DESC_PARAM(_name, _uname, _size)                       \
> +       UFS_DESC_PARAM(_name, _uname, FBO, _size)
> +
> +UFS_FBO_DESC_PARAM(fbo_version, _VERSION, 2);
> +UFS_FBO_DESC_PARAM(fbo_rec_lrs, _REC_LBA_RANGE_SIZE, 4);
> +UFS_FBO_DESC_PARAM(fbo_max_lrs, _MAX_LBA_RANGE_SIZE, 4);
> +UFS_FBO_DESC_PARAM(fbo_min_lrs, _MIN_LBA_RANGE_SIZE, 4);
> +UFS_FBO_DESC_PARAM(fbo_max_lrc, _MAX_LBA_RANGE_CONUT, 1);
> +UFS_FBO_DESC_PARAM(fbo_lra, _MAX_LBA_RANGE_ALIGNMENT, 2);
> +
> +static struct attribute *ufs_sysfs_fbo_descriptor[] =3D {
> +       &dev_attr_fbo_version.attr,
> +       &dev_attr_fbo_rec_lrs.attr,
> +       &dev_attr_fbo_max_lrs.attr,
> +       &dev_attr_fbo_min_lrs.attr,
> +       &dev_attr_fbo_max_lrc.attr,
> +       &dev_attr_fbo_lra.attr,
> +       NULL,
> +};
> +
> +static const struct attribute_group ufs_sysfs_fbo_descriptor_group =3D {
> +       .name =3D "fbo_descriptor",
> +       .attrs =3D ufs_sysfs_fbo_descriptor, };
> +
>  #define UFS_POWER_DESC_PARAM(_name, _uname, _index)                    \
>  static ssize_t _name##_index##_show(struct device *dev,                 =
       \
>         struct device_attribute *attr, char *buf)                       \
> @@ -1220,6 +1245,7 @@ static const struct attribute_group
> *ufs_sysfs_groups[] =3D {
>         &ufs_sysfs_interconnect_descriptor_group,
>         &ufs_sysfs_geometry_descriptor_group,
>         &ufs_sysfs_health_descriptor_group,
> +       &ufs_sysfs_fbo_descriptor_group,
>         &ufs_sysfs_power_descriptor_group,
>         &ufs_sysfs_string_descriptors_group,
>         &ufs_sysfs_flags_group,
> diff --git a/include/ufs/ufs.h b/include/ufs/ufs.h index
> 1bba3fead2ce..c3fd954ce005 100644
> --- a/include/ufs/ufs.h
> +++ b/include/ufs/ufs.h
> @@ -179,6 +179,7 @@ enum desc_idn {
>         QUERY_DESC_IDN_GEOMETRY         =3D 0x7,
>         QUERY_DESC_IDN_POWER            =3D 0x8,
>         QUERY_DESC_IDN_HEALTH           =3D 0x9,
> +       QUERY_DESC_IDN_FBO              =3D 0xA,
>         QUERY_DESC_IDN_MAX,
>  };
>=20
> @@ -319,6 +320,17 @@ enum health_desc_param {
>         HEALTH_DESC_PARAM_LIFE_TIME_EST_B       =3D 0x4,
>  };
>=20
> +/* File-based Optimization descriptor parameters offsets in bytes */
> +enum fbo_desc_param {
> +       FBO_DESC_PARAM_LEN                      =3D 0x0,
> +       FBO_DESC_PARAM_VERSION                  =3D 0x1,
> +       FBO_DESC_PARAM_REC_LBA_RANGE_SIZE       =3D 0x3,
> +       FBO_DESC_PARAM_MAX_LBA_RANGE_SIZE       =3D 0x7,
> +       FBO_DESC_PARAM_MIN_LBA_RANGE_SIZE       =3D 0xB,
> +       FBO_DESC_PARAM_MAX_LBA_RANGE_CONUT      =3D 0xF,
> +       FBO_DESC_PARAM_MAX_LBA_RANGE_ALIGNMENT  =3D 0x10, };
> +
>  /* WriteBooster buffer mode */
>  enum {
>         WB_BUF_MODE_LU_DEDICATED        =3D 0x0,
> @@ -352,6 +364,7 @@ enum {
>         UFS_DEV_EXT_TEMP_NOTIF          =3D BIT(6),
>         UFS_DEV_HPB_SUPPORT             =3D BIT(7),
>         UFS_DEV_WRITE_BOOSTER_SUP       =3D BIT(8),
> +       UFS_DEV_FBO_SUP                 =3D BIT(17),
>  };
>  #define UFS_DEV_HPB_SUPPORT_VERSION            0x310
>=20
> --
> 2.38.1