Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eaa66c56-de8b-ea8e-6907-41535c4c16ac@mind.be>
Date:   Wed, 2 Nov 2022 09:21:19 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] leds: lp5523: fix out-of-bounds bug in lp5523_selftest()
Content-Language: en-US
To:     Pavel Machek <pavel@ucw.cz>
Cc:     Arne Staessen <a.staessen@televic.com>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20221028105643.45300-1-maarten.zanders@mind.be>
 <20221028153457.GA14936@duo.ucw.cz>
From:   Maarten Zanders <maarten.zanders@mind.be>
In-Reply-To: <20221028153457.GA14936@duo.ucw.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Pavel,

On 10/28/22 17:34, Pavel Machek wrote:
> I wonder, should we do these kind of actions on attribute _read_? I'd
> preffer some kind of write action to trigger this.
>
Yes I agree that doing these kind of things on a file read feels somehow 
strange. Strictly speaking, I guess you would implement an IOCTL to 
initiate the action and then perform a read to get the result. But that 
would needlessly complicate things on both ends? I'll keep it in mind 
and when I encounter similar interfaces in other drivers get back to 
this if needed.